Jess

Hi, you should downgrade back to Manga+Press 3.0. Manga+Press 4.0 is a different beast and changes the way templates are rendered to be more inline with how WordPress handles things–lots of new actions and filters that I haven’t had time to document.

Sorry for the inconvenience.

A head’s up: instead of modifying the plugin, add your new class to your own theme and load it via the mangapress_theme_compatible-{$theme} hook. In this case, it would actually be mangapress_theme_compatible-twentytwenty.

Example:

function mytheme_twentytwenty_compat() {
   require_once "class-twentytwenty.php";
}
add_action('mangapress_theme_compatible-twentytwenty', 'mytheme_twentytwenty_compat');

1) It’s not recommended to change plugin code since it’ll get overwritten if you update the plugin.

2) The calls weren’t actually removed, they were replaced by hooks to make the code more manageable.

Under resources/templates/ is where the plugin templates are located. If you look at archive-comic.php, single-comic.php, and page-latest-comic.php, these templates should give you an idea of what hooks to use in your own theme.

Finally, downgrading back to Manga+Press 3.0 is a recommended course of action for your live site.

It’s actually better to run Manga+Press 4.0 locally and work on making your theme compatible instead of running it on the live server.

I’ve been working on documentation for upgrading themes to be compatible with MP 4.0. Until documentation is available, it’s bests to stay with 3.0 for now.

No apologies necessary! You basically just created a theme support class for TwentyTwenty, which I can tweak and add to the next release so many thanks there!

Yeah, a plugin upgrade would definitely destroy those changes. Also, any changes to the files under the /vendor/ directory would be overridden if you ran Composer.

Once again, thanks!

Basically, we’ve got two issues going on: with the option page, and then with the archive page.

Right now, I still can’t reproduce the error but I may have an idea of what is causing the problem–it’s likely the drop-down grouping by post-type. That addition caused me a lot of issues in initial development, one of which was a problematic “invalid foreach” error that seemed to randomly crop up. I’m going to remove that with the next RC version if it’s causing other users problems. On that note: do you have any Comic Pages (new post-type added in this version) created?

I looked at your archive page, and compared with the settings you provided in my environment–it’s working as expected. Basically, it’s hard to tell if ordering is working properly because your comic posts all have the same date.

Side-note: if you want to get rid of the default styling for the gallery, there’s a filter that you can override like so:
add_filter('mangapress_archive_gallery_style', '__return_empty_string');

Thanks for the additional information!

Hi @hatchb4ck, I can’t reproduce this so I’ll need some additional information:

What PHP version are you using?

A url to the archive page itself.

Which archive page settings are you using?

Thanks!

@hatchb4ck Thanks for letting me know! I should have some free time this weekend to dig into the issue.

Hi, I’ve looked at the page but I’m not sure what the issue is. The image is displaying full-size as expected. I’ve checked on mobile as well as desktop, and I’m not finding any issues. As for the srcset issue, I believe that is default WordPress behavior. The plugin is leveraging the_post_thumbnail function to display the comic image. On the comic archive: the comic archive page itself has three different templates. If you were originally using the gallery template, then the images displayed there being smaller than the comic pages themselves makes sense since the archive gallery template is intended to display all of the comics in the series.

Does this make sense?

Awesome, thanks! Now I’m seeing how that’s supposed to work. And colored me shocked to find that Smack Jeeves is still around.

Anyway, I think this code-fragment might do what you’re asking: https://gist.github.com/jesgs/81347658e4cdd186b686011c89a7369b

However, be warned: I haven’t tested this so your mileage may vary!

It should go in the template for either the single comic view (single-comic.php) or Latest Comic template (latest-comic.php). Since you’re using a 3rd party theme, it’s good practice to create a child-theme of your main-theme first, then add the templates you wish to override.

These links provides some additional information on extending Manga+Press with child-themes, or creating a child-theme in general:
https://docs.manga-press.com/getting-started/theme-customization.html
https://codex.www.ads-software.com/Child_Themes#Creating_a_Child_Theme_from_an_Unmodified_Parent_Theme

Hope this helps!

Adding a tag for Yoast in case anyone else is having issues. There’s been a second reported case of an issue with Yoast.

Yeah, I found out about the issue with Yoast from another user (not necessarily scrolling — but the comic not showing up). The only thing I can think of why that might be is how the current version of M+P is handling the content for the Latest Comic page. It’s something that I’m working to fix in the next version.

Thanks for reporting that, it gives me another confirmed report of issues with Yoast!

It doesn’t sound like you’ve missed anything. You may have to dig through the theme and see if it’s shrinking the image down using CSS. I’d have to see the site, and know which theme you’re using before I can say what the issue is, though.

Thanks!

• This reply was modified 6 years, 3 months ago by Jess.

Not a problem!

WP Super Cache — yeah, that could be why you’re not seeing any changes. If your site doesn’t get a huge amount of traffic, then you probably don’t need it. Also, when you’re debugging your site, try using Incognito tabs in Chrome to help get around issues caused by caching. Sometimes, it can help view changes with server-side caches but it’s mostly to get around the browser’s cache.

• This reply was modified 6 years, 4 months ago by Jess.

The plugins that you’re using are actually more important than the server configuration ?? Some times (actually a lot of times) plugins can conflict with each other if they’re trying to modify the same hooks.

From looking at your markup, my guess is that Themify PageBuilder is interfering with the display of the comic image. Manga+Press hooks into the the_content filter to do its thing, and from what I’ve been able to find, Page Builder is also doing something with the_content filter. If it’s not PageBuilder, try deactivating all of the plugins except for Manga+Press. The idea is to eliminate other plugins as being the problem. After that, try going back to the base TwentyFifteen theme since it looks like you’re using a child-theme of TwentyFifteen.

Finally, when you’re asking for support for a plugin that’s provided for free, please try to be patient and understand that a lot of plugin authors like myself work a full-time job so it might be a bit before someone gets back to you.

Thanks, and I hope that helps!

Oh, and if I think of any additional ideas, I’ll post them when I get a free moment.

• This reply was modified 6 years, 4 months ago by Jess. Reason: random things remembered at the last minute

Preliminary testing is showing that the issue happens with Network Activation. The quick fix is to deactivate Manga+Press network wide (Network Deactivate), and then enable Manga+Press on a site-by-site basis. There is a problem, though. Turning off Network Activation, and then re-enabling Manga+Press for a specific site causes issues with saving options—I’m getting a 500 error whenever I try, although it does not cause problems for sites that existed before Manga+Press was network activated.

Basically, what you’re going to have to do is:

1. turn off Network Activation for Manga+Press.
2. Backup and recreate the affected site. Content and images only—ignore options and settings. Re-create those manually if you need them.
3. Activate Manga+Press for that site ONLY (or only on sites where you need it)
4. Then set up your options.

All of my testing is showing that Manga+Press Options should stay set once you’ve completed those steps. Let me know if that fixes the issue.

And I need to update that README.

• This reply was modified 6 years, 8 months ago by Jess.