Forum Replies Created

Viewing 15 replies - 1 through 15 (of 20 total)
  • Thread Starter Arnd030

    (@arnd030)

    Thanks. Interesting … maybe a problem with the Classic Editor plugin then.

    Arnd030

    (@arnd030)

    This is very odd. I had all thumbs re-calculated, with thumbnail width set to 230px in the media settings page for thumbnail as well as in the PhotoSwipe Options in “Thumbnail Width”
    As a result, all thumbs have now 460px width – exactly twice the setting.

    The lines Aleksandr mentions above are already commented out in my version of this plugin.

    Arnd030

    (@arnd030)

    Bug confirmed. To be precise: On load, the plugin should use the image version specified in the gallery, which is usually thumb, but can be medium or large also.

    Thread Starter Arnd030

    (@arnd030)

    Thanks for the information, solved this.
    I also needed the gallery to be aligned left rather than center, achieved this via .psgal {margin:0 !important}

    Thread Starter Arnd030

    (@arnd030)

    Sorry, my mistake. Found solution in FAQ; missing ‘before_widget’ in functions.php. Thanks for quick response.

    Arnd030

    (@arnd030)

    Same here too.

    This contradicts the “How to proceed?” info, which reads:

    “Activate Polylang and WPML to Polylang. Do not create any language with Polylang.”

    Ideas?

    Thanks

    Arnd

    Thread Starter Arnd030

    (@arnd030)

    OMG, my fault.

    I hit the wrong button – “Apply” instead of “Save changes”.

    I have to scroll down a bit to see the right button. I am sure I am not the first to make this mistake…

    Thread Starter Arnd030

    (@arnd030)

    UPDATE: Issue disappeared overnight and alas I can not reproduce it. Can be closed, but any advice what might cause this is still appreciated. As I wrote, I had that before.

    Sorry, too fast. Problem still there. Sometimes changes are saved, sometimes not. Completely random. :-/

    • This reply was modified 6 years, 5 months ago by Arnd030.
    • This reply was modified 6 years, 5 months ago by Arnd030.
    Thread Starter Arnd030

    (@arnd030)

    Thanks.

    Thread Starter Arnd030

    (@arnd030)

    Excellent! I think you’re right, thank you very much.
    I patched shariff.php as you suggested and the HTML errors are gone.

    So, it’s a bug? Am I the first to notice it?

    Thread Starter Arnd030

    (@arnd030)

    I uploaded my translation files event-post-de_DE.mo and event-post-de_DE.po into /languages/ in the plugin directory, where the other translations are. Worked in the version before.

    Thread Starter Arnd030

    (@arnd030)

    Thank you very much!

    Thread Starter Arnd030

    (@arnd030)

    I think I found it.

    It is deliberate. In function delta_date in eventpost.php, you check if the event is over several days, and only display the time of day for events on a single day.

    It would be better to display the time also on events over several days. For example, people want to know at what time to arrive on Friday evening for a weekend event.

    I tried to patch the script like this:

    /**
         *
         * @param timestamp $time_start
         * @param timestamp $time_end
         * @return string
         */
        public function delta_date($time_start, $time_end){
            if(!$time_start || !$time_end){
                return;
            }
    
            //Display dates
            $dates="\t\t\t\t".'<div class="event_date" data-start="' . $this->human_date($time_start) . '" data-end="' . $this->human_date($time_end) . '">';
            if (date('d/m/Y', $time_start) == date('d/m/Y', $time_end)) { // same day
                $dates.= "\n\t\t\t\t\t\t\t".'<time itemprop="dtstart" datetime="' . date_i18n('c', $time_start) . '">'
                        . '<span class="date date-single">' . $this->human_date($time_end, $this->settings['dateformat']) . "</span>";
                if (date('H:i', $time_start) != date('H:i', $time_end) && date('H:i', $time_start) != '00:00' && date('H:i', $time_end) != '00:00') {
                    $dates.='   <span class="linking_word linking_word-from">' . __('from', 'event-post') . '</span>
                                <span class="time time-start">' . date_i18n($this->settings['timeformat'], $time_start) . '</span>
                                <span class="linking_word linking_word-t">' . __('to', 'event-post') . '</span>
                                <span class="time time-end">' . date_i18n($this->settings['timeformat'], $time_end) . '</span>';
                }
                elseif (date('H:i', $time_start) != '00:00') {
                    $dates.='   <span class="linking_word">' . __('at', 'event-post') . '</span>
                                <time class="time time-single" itemprop="dtstart" datetime="' . date_i18n('c', $time_start) . '">' . date_i18n($this->settings['timeformat'], $time_start) . '</time>';
                }
                $dates.="\n\t\t\t\t\t\t\t".'</time>';
            } else { // not same day
                $dates.= '
                    <span class="linking_word linking_word-from">' . __('from', 'event-post') . '</span>
                    <time class="date date-start" itemprop="dtstart" datetime="' . date('c', $time_start) . '">' . $this->human_date($time_start, $this->settings['dateformat']);
                    
    
                     if (date('H:i', $time_start) != date('H:i', $time_end) && date('H:i', $time_start) != '00:00' && date('H:i', $time_end) != '00:00') 
                      $dates.= ', ' . date_i18n($this->settings['timeformat'], $time_start);
                    
                    $dates.='</time>
                    
                    <span class="linking_word linking_word-to">' . __('to', 'event-post') . '</span>
                    <time class="date date-end" itemprop="dtend" datetime="' . date('c', $time_end) . '">' . $this->human_date($time_end, $this->settings['dateformat']);
                    
                    if (date('H:i', $time_start) != date('H:i', $time_end) && date('H:i', $time_start) != '00:00' && date('H:i', $time_end) != '00:00') {
                      $dates.=  ', ' . date_i18n($this->settings['timeformat'], $time_end);
                }
                $dates.='</time>';
            }
            $dates.="\n\t\t\t\t\t\t".'</div><!-- .event_date -->';
            return $dates;
        }

    I changed the part after line 609, the else-part for events over several days.

    Could you be so kind to look into this and check for mistakes? I am not sure if I understand your code correctly.

    Thank you very much

    Arnd

    PS: There is a problem with this forum, my reply disappeared after a small edit, and after re-posting I get “Duplicate reply detected” though the reply is not there.

    Thread Starter Arnd030

    (@arnd030)

    I think I found it.

    It is deliberate. In function delta_date in eventpost.php, you check if the event is over several days, and only display the time of day for events on a single day.

    It would be better to display the time also on events over several days. For example, people want to know at what time to arrive on Friday evening for a weekend event.

    I tried to patch the script like this:

    /**
         *
         * @param timestamp $time_start
         * @param timestamp $time_end
         * @return string
         */
        public function delta_date($time_start, $time_end){
            if(!$time_start || !$time_end){
                return;
            }
    
            //Display dates
            $dates="\t\t\t\t".'<div class="event_date" data-start="' . $this->human_date($time_start) . '" data-end="' . $this->human_date($time_end) . '">';
            if (date('d/m/Y', $time_start) == date('d/m/Y', $time_end)) { // same day
                $dates.= "\n\t\t\t\t\t\t\t".'<time itemprop="dtstart" datetime="' . date_i18n('c', $time_start) . '">'
                        . '<span class="date date-single">' . $this->human_date($time_end, $this->settings['dateformat']) . "</span>";
                if (date('H:i', $time_start) != date('H:i', $time_end) && date('H:i', $time_start) != '00:00' && date('H:i', $time_end) != '00:00') {
                    $dates.='   <span class="linking_word linking_word-from">' . __('from', 'event-post') . '</span>
                                <span class="time time-start">' . date_i18n($this->settings['timeformat'], $time_start) . '</span>
                                <span class="linking_word linking_word-t">' . __('to', 'event-post') . '</span>
                                <span class="time time-end">' . date_i18n($this->settings['timeformat'], $time_end) . '</span>';
                }
                elseif (date('H:i', $time_start) != '00:00') {
                    $dates.='   <span class="linking_word">' . __('at', 'event-post') . '</span>
                                <time class="time time-single" itemprop="dtstart" datetime="' . date_i18n('c', $time_start) . '">' . date_i18n($this->settings['timeformat'], $time_start) . '</time>';
                }
                $dates.="\n\t\t\t\t\t\t\t".'</time>';
            } else { // not same day
                $dates.= '
                    <span class="linking_word linking_word-from">' . __('from', 'event-post') . '</span>
                    <time class="date date-start" itemprop="dtstart" datetime="' . date('c', $time_start) . '">' . $this->human_date($time_start, $this->settings['dateformat']);
                    
    
                     if (date('H:i', $time_start) != date('H:i', $time_end) && date('H:i', $time_start) != '00:00' && date('H:i', $time_end) != '00:00') 
                      $dates.= ', ' . date_i18n($this->settings['timeformat'], $time_start);
                    
                    $dates.='</time>
                    
                    <span class="linking_word linking_word-to">' . __('to', 'event-post') . '</span>
                    <time class="date date-end" itemprop="dtend" datetime="' . date('c', $time_end) . '">' . $this->human_date($time_end, $this->settings['dateformat']);
                    
                    if (date('H:i', $time_start) != date('H:i', $time_end) && date('H:i', $time_start) != '00:00' && date('H:i', $time_end) != '00:00') {
                      $dates.=  ', ' . date_i18n($this->settings['timeformat'], $time_end);
                }
                $dates.='</time>';
            }
            $dates.="\n\t\t\t\t\t\t".'</div><!-- .event_date -->';
            return $dates;
        }

    I changed the part after line 609, the else-part for events over several days.

    Could you be so kind to look into this and check for mistakes? I am not sure if I understand your code correctly.

    Thank you very much

    Arnd

    • This reply was modified 7 years, 5 months ago by Arnd030.
    Thread Starter Arnd030

    (@arnd030)

    Update: We are using TinyMCE advanced. Can it cause the problems? It’s not on the list of Incompatible plugins but there are several TinyMCE-related issues mentioned.

Viewing 15 replies - 1 through 15 (of 20 total)