Kiril Reznik

Bug still present:
WP 4.5.2
Wordpress SEO 3.2.5

Now the plugin runs wp_filter_post_kses() on the meta values.

For now I’ve disabled the filtering completely but in the future I hope they will base the filtering based on the permission the user have.
I.E users who have Administrator previleges should be able to use any tag inside in the meta values (including iframe, script and style).

Here is the fixed file: /types/embedded/classes/loader.php

https://pastebin.com/fpVaZ1pa

Open this file:
\wp-content\plugins\types\embedded\common\toolset-forms\classes

Starting on line 29, repalce with:

public function __construct()
    {
        global $pagenow;
		if (
            //for edit group pages
            (isset($_GET['page']) && ($_GET['page'] == 'wpcf-edit-usermeta' || $_GET['page'] == 'wpcf-edit')) ||
            //for edit pages including profile pages
            ($pagenow == 'profile.php' || $pagenow == 'post-new.php' || $pagenow == 'user-edit.php' || $pagenow == 'user-new.php' || $pagenow == 'post.php' || $pagenow == 'admin-ajax.php')
        ) {
            add_action( 'admin_enqueue_scripts', array( $this,'date_enqueue_scripts' ) );
		}
		$this->localization_slug = false;
    }

A small fix for a major problem. Not sure why it is taking so long for the Types authors to fix this issue.

Same error message here.

Thanks for the reply Rich.

In my opinion this should be considered a bug; since it goes against the logic of having a “disable default styles” option.

It would help a lot if you could disable the addition of styles properly in the source code with a conditional.

Thanks for the reply, but please consider making that change ??

Yes but don’t you think that if somebody deliberately chooses to disable the default CSS, the person actually knows what he is doing and is capable to provide IE8 fallbacks if needed?

In fact, if somebody decided to use “display: inline-block;” instead of floats, or perhaps uses the extended margin syntax (“margin-right”, “margin-left”, etc) it will make his life harder since he also got to know how to “revert” the inline styles applied.

To sum it up, in my opinion there is nothing wrong with including the basic css + inline styles for users who chooses to keep the “default style” but in case somebody chooses to deliberately disable the default styling, it shouldn’t add any styles at all.

If somebody non-technical wants to make small changes, they have the customization box, which is separate from the default styling radio buttons.

P.S – its a simple matter of adding an IF statement to check if the “use default styles” have been set to “no” and then make sure to prevent the inline styles to be included with wp_head() / wp_footer().

I’m aware they can be overridden with !important tags. But again, in my opinion if there is an option that allows to disable default styling it should disable all font-end styling completely, especially if its inline styles.

Thanks

And it shouldn’t be happening, since this defeats the who purpose of disabling the default styling so that you can make your own, isn’t it?

Thanks alot!!

Sorry I forgot to mention that I’m using WordPress 3.1