avioli

Thanks Mikko Saari

BTW, your Donate button just saves the changes, instead of going to PayPal ??

There are more issues I fixed:

• Custom first and last field names (coz I’m not using firstname and lastname as fields, but name_first and name_last).
• Confirmation response padding – textarea should not have empty spaces around its value.
• Better api calls, because import_single_member acts a tiny bit differently now, since they moved to Python.

If you want them – do you have a repo that I can tap in or could I give you a git patch (maybe safer ?? )?

My github username is avioli. My email is public.

Do you have a repo that I can fork/clone? GIT, SVN, Mercurial?
Nightly builds otherwise? A setting to fetch updates from a nightly builds server?

Not sure how much you would like the code to be considered open, though.
Even though your plugin is free ??

By enabling WP_DEBUG inside your wp-config.php you’ll notice several errors within your plugin code:

Function form inside the MinitwitterWidget class doesn’t initialise the variables of the $instance:

function form($instance) {
$instance = array_merge( array(
 'username' => ''
 ,'limit' => ''
 ,'list' => ''
 ,'query' => ''
), (array)$instance );
?>

Same thing with the widget function within the same class. This won’t even show as an error, since as soon as you instantiate the widget into a sidebar it’s default values are saved. At least check for empty(). BTW if you have WP_DEBUG turned on the default values are the error notices!

Thank god that shortcode_atts() deals with this on its own.

And the last one – this line: add_shortcode('minitwitter', mtf_create_shortcode); should have quotes:add_shortcode('minitwitter', 'mtf_create_shortcode');, otherwise the second argument is considered an undefined constant, and yields an error notice. It’s a notice, since undefined constants default to their names as strings.

Cheers.

BTW if you put the last bit of code inside a wp_enqueue_scripts action, you’ll ensure that $wp_scripts is ready to use.

By the way you are using wp_deregister_script('jquery'); and then loading the latest version from Google’s Ajax Library – this is not a wise move.

I do have scripts that don’t work with the latest version and your plugin is forcing my website to use it.

Better use simply wp_enqueue_script('jquery'); or check jquery version within your script if you require latest and greatest and notify the user of your implied version!

global $wp_scripts;
if ( isset( $wp_scripts->registered['jquery'] ) && ( version_compare( $wp_scripts->registered['jquery']->ver, '1.7.2', '>=' ) ) ) {
  print_r('go go go');
}