Barry Ceelen
Forum Replies Created
-
Forum: Reviews
In reply to: [Automatic Login] Works as expected! Thanks!Thanks for the review @andrewmead !
Hi @captaincrash,
I left a note on Stack Overflow. I’ll go ahead and mark this question resolved to keep this support forum about the Default Admin Color Scheme plugin on topic.
Thanks for reaching out!
Hi @captaincrash ,
I left an answer on your Stack Overflow question, hope that helps!
Forum: Plugins
In reply to: [Default Admin Color Scheme] Network settingsHi @ludovicsclain,
network activating the plugin should just activate the plugin on all sites, so you don’t have to activate it separately for each site. Each site should then still update the plugin settings separately though.
I’m afraid the plugin does not provide an option to set a default color scheme for all sites in the network. That does sound like it would be a nice option to have! I’ll be looking into that for a future update.
Thanks for your feedback!
The update check is performed there, and the option set, but it updates the options on each page load again, regardless of whether the option has been set before. Your developers should look into refactoring that part.
Thanks for your reply Nastia, but unfortunately that has nothing to do with the issue described here.
The plugin unnecessarily writes to the database twice on the
init
hook for each request:update_option( 'hustle_popup_migrated', true );
update_option( 'hustle_20_migrated', true );
Forum: Plugins
In reply to: [hideShowPassword] Uncaught ReferenceHi SooBahkDo,
if you use the Chrome browser and look at the JavaScript console in its dev tools it will show a bunch lots of errors like:
Mixed Content: The page at 'https://institute.soobahkdo.org/wp-login.php' was loaded over HTTPS, but requested an insecure script 'https://institute.soobahkdo.org/wp-includes/js/jquery/jquery.js?ver=1.12.4'. This request has been blocked; the content must be served over HTTPS.
This means you are serving your page over HTTPS, but (some of) your scripts and styles are loaded over HTTP. The browser does not like that and doesn’t load them. (This is unrelated to the hideShowPassword plugin).
As for the GitHub version, I started to clean up the plugin code. Haven’t had the time to finish that so it is not in the WordPress plugin repository yet.
When you solve the HTTPS vs. HTTP problem, the one in the plugin repository should work as expected though.
- This reply was modified 7 years, 1 month ago by Barry Ceelen.
- This reply was modified 7 years, 1 month ago by Steven Stern (sterndata).
Forum: Plugins
In reply to: [hideShowPassword] Uncaught ReferenceHi @soobahkdo, thanks for reporting this.
The error message means that jQuery is not loaded on the current page, and hideShowPassword.js and public.js are referencing it.
I see no javascript errors in my test environment, can you share a link to the login screen where this is happening? (Note that the plugin is currently only designed to work on the default WordPress admin login screen).
Forum: Plugins
In reply to: [hideShowPassword] Woocommerce login@eljkmw What happens there is that the plugin loads its own slimmed down version of the Genericons icon font for WordPress versions lower than 4.3. Before that version, the Dashicons font only included the open eye icon, not the crossed out one.
I think you are missing the icon because the Dashicons font is not loaded on the page the login form is on.
The plugin currently does not explicitly add Dashicons as a dependency (although it probably should have) because it is already included on the default WordPress login page.
In stead of adding Dashicons as a dependency though, it may be more optimal to enqueue the ‘genericons’ version of the css on pages where the Dashicons font is not already included, as that will probably add less overhead.
I’ll see if I can make the plugin a bit more extensible, so it’ll be easier to use on other screens as well.
Forum: Plugins
In reply to: [hideShowPassword] Not workingHi kabbill. I’m unsure what you are referring to with front end registration and login pages. Does the theme provide these?
This plugin only adds the password visibility toggle to the ‘default’ WordPress admin login screen. (For example:
https://example.com/wp-login.php
).Thanks for the plugin update!
A quick and dirty fix for future reference:
add_action( 'admin_enqueue_scripts', 'prefix_de_and_re_enqueue_default_media_uploader_view_script', 1 ); function prefix_de_and_re_enqueue_default_media_uploader_view_script() { wp_dequeue_script( 'default-media-uploader-view' ); add_action( 'wp_enqueue_media', array( 'DefaultMediaUploaderView', 'admin_enqueue_scripts', ) ); }
- This reply was modified 7 years, 8 months ago by Barry Ceelen.
- This reply was modified 7 years, 8 months ago by Barry Ceelen.
Forum: Reviews
In reply to: [Default Admin Color Scheme] not always workHi eeeMan, thank you for your feedback.
The default behaviour of the Admin Color Scheme functionality in WordPress is to only apply the color scheme to the admin. When viewing the site the toolbar is always black. This plugin does not change that behaviour.
(There is an Admin Bar Color plugin which applies the color scheme on the front end as well. I haven’t tested if it is compatible with the Default Admin Color Scheme plugin but it might just work.)
Forum: Plugins
In reply to: [Default Admin Color Scheme] LocalizationHi Natali_Z,
Sorry for the late reply!
The plugin was not loading the translation files correctly.
I’ve updated the plugin, should work now.On a side note:
It is best to save your own translations in a ‘translations’ directory in your ‘wp-content’ folder, so they don’t get deleted when a plugin is updated. For example:
/wp-content/translations/plugins/default-admin-color-scheme-ru_RU.mo
I’d be more than happy to include your translation files in the plugin though.
Forum: Plugins
In reply to: [hideShowPassword] Add text next to "Password" labelI’ve updated the plugin with the option of showing a checkbox below the form in stead of the icon inside the password field. This might be helpful if the function of the icon is not obvious enough to the user.