blindmikey

We do understand.

1. Automattic has filed no lawsuit against WPEngine for supposed trademark violation, meaning this is a personal spat that’s intentionally negatively effecting the community.

2. WPEngine is now in the unique position of being one of the few WordPress Hosting Platforms that hosts there own mirror of the .org repository. Meaning they’re one of the few who are immune from Automattic’s supply chain attacks. This benefits WPEngine, not Automattic.

3. Point me to where in the GPL license it says code cannot be used commercially. Your argument is laughable. The GNU General Public License (GPL) explicitly allows for commercial use, including selling software based on GPL-licensed code.

The only thing Amateur here is the gaslighting.

@kellex this would only resolve the issue if your theme’s templates were set to be fetched from a subdirectory of your theme, and your theme was manually updating the “stylesheet” wp_option with update_option().

With that said, I added this to functions.php

Roger that, just trying to help.

It’s not a commercial theme, and I am the developer. The fix outlined above is what I wrote to mitigate the issue introduced in 6.4.2, sharing in hopes that it might help others.

@t-p custom theme. Issue is that the theme was setting the wp_option “stylesheet”, but it no longer has any effect since 6.4.2. So any 3rd party theme that was relying on update_option( ‘stylesheet’, … ) will have issues.

This was done in our custom theme to store templates in a subdirectory in our theme ( {theme_dir}/templates )

I’ve identified the following solution via a filter:

function wp642_fix_custom_stylesheet_directory( $stylesheet_dir, $stylesheet, $theme_root )
{
    // Define templates subdirectory
    $subdirectory = 'templates';

    if ( basename( $stylesheet_dir ) === $subdirectory )
    { return $stylesheet_dir; }

    // Return the new directory path.
    return $stylesheet_dir .'/'. $subdirectory;
}

add_filter( 'stylesheet_directory', 'wp642_fix_custom_stylesheet_directory', 10, 3 );

Again, this is only a solution that pertains to our theme, but could help others if they’re in a similar boat.

• This reply was modified 1 year, 3 months ago by blindmikey.

I’ve identified the issue.
This problem, for me at least, arrises due to the changes in /wp-includes/theme.php, specifically the changes to get_stylesheet_directory() and get_templates_directory(), seen here:
https://core.trac.www.ads-software.com/changeset/57156

By reverting the changes to just these two functions the issue is temporarily resolved. I’m now looking into what theme changes are necessary to sustain a more permeant fix tailored to the new changes to wordpress core code. An unfortunate necessity as I don’t see this being patched to accomodate themes that set their templates in a specified subdirectory within their theme by updating the option “stylesheet” and “template”.

Also prevented messaging by patching the method _display_eligible_deal_notices() in advanced-coupons-for-woocommerce-free/Models/BOGO/Frontend.php

I added this to the codeshare as well.

Best,
-M

I spoke too soon – I thought the site was on 7.3 – but was on 7.2.

Looks like the plugin author has *just* patched this.

Just saw the your note eskapism – thank you for the patch. It’s much appreciated.

That it’s been 8 hours with this bug not patched is alarming. I’ve disabled this plugin on all client sites.

Parse error: syntax error, unexpected ‘)’ in /home/curagohealth/public_html/app/plugins/simple-history/loggers/SimpleLogger.php on line 627

This just brought down my client’s site that’s running on 7.3

Issue is the encoding for the file is UTF-8 with BOM.

Solution is to re-encode the file as UTF-8 (without BOM).

More here:
https://stackoverflow.com/questions/2223882/whats-the-difference-between-utf-8-and-utf-8-without-bom

Issue is that extra BOM data does not play nice with PHP.

Cannot view previous version 4.0.7 as it wasn’t tagged and available in SVN…

Confirmed. Client just responded with this error when trying to login to wordpress.