Byron

Haha my (really hackish) fix was to modify the wp core/override the [caption] shortcode entirely. Was the [caption] shortcode new in 3.5?

@piantadosi: that should work fine. The code that was posted to put in your functions.php just intercepts the shortcodes and prevents them from displaying. If you remove that from your functions.php file and install the patched media-credit plugin (and your site has the same user IDs as before), it should work (assuming the patch works on your site).

Lester responded to all the forum links I posted and I did some more testing on my 3.6 staging site and it seems to work fine. (Those posts looked like other plugins/themes breaking WP-Polls with 3.6.)

So @chrigel it looks like everything is good to go with 3.6 as long as your theme and other plugins are ready.

And @lester: thanks for all the work you put into these plugins!

Probably not. The author developed 19 other plugins, is probably doing this for free, and probably also has a real job.

I need this plugin to work with 3.6 so I’ll take a look at why it’s incompatible next week and try to publish a patch. I have 2-3 plugins on my list where the developer hasn’t updated for 3.6 yet so I don’t know when I’ll have a chance to get to this.

Looks like this is a no…

• https://www.ads-software.com/support/topic/problem-with-poll-archive-page?replies=5
• https://www.ads-software.com/support/topic/is-not-working-after-uprgrade?replies=1
• https://www.ads-software.com/support/topic/upgrading-to-wp-36-wp-polls-causing-problems-need-to-uninstall-from-database?replies=1

Last change in Trac is 7 weeks ago so I doubt this has been fixed since. Anyone done any more rigorous testing to see why it’s not working?

It’s great to have you back, Scott! My fork was a really quick fix — I had about 2 days to get it working and to launch a site on WP 3.5 so it’s fine if we don’t use what I did. (For instance, I couldn’t get the double tag system to work quickly so I just gave up and switched to single tag.)

I’ve been using my fork of the plugin since January and (I know we’re need to tackle WP 3.6 compatibility first) my biggest annoyance is the dropdown/autocomplete menu rarely actually works/sticks (and is visually a little confusing).

Also IIRC WP 3.5+ wants plugin devs to use new hooks to interface with the new media dialog but my fork just hacks the old ones until they work.

Well shoot. I guess I should be trying it on the nightly builds. Thanks for pointing this out!

I won’t be able to work on this for a week or two so if either of us is working on it let’s make sure everyone knows. (Feel free to fork/pull request my repo.)

Right now WP >=3.5 support is pretty hacked (it’s not way WP wants us to deal with the new media dialog) so it sounds like part of it might just need a re-write so it won’t cause issues down the line. (Plus I think this plugin should have a better autocomplete form — the current one doesn’t play nicely with the media dialog — and guest author support to work with co-authors plus.)

Also I had never worked with TinyMCE when I was making my version of the plugin so I had it just display the shortcode (instead of the credit) in TinyMCE. (I was on a really tight deadline.)

Do you know of any way to fix the closing shortcode tag? (Or did you just manually remove it?) The only reason I changed to a single tag is because of that (I didn’t want to make my users remove it every time).

The plugin never worked out of the box for me because WP doesn’t parse shortcodes in the caption. I fixed that, fixed a few issues with the javascript, and fixed its interaction with WordPress’ AJAX save function. It’s just a lot of little details that didn’t quite work right.

I didn’t know Scott had made an updated one himself, so I posted this here in case anyone else wanted one that works now.

I know this is an old thread, but try turning off PHP warnings (either in your php.ini or put error_reporting(0); at the top of your wp-content/plugins/dm-albums/php/image.php file).

I think this is the same issue I’m experiencing so I’m submitting a patch to the developer.

EDIT: Since I can’t find a way to contact the developer and the Dutch Monkey main site is down, I’ll put the patch here and try contacting the developer later.

Okay I spent a few hours getting this to work on my site. WordPress parses out part of the shortcode and it ends up disappearing into neverland, leaving the closing tag ([/media-credit]) in the caption. If we move the shortcode to not get parsed out, however, wordpress does not call the shortcode at all. Both of those issues are fixed below.

I’ve spent too long looking at this to come up with a solution entirely within the plugin. However, if you need it to work on your site (like I did), you can do the following:

1. In wp-content/plugins/media-credit/media-credit.php, replace line 262 (starts with $shcode = with
   $shcode = $html . '[media-credit ' . $credit . ' align="align' . $align . '" width="' . $width . '"]';
2. In wp-includes/media.php, replace line 761 (starts with . do_shortcode( $content )) with
   . do_shortcode( $content ) . '<p class="wp-caption-text">' . do_shortcode( $caption ) . '</p></div>';

Keep in mind that the second search/replace is part of the WP core and violates good plugin practice. (In fact, these changes can’t be made into the plugin itself and have to be performed manually.)

I’m sure there’s a better fix but I can’t think of it.