brucelawson
Forum Replies Created
-
Forum: Plugins
In reply to: [MC4WP: Mailchimp for WordPress] Small change for accessibilityThanks Harish.
I’m delighted to hear “We do want to make our plugin as accessible as possible”/
My proposal adds not 1 byte to the plugin’s payload, but merely changes the nesting of the default. Anyone able to update the code now would be easily able to update my suggested change, because it’s the same code.
Forum: Plugins
In reply to: [Simple YouTube Responsive] Consider tweaking to lazyload videosThanks. However, I’m not seeing the srcdoc attribute, which is what makes the lazyloading work – I’m seeing divs with lots of data- attributes…
Forum: Plugins
In reply to: [Simple YouTube Responsive] Consider tweaking to lazyload videosLooking at the code, seems like it’s some pretty simple changes to this line
return ‘<div class=”dad-youtube-responsive’.$classing.'” ‘.$iding.’ ‘.$css.’><div style=”position:relative;width:100%;height:0;display:block;clear:both;’.$cssRatio.'”><iframe src=”https://www.youtube.com/embed/’.$youtubeID.’?rel=0″ frameborder=”0″ allowfullscreen=”” style=”position:absolute;top:0;left:0;width:100%;height:100%;”></iframe></div></div>’;
use an iframe like this (I haven’t closed the quotes properly around the &youtubeID variable)
<iframe
src=”https://www.youtube.com/embed/.$youtubeID.”
srcdoc=”<style>*{padding:0;margin:0;overflow:hidden}html,body{height:100%}img,span{position:absolute;width:100%;top:0;bottom:0;margin:auto}span{height:1.5em;text-align:center;font:48px/1.5 sans-serif;color:white;text-shadow:0 0 0.5em black}</style><span>?</span>”
frameborder=”0″
allow=”accelerometer; autoplay; encrypted-media; gyroscope; picture-in-picture”
allowfullscreen
”
></iframe>Forum: Plugins
In reply to: [Make Paths Relative] Preserve absolute links in RSS feed@sasiddiqui – you didn’t disturb me at all! Thank you for being so responsive!
Forum: Plugins
In reply to: [Make Paths Relative] Preserve absolute links in RSS feedHello @sasiddiqui – yes, it’s fixed thank you! (Sorry, it was a public holiday in UK so I unchained myself from the computer).
Forum: Plugins
In reply to: [Make Paths Relative] Preserve absolute links in RSS feedHi @sasiddiqui, thank you for being so responsive.
Previously my feed’s link tags had only relative links – now they are empty! ( https://www.brucelawson.co.uk/feed/ is the feed’s URL in case the markup below gets eaten by the comment process)
<item>
<title>Structured data and Google</title>
<link></link>
<comments>#comments</comments>
<pubDate>Tue, 21 May 2019 11:56:28 +0000</pubDate>