cameronbq

Thank you,

the warnings are still the same – both in beta3 and the released version of 3.1.7.

At least I can now reactivate ppf on my main site, as it no longer crashes.

I also disabled synchronising hpos data back to posts and the warning remains the same, even for a newly created order. So, it looks like it might be safe to ignore it for a while, but I expect it might cause issues some time in the future.

Hi,

I’ve tried beta2, with mixed results.

1. the system no longer crashes on the woocommerces pages, and still works as expected on the pages where we do need it.
2. It generates a “doing it wrong” warning in the debug log file. See below …

PHP Notice: Function id was called incorrectly. Order properties should not be accessed directly.
Backtrace: do_action(‘load-woocommerce_page_wc-orders’),
WP_Hook->do_action,
WP_Hook->apply_filters,
Automattic\WooCommerce\Internal\Admin\Orders\PageController->__call,
call_user_func_array,
Automattic\WooCommerce\Internal\Admin\Orders\PageController->handle_load_page_action,
Automattic\WooCommerce\Internal\Admin\Orders\PageController->setup_action_edit_order,
Automattic\WooCommerce\Internal\Admin\Orders\PageController->prepare_order_edit_form,
Automattic\WooCommerce\Internal\Admin\Orders\Edit->setup,
do_action(‘add_meta_boxes’),
WP_Hook->do_action,
WP_Hook->apply_filters,
PublishPress\Future\Modules\Expirator\Controllers\ClassicEditorController->registerClassicEditorMetabox,
PublishPress\Future\Modules\Expirator\Controllers\ClassicEditorController->isGutenbergAvailableForThePost,
WC_Abstract_Legacy_Order->__get,
wc_doing_it_wrong
Please see Debugging in WordPress for more informat in /…/wp-includes/functions.php on line 6031

And yes, the system really does generate an anchor with no href for “Debugging in WordPress”. I guess that’s a woocommerce bug.

It crashes on both the Orders and Subscriptions pages, but nothing else I can find. It seems clear that, with HPOS, orders are now instances of WC_Order rather than posts, while the offending line is calling ClassicEditorController::isGutenbergAvailableForThePost() with what is named $post but in this case is not.

I don’t understand enough of the intricacies of this to offer the appropriate solution.

Thanks Steve, but no change – the error is just the same as before.

As a bit more detail, when I check “post types” settings the “Activate PublishPress Future metabox for this post type” setting is disabled for everything except one custom type, which is “activities”.

It is specifically off for orders and subscriptions.

Same for me when I go to edit order page.

Looks like 2.2.1 broke HPOS.

I was running with HPOS enabled, on staging site as well as main site. Switched back to old-style and it works as expected.