cfddirect

How do you share a screenshot here?

The issue was resolved by the events made easy developer.

Tested 1.8.8 on Firefox, Android, Opera and the maps load effectively. The loading time seems noticeably faster than before. Many, many, thanks. Great job.

Hi Franky (@liedekef)

I had a look into this further. With 1.8.7, I am actually finding that map loading is random in Firefox. Sometimes they load, sometimes they don’t – roughly 50%:50%.

I ran Web Developer -> Inspector and noticed it was giving a reference error:
“Reference Error: google is not defined”

I googled this and it seems this is caused by the “maps.google.com/maps/api/js…” not being loaded before the file that uses it:
https://stackoverflow.com/questions/33495879/uncaught-referenceerror-google-is-not-defined-at-google-maps-marker
(In this case the file using it is eme_location_map.js)

The file is not loaded is because the loading uses the async flag. I deleted the async and defer flags on line 3694 of eme_events.php in the eme_general_footer()
function as follows:
echo “<script type=’text/javascript’ src=’//maps.google.com/maps/api/js?”.$gmap_api_key.”‘></script>\n”;

The maps now load 100% of the time in Firefox.

See for example:
https://cfd.direct/openfoam-training/munich/
https://cfd.direct/openfoam-training/chicago/
https://cfd.direct/openfoam-training/london/

I appreciate that we want ideally to load the google/js file asynchronously, but I don’t know if it is possible to pause loading the eme_location_map.js file until the google/js file is loaded.

I note the same code is in the eme_general_head() function also

By the way, is there a reason for not using coding style
… async>
rather than
… async=”async”>

Thanks,

Chris

Hi Franky,

I think I am seeing the same issue as reported in this thread. For info:
– on the public side, each map is OK in 1.8.4, but a green block in 1.8.5-1.8.7
– it is not a browser cache issue because I get the same when I change browsers and devices
– the maps on the backend/private side, ie. location page, is fine (at least in 1.8.7)
– an example page is: https://cfd.direct/openfoam-training/london – where I have reverted to 1.8.4.

Catching up on this thread, do you suggest trying 1.8.7 with the following patch?:
https://plugins.trac.www.ads-software.com/changeset/1676777/

Let me know, and I will test and report back.

Thanks,

Chris