codejp3

5.1.7 is the last version that actually applies forum styles.

I’m specifically referring to the styles set in the tabs for:
Forum Index Styling
Topic Index Styling
Topic/Reply Display

Maybe more, but those are the core ones.

I reverted back to 5.1.8 first. Styles not applied, Hitting the “save” button on those tabs has no effect.

Reverted back to 5.1.7. Styles not applied. Hitting the “save” button on those tabs works and reapplies styles to the frontend.

Tried to update to 5.1.8 again. Styles not applied, hitting the “save” button on those tabs has no effect.

Tried to update to 5.1.9 again. Styles not applied, hitting the “save” button on those tabs has no effect.

Only 5.1.7 is the last version applying styles for me, and I have to hit the “save” button on those tabs for the values to actually be applied.

Without digging into code, it seems something changed with how values are saved/fetched from the DB.

replying to mark as resolved…

Now I noticed that when viewing the forum index that has the “mark as read” button to the left and search form to the right, the “mark as read” button has 7px cut off from the top.

Fixed one problem, but caused another. ??

To isolate just the -7px offset on single forum pages, but display as normal on the forum index page, I got a little more specific with the targeted CSS selector:

/* only when the "mark as read" button is used in-line with other buttons */
div.bsp-center > form > input.bsp_button1 {
	margin-top: -7px;	
}

The button displays properly by itself, and perfectly in-line with all other buttons everywhere it’s used.

Problem(s) solved…..but that makes it even less user-friendly for personal customization. Hmmm, haven’t come up with a solid solution for this yet. I’ll keep thinking about it and get back to you if I come up with something.

One more follow-up. The “Mark All Topics As Read” button is slightly different than the others. Probably because it’s a built-in form.

I played around 1, 2, 3, and 4 buttons, and with the order for the buttons, and that’s when it becomes obvious. “Mark All Topics As Read” is slightly offset vertically from the others.

Compensating for the padding set in the .bsp_button1 class, an equal negative offset for just the “Mark All Topics As Read” form input button makes them all align perfectly:

input.bsp_button1 {
	margin-top: -7px;	
}

I THINK that’s it related to the top buttons and alignments. They’re all aligned perfectly, regardless of how many buttons and which order.

Problem is, this isn’t very customizable for end-users. If someone changes the top or bottom padding size of .bsp_button1 (or their own custom class), then the input button for “Mark All Topics As Read” has to be handled separately with an equal negative top margin comparable to the padding of the rest. Just something to think about.

Oh, I’ll also add, that I made a few CSS changes. Couldn’t get them to look aligned properly with unequal width % and margin-right.

Instead I set

/* bsp-one-half */
margin-right: 0;
width: 50%;

/* bsp-one-third */
margin-right: 0;
width: 33.33%;

Looks proper on my end now.

replying to mark as resolved…

replying to mark as resolved…

Just replying to mark as resolved…

replying to mark as resolved

replying to mark as resolved….

Just replying so that I can mark the topic as resolved…

Just replying so I can mark as resolved..

Thanks for the reply and link to the codesnippets cloud!

Between our posts, there’s 3 variations of disabling the TinyMCE buttons:

1. Only in bbPress
2. Site-wide
3. Only in admin panel

I could think of plenty more conditions to enable/disable it as well. No way to cover every scenario and justifies NEVER making it a built-in dedicated plugin setting and keeping it an optional code snippet.

Thanks again!

Just replying so that I can mark this as resolved.

Well, answered my own question.

Made this little snippet, and even kept BBPress context so it’s only disabled in the front end forum.

add_filter( 'mce_buttons', 'codejp3_remove_code_snippets_button', 99 );
function codejp3_remove_code_snippets_button( $buttons ) {
	if ( is_bbpress() ) {
		$buttons = array_diff($buttons, ["code_snippets"]);
		return $buttons;
	}
}

I think adding a setting for this within the plugin is overkill, especially if you factor in context (like only on BBPress)…. BUT perhaps something like this should be a default sample snippet that ships with Code Snippets? Something like:

add_filter( 'mce_buttons', function ( $buttons ) {
	$buttons = array_diff($buttons, ["code_snippets"]);
	return $buttons;
});