Forum Replies Created

Viewing 3 replies - 406 through 408 (of 408 total)
  • Thread Starter codejp3

    (@codejp3)

    Looking at the code within the plugin, I don’t think what I want to achieve is possible as-is.

    I’ll be modifying it to include an option to “save/serve Google font files locally” instead of always/only linking to Google for them, and then to include the URL (if “served remotely” option selected) or local file path (if “saved/served locally” option selected) as part of the values array returned by the shortcode and get_ and the_ functions.

    THEN I can grab all the info I need to be able to include the proper CSS code to make font styling set with this plugin within my PDF generation.

    It’s not just for my purposes. I can see a handful of scenarios where some people would want resources used being saved and served locally, and where having either the URL or file path to those resources being helpful when custom coding non-standard, non-wordpressy things.

    I’ll submit another pull request on GitHub once I’m done.

    • This reply was modified 2 years, 5 months ago by codejp3. Reason: few typos
    Thread Starter codejp3

    (@codejp3)

    Just submitted a pull request on Github for this.

    I’ve tested this plugin with PHP 8.0, 8.1, and 8.2

    Using a fresh install WP 6.0.2 site with only ACF Pro 5.12.3, ACF Tyopography 3.2.3, and DebugPress 2.0, and adding a Field Group with ALL ACF Typography Fields on the default “Post” post type and creating/editing test post entries – these are the results I get:

    8.0 – no errors at all (previously got a ton WP Core errors but they have since been patched)

    8.1 – These errors appear site-wide front-end and back-end, with multiple occurrences of each.

    setcookie(): Passing null to parameter #5 ($domain) of type string is deprecated ( /wp-includes/option.php )

    rtrim(): Passing null to parameter #1 ($string) of type string is deprecated ( /wp-includes/formatting.php )

    This error only occurs on the front-end when viewing a created post.

    wp-includes/functions.php is deprecated since version 3.0.0.

    8.2 – same as 8.1

    Results –

    • ZERO fatal errors, like you’re describing.
    • The 3 repeating errors are only deprecated messages (not errors), and remain even with ACF Pro and ACF Typography disabled.

    Conclusion –
    ACF Typography is working fine with PHP 8.0, 8.1, & 8.2

    If there’s something specific you’re trying to do when you encounter fatal errors, let me know and I’ll try it on my test site. There’s likely a conflicting plugin of some sort, but it doesn’t appear to be ACF Typography.

    • This reply was modified 2 years, 5 months ago by codejp3.
    • This reply was modified 2 years, 5 months ago by codejp3. Reason: spacing for easier reading
Viewing 3 replies - 406 through 408 (of 408 total)