codewisenicolas

We have some front end code that pulls in post data via ajax from a content type that has ACF fields. Specifically the rest v2 json functionality that’s part of WP and extended by ACF.

The front end code was designed for ‘simple_value_formated’. As you can imagine, once that field name changed it stopped the front end from being able to load the content of the post.

Thank you for the code, however please be aware that a breaking change is a big deal. Plugins update automatically in some installations, this change can surprise many users that are not technical and don’t know what happened or how to fix it. Its not even listed in your changelog (only that the code was refactored)

Normally breaking changes should happen with a much bigger notice and usually reserved for major version changes. If possible, include a deprecation fix so that websites dont break with the update and people have time to migrate to the new way.
For example, by including your code fix into your plugin would prevent sites from breaking but give people time to update their code.

I would suggest putting out a 1.7.1 that includes your temp fix to prevent sites from breaking, and a much bigger notice in the changelog or plugin info so people are aware that in a later version this will change.

Thank you for the plugin and your work. I appreciate it and hope that you continue improving it.

Thanks for responding so quickly.

Problem 1 has been very hard to track down and reproduce as its seemingly random. A user will edit a page but the notification will instead show a different user as the person who made the edit.

I have looked thru the plugin code and the only situation I could figure is that somehow the post edit lock (_edit_lock) meta must not be getting updated and when the plugin tries to grab the editor it uses the meta value and thus it shows the wrong user in the notification email; however this is an assumption/best guess not an actual diagnosis.

We also tried the [user_***] shortcodes as listed here https://betternotificationsforwp.com/documentation/notifications/shortcodes/?notification=update-post because it says “These multi-purpose shortcodes relate to the person triggering the notification” however we found those shortcodes are not related to who triggered the notification for post/page updates; I checked the code and confirmed this – its actually the post author.

Would it be possible to request a new shortcode that is directly connected to the wp_get_current_user() function ?
I think this would quickly resolve our issue with actions on posts/pages.

Again thanks for responding and looking into it.