Corey Worrell

Where is it adding target=”0″? The field is saved in the database as either a “0” (same window/tab) or “1” (new window/tab), and it is the developers responsibility to use that how they see fit. For example:

<?php
$link = get_field('link');
$target = $link['target'] ? ' target="_blank"' : '';
$a = sprintf('<a href="%s"%s>Link</a>', $link['url'], $target);

Thank you. I’ve realized that my plugin was not correctly detecting if the link dialog scripts had already been loaded or not and was then loading them twice if there was already an editor on the page.

Please install this patched version and let me know if it fixes the issue. If all is good then I can release a new version right away.

Patch: https://emrl.mx/acf-link-1.1.2-patch.zip

Can you two please let me know exactly what versions you are using of each of the following:

WP version
ACF PRO version
ACF Link version

As well as your exact browser and version.

I cannot reproduce with the following:

WP 4.5.3 (alpha)
ACF PRO 5.3.8.1
ACF Link 1.1.2
Firefox 45.0.1 and Chrome 52.0.2743.10 dev

Thank you.

Very weird. But no it should work no matter where you include it. What browser are you using? Are there any JavaScript errors if you open the browser console?

What version of ACF Link and WP are you using? I cannot reproduce this. It could be another plugin interfering?

@metaglyphics

Could you please be more specific as to what you are trying to do and what is happening?

Thank you.

You can manually replace the short array syntax brackets with the old syntax.

ie:

$this->defaults = array(
    'show_fields' => array('title', 'target'),
);

@revxx14,
This plugin requires PHP version >= 5.4. It looks like the server could be using an older (no longer supported) version.

I never actually tested on other areas that ACF can be used, so thanks for pointing this out, looks like there are a couple other places that will need fixes as well.

Thanks for the information revxx14. I’ve released an update that should fix that!

Hi WFMattR,

What is weird is that another site on our server did not have any problems here. So I’m not sure what is going on.

Here is ls -l wp-content

drwxrwxr-x+ 13 corey users 4096 Apr 14 15:32 plugins
drwxrwxr-x+  5 corey users  100 Mar 15 13:24 mu-plugins
drwxrwxr-x+  3 corey users   24 Mar 15 13:24 themes
drwxrwxr-x+  2 corey users    6 Apr 14 15:32 upgrade
drwxrwxr-x+  3 corey users   34 Mar 15 13:26 uploads
drwxrwxr-x+  2 corey users  112 Apr 13 14:55 wflogs

And getfacl wp-content/wflogs

# file: wflogs
# owner: corey
# group: users
user::rwx
user:apache:rwx
group::r-x
group:users:rwx
mask::rwx
other::r-x
default:user::rwx
default:user:apache:rwx
default:group::r-x
default:group:users:rwx
default:mask::rwx
default:other::r-x

Apache running as apache user of course. Core/plugin/theme updates and media uploads all work, and WF was able to put the files like I said into the wflogs directory, so I can’t see why it thinks it can’t write when accessing /wp-admin/admin.php?page=WordfenceWAF&wafAction=configureAutoPrepend

Thank you!

Oh I see. Thank you!

Marcelo, how do you have markdown setup to be used with SiteOrigin Page Builder? I just installed Jetpack and enabled markdown but am not seeing it work correctly out of the box.

Thank you!

For now you can edit /wordpress-https/lib/WordPressHTTPS/Module/Core.php line 280 and change force_ssl_login to force_ssl_admin and it seems to fix it.

Actually, this does seem like a bug with BILS.

Line 23 of internal-link-manager.js checks if ed is false, but a simple check for a “falsey” value (if (!ed)) handles the case where ed is null as well. And it should return an empty string and not false, as later on the indexOf method is called on the return value of getSelection, which throws an error if it equals false.

So setting line 23-25 as

if ( ! ed) {
    return '';
}

works correctly.