csskevin
Forum Replies Created
-
Forum: Plugins
In reply to: [WP Lightbox 2] 5.6 compatible?We are currently investigating, that the plugin is compatible with the new version, and also do some bug fixes.
We will let you know, if the new version is released.Forum: Plugins
In reply to: [WP Lightbox 2] Bug in WordPress 5.5 – Solution providedHey,
To apply the latest bug (version 3.0.6.3) the easiest way is to replace the
js/dist/wp-lightbox-2.min.js
with the latest commit on the github repo: Here is the raw file: https://raw.githubusercontent.com/awesomemotive/wp-lightbox-2/master/js/dist/wp-lightbox-2.min.js
Just replace the file content with it from githubTo apply the bug of version 3.0.6.2 and below all you need to do is, replace the snippet code
if(parseFloat($().jquery) >= 1.7){ return $(this).on("click", onClick); } else { return $(this).live("click", onClick); //deprecated since 1.7 }
in wp-lightbox-2.js as well in wp-lightbox-2.min.js with
var currentJqueryVersion = $().jquery; var splittedJqueryVersion = currentJqueryVersion.split("."); if(splittedJqueryVersion.length >= 2) { var majorVersion = parseInt(splittedJqueryVersion[0]); var minorVersion = parseInt(splittedJqueryVersion[1]); if(majorVersion >= 1 && minorVersion >= 7) { return $(this).on("click", onClick); } else { return $(this).live("click", onClick); //deprecated since 1.7 } } else { throw new Error("jQuery version could not be determined. jQuery version: " + currentJqueryVersion); }
Just an update for the next release: @rcain
The latest commit already contains everything for the release 3.0.6.4. As the review is done, the new version will be pushed to production.
It shouldn’t take too long anymore and the version will be released in the next few days.Forum: Plugins
In reply to: [WP Lightbox 2] Bug in WordPress 5.5 – Solution providedHey @ftlralph
The project is also available under Github: https://github.com/awesomemotive/wp-lightbox-2The bug fix I created is currently under review: https://github.com/awesomemotive/wp-lightbox-2/pull/2
If the pull request has been approved and merged by the team, it will be published on WordPress.
Thanks for your patient,
csskevinForum: Plugins
In reply to: [WP Lightbox 2] Bug in WordPress 5.5 – Solution providedHey,
we are aware of this issue and currently working on it. The issue happens, when you have a select box displayed on your webpage.
We will let you know, when there is a solution for that. It shouldn’t take too long.Forum: Plugins
In reply to: [WP Lightbox 2] Bug in WordPress 5.5 – Solution providedHey,
Just wanted to inform, that there is now a new release (3.6.0.3) for the WP Lightbox 2 plugin.
If there should be any issues, just let me know.Forum: Plugins
In reply to: [WP Lightbox 2] Conflicting plugingsThe problem is caused by the update of wordpress 5
The plugin has a bug regarding to new wordpress version.
There is a solution provided in this topic here: https://www.ads-software.com/support/topic/bug-in-wordpress-5-5/I am currently rewriting the plugin, because it hasn’t been supported for several years now. There should be soon an bugfix for that issue.
Forum: Plugins
In reply to: [WP Lightbox 2] Bug in WordPress 5.5 – Solution providedYou need to do that for the
wp-lightbox-2.js
as well for thewp-lightbox-2.min.js
If it don’t work then, open up the Javascript Console of your browser and check out if there are errors.
Forum: Reviews
In reply to: [WP Lightbox 2] Broke my siteCheck out this article: https://www.ads-software.com/support/topic/bug-in-wordpress-5-5/
Forum: Plugins
In reply to: [WP Lightbox 2] Bug in WordPress 5.5 – Solution providedRight. Especially the
wp-lightbox-2.js
should be rewritten. I would suggest to use a compiler like Babel for browser backwards compatibility.If you need help rewriting this code let me know.