Ryan Williams
Forum Replies Created
-
I don’t think this plugin is affected by the change. I saw notices in my Auth0 logs, disabled the toggle in the settings, and did not have any problem logging in to WordPress using Auth0 before or after the toggle.
Forum: Plugins
In reply to: [WP REST Filter] Why was it taken out in the first place..https://github.com/WP-API/WP-API/issues/2799
https://core.trac.www.ads-software.com/ticket/38378
- This reply was modified 6 years, 6 months ago by Ryan Williams.
Forum: Developing with WordPress
In reply to: wp-cli scaffold plugin-tests does not pass phpcs rulesDisregard, I had an old version of wp-cli.
Forum: Plugins
In reply to: [CommentPress Core] AJAX error!I discovered that disabling the comment group of our Redis object cache makes the comments show up under the correct paragraph and thereby fixes the JS error. Here’s how I did it:
/** * Comments are not nested correctly if caching is on, so disable it for commentpress. */ function hcommons_selectively_disable_object_cache() { $theme = wp_get_theme(); if ( false !== strpos( strtolower( $theme->get( 'Name' ) ), 'commentpress' ) ) { wp_cache_add_non_persistent_groups( array( 'comment' ) ); } } add_action( 'plugins_loaded', 'hcommons_selectively_disable_object_cache' );
- This reply was modified 7 years, 6 months ago by Ryan Williams.
Forum: Plugins
In reply to: [CommentPress Core] AJAX error!We have the same issue in commentpress-core:3.9.3. It happens when the comment being added is the first on its paragraph, because line 958 of cp-ajax-comments.js calls last_id.toString() but last_id is empty due to this being the first comment (see line 945 last_id = $(last).prop(‘id’); ).
The plugin should definitely not alert() this error in any case, but I’m not sure how you want to handle it or I would be happy to submit a PR myself.
You can see it in action at https://cyborguniversity.hcommons.org/.