Primoz Cigler

@themifyme any update?

Hey @themifyme, any updates? ??

@themifyme great, update would be perfect otherwise I will be forced to fork your plugin and provide fixed version to our theme users.

I have been debugging the problem now and proposed a solution to the plugin authors here: https://www.ads-software.com/support/topic/problem-with-pagination-26/#post-12719312

By the way, excellent plugin, but please update this urgently because the latest update broke the functionality for pretty much everyone using it.

Thank you!

Hey @themifyme,

Many our customers are reporting the same problem.

The bug was introduced with the very recent update of the plugin from 1.2.5 to 1.2.6. In file public/js/wpf-public.js around line 170 you have replaced $container.html(resp); which correctly included the pagination links with the following code:

products = $( resp ).find( '.product' );
var $productsContainer = $container.hasClass( 'products' ) ? $container : $( '.products', $container );
$productsContainer.empty().append( products );

which replaces only the products, but not pagination and product count above the products. The problem can also be seen on https://bravenew.hekko24.pl/inutri/shop-test/ if you select category with only a few products – you will see that the pagination and product count is not updated. Screenshot of the problem.

It is apparent to me that you made that change in the code to support Divi and Elementor, but broke the functionality of the regular WooCommerce users.

Proposed solution: revert to the previous behavior and do the extra check for the Elementor/Divi containers if these plugin need different handling. Moreover, in this line $.event.trigger('wpf_ajax_success'); around line 206 please add the response data with the custom trigger, like so $.event.trigger('wpf_ajax_success', { response: resp }); so the theme authors can get the rest of the data in the response and do further DOM changes and enhancements..

It’s OK, I don’t need a solution right now.

@hibitco you are right, I was using the version 1.2.2. But now, after updating to the latest 1.2.3, I can see there are some changes in that part of the code, but the bug is still present – ordering by price asc or desc still does not give expected results.

What is the reason that you are always setting the menu_order as the first ordering parameter, not respecting the others set in the set_order method?

Thank you for your answer!

Hi @peces,

I see. For the start, I’d recommend that you check the server error logs (if you don’t know where to find them ask your hosting provider) and the log that OCDI generates after each import. It’s a .txt file located in the Media > Library.

You can paste the error logs and the OCDI log file here and I can investigate further.

Hi,

Thanks!
It would be great if you can add it in a form of a pull request on the official github repo.

I’ve expected this. We will try to contact them and explain it’s a bad practice, so they can fix it. However, I cannot promise they will act upon it.

Thank you a lot for your 5-star review! ??

Hey there Bojan,

Yes, please do. Even if he cannot get the same notices, he should still implement these changes as validating your data is a good practice and definitely cannot do any harm.

Hi,

Will this be fixed in the next version?

I just want to know everybody that I improved integration of this plugin in Dining Restaurant theme in release v1.4.0, so now all the strings are in the plugin – essentially one has to translate the plugin, not the theme, except for the BOOK NOW button.

Hi,

It seems like one of the free WP themes in the repository is clashing with our Dining Restaurant theme.
I will see what’s the best workaround in the next days. Please don’t update.