Damian_AU

@zipmoney,

Thanks for the reply. Unfortunately this has not been changed, even after 6 iterations from the version use that I reported on. I have to keep changing the code after updating the plugin. This is NOT ideal.

This is such an easy thing to change – simply add a priority value to the add_action() function hook. Please.

File: /zipmoney-payments-woocommerce/includes/class-wc-zipmoney-payment-gateway-widget.php

In the _add_tagline_hook() function:

Change:

if($WC_Zipmoney_Payment_Gateway_Config->get_bool_config_by_key(WC_Zipmoney_Payment_Gateway_Config::CONFIG_DISPLAY_TAGLINE_PRODUCT_PAGE)){
            add_action('woocommerce_single_product_summary', array($this, 'render_tagline'));
}

To something like:

if($WC_Zipmoney_Payment_Gateway_Config->get_bool_config_by_key(WC_Zipmoney_Payment_Gateway_Config::CONFIG_DISPLAY_TAGLINE_PRODUCT_PAGE)){
            add_action('woocommerce_single_product_summary', array($this, 'render_tagline'), 28);
}

Where the ‘priority’ is just below the woocommerce_template_single_add_to_cart hook. This will place the Tagline just above the Add to Cart button.

• This reply was modified 6 years, 8 months ago by Damian_AU.
• This reply was modified 6 years, 8 months ago by Damian_AU.
• This reply was modified 6 years, 8 months ago by Damian_AU.

Email File Change Notifications still not working when Email Lockout Notifications is disabled, as at v5.1.0.

Perhaps I shouldn’t have marked this topic as ‘resolved’ as it clearly hasn’t been, hence I have changed back to ‘not resolved’.

I find it extremely frustrating that unless someone purchases something from iThemes, there seems to be no way of contacting their support team.

@dwinden

Great job on all your testing, and finding a more simple solution. Given my solution was working I was content with leaving it until the plugin developers fix it, as I simply didn’t have the time to continue troubleshooting.

Given the developers have yet to fix the code I was reluctant to mark this topic as ‘resolved’. However if it helps people find a solution to the problem, I’m happy to do so.

Thanks again for all your help, and good luck with finding your new job.

@dwinden

Yes, I have tested this over multiple sites.

Isn’t this (also) going to send Lockout notification emails when the Email Lockout Notifications setting is disabled and the Email File Change Notifications setting is enabled ?

Not that I can see, unless I’m missing something. The notify() function is triggered by both send_lockout_email() (Lockout Notification Function) and send_notification_email() (File Change Notification Function).

For lockout notifications, lockout() triggers send_lockout_email() (only if email_notifications is true) which then triggers notify(), which also checks if email_notifications is true.

For FCD notifications, execute_file_check() triggers send_notification_email() (only if email is true) which then triggers notify(), which also checks if email is true.

So notify() function will only send Email Lockout Notifications if setting enabled; and with my changes, it will also send Email File Change Notifications only if setting is enabled.

@dwinden

Thanks for all your efforts, it’s greatly appreciated.

I have found a more simple solution to the problem, until the plugin is fixed. For anyone experiencing this problem, open: /wp-content/plugins/better-wp-security/core/class-itsec-notify.php and locate notify function around line 198.

After global $itsec_globals;

Add:

$file_change_settings = get_site_option( ‘itsec_file_change’ );

Then locate:

} elseif ( isset( $itsec_globals[‘settings’][’email_notifications’] ) && $itsec_globals[‘settings’][’email_notifications’] === true ) {

Replace with:

} elseif (
isset( $itsec_globals[‘settings’][’email_notifications’] ) && $itsec_globals[‘settings’][’email_notifications’] === true ||
isset( $file_change_settings[’email’] ) && $file_change_settings[’email’] === true
) {

Save file.

File change email notifications should now work.

NOTE: As @dwinden mentioned, any future updates of iThemes Security plugin will overwrite this fix. Hopefully iTSec devs fix this issue before next update.

It appears that this issue was introduced in Oct 2014 to fix issues with the plugin sending out notification emails when it shouldn’t.

See link for reference: iThemes Security Plugin GitHub Commit

Thanks @dwinden, I will try that and let you know if it works.

Yep, I have come to the same conclusion. I hope iThemes Security devs monitor this forum.

Seems strange to require the Email Lockout Notification for FCD email notifications. I normally have this disabled so I don’t get swamped by lockout email notifications.

The ‘problematic sites’ all have Email Lockout Notification disabled; the ‘working’ sites have it enabled. So this is definitely the problem.

I recently updated settings on all my sites and would have disabled Email Lockout Notification if I saw it was enabled. Which explains why FCD emails recently stopped.

Thanks for confirming the issue with Email Lockout Notification.

Yes, Email Lockout Notifications is disabled.

Thanks for the assistance @dwinden.

Here is the output:

************************* $send_email: 1
************************* $scheduled_call: 1
************************* $this->settings['email']: 1
************************* $files_added_count: 0
************************* $files_changed_count: 2
************************* $files_deleted_count: 0
************************* Digest email: 0
************************* Lockouts email:
************************* Sending FCD email ...
************************* Sending FCD email succeeded.

So it appears to be calling send_notification_email() function, though I don’t see how we can consider the email as ‘sent’. I tried this on my local test environment and on external host. I watched the mail logs on my local test env and I there is no email generated by the plugin.

Thanks for doing the test. Good to know that combo works.

I agree, it’s most likely an env issue, but as to what it is, I’m not sure.

I would love a debug feature. I found reference to it in the code (though I think it was in code for notify), however I don’t see any option for it. I tried setting “define(‘ITSEC_DEBUG’, true);” in wp-config.php, but it made no difference.

I’m up for the challenge! What do I need to do?

Nothing in error_log.

@dwinden, are you a iThemes Security dev?

@dwinden

Thanks for responding.

Good to know about the manual FCD scan not sending emails.

Email file change notifications checkbox is enabled, and I have received file change notifications in the past. It’s just recently stopped.

Screenshot: FCD log

When ‘Disable Bootstrap’ is ticked the ‘bootstrap-breadcrumb.css’ is still loading, which is breaking bootstrap themes.

The CSS file ‘boostrap-breadcrumbs.css’ contains the following:

.container {
	max-width: 960px;
	}

This is what breaks bootstrap themes as container width should be 1170px.

For a temporary workaround for this problem, add the following to your theme style sheet.

.container {
	max-width: inherit;
	}