David Steuber
Forum Replies Created
-
Forum: Themes and Templates
In reply to: 2015 child theme breaks wp-admin and reveal buttonThe JavaScript that makes it work is contained in the wp_footer() function which needs to be called from footer.php.
Forum: Themes and Templates
In reply to: 2015 child theme breaks wp-admin and reveal buttonI think things are working.
Forum: Themes and Templates
In reply to: 2015 child theme breaks wp-admin and reveal buttonI added this to my CSS:
/** * 9.0 Clearings */ .site-content { float: right; }
This seems to fix drawing glitches. Hopefully that is the right way to tackle it.
Changes have been committed to GitHub.
Forum: Themes and Templates
In reply to: 2015 child theme breaks wp-admin and reveal buttonAdding the wp_footer() call back worked for getting the admin bar back.
I’m still getting some drawing glitches. The content wants to jump to the left. It’s tricky to describe.
I would never have thought of the wp_footer() thing. I just wanted to remove the colophon thing. Thanks.
I just made this change.
I’m wondering if I need a “float: right” property on the main content class or something.
I haven’t been able to reliably reproduce things.
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesCool! Thanks. Now if I can just get the aspect ratio right ??
Going through the Twenty Fifteen theme’s style.css file for my Child Theme is really making me appreciate the work that goes into these things. I think it would take me at least a year to get caught up and be able to make a theme from scratch.
Making a Child Theme is a bit of work when you are not familiar with the code and modern standards.
One step at a time. I’ve managed to dump the download of the Noto family of fonts. I’m replacing all references to them in my child theme’s CSS. The margins and padding are definitely going to be trickier.
I wonder what the odds are that I will get useful feedback if I put my Child Theme (with the very exciting name of twentyfifteen-child) on GitHub.
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesOK. I think I figured it out. It wasn’t clear that I was supposed to chose one or the other of the add_action() examples. I went with the second. Error gone.
So how do I get an image to show up in the description of the Twenty Fifteen Child under the themes menu? I just get a checkerboard pattern (like no selected layers in photoshop). It would be cool to stick a snapshot of my site in there.
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesI got stuck pretty quickly ??
I followed the instructions on:
https://codex.www.ads-software.com/Child_Themes#How_to_Create_a_Child_ThemeI get the following error when I try to do a live preview of the twentyfifteen-child theme:
Fatal error: Cannot redeclare theme_enqueue_styles() (previously declared in /home/dsteuber/public_html/wp-content/themes/twentyfifteen-child/functions.php:8) in /home/dsteuber/public_html/wp-content/themes/twentyfifteen-child/functions.php on line 19
This is my functions.php
<?php /** * Twenty Fifteen Child */ add_action( 'wp_enqueue_scripts', 'theme_enqueue_styles' ); function theme_enqueue_styles() { wp_enqueue_style( 'parent-style', get_template_directory_uri() . '/style.css' ); } add_action( 'wp_enqueue_scripts', 'theme_enqueue_styles' ); function theme_enqueue_styles() { wp_enqueue_style( 'parent-style', get_template_directory_uri() . '/style.css' ); wp_enqueue_style( 'child-style', get_stylesheet_directory_uri() . '/style.css', array('parent-style') ); } // Custom Function to Include function favicon_link() { echo '<link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />' . "\n"; } add_action( 'wp_head', 'favicon_link' );
At this point, I’m kind of cargo culting my way through. I had hoped the directions I followed would give me a sort of null child theme to start hacking on.
Thanks.
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesOK. Thank you, Andrew.
Just to be positive about all this, I am quite impressed with what WordPress, theme, and plugin authors have managed to accomplish with the LAMP stack. Particularly the PHP part. It takes some serious discipline to write maintainable PHP code from what I hear.
I’ll close this as creating a Child Theme seems to be the answer.
Thanks.
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesThanks, Andrew. I just installed it.
I’ll have to take some time with it. It doesn’t seem to have the original CSS. Also, I seem to have fallen behind the times. I used to hand code CSS1. Things have clearly moved on since then.
What about eliminating the download of Google’s fonts? How would that work?
This is what I see in my Web Inspector (Safari):
https://www.dropbox.com/s/jk8amkws4maubkt/WebInspector.png?dl=0
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesAndrew, I was using the theme editor to edit the virtual style.css file.
My link doesn’t seem to work from here for me. I’ll put the image on dropbox.
https://www.dropbox.com/s/9xczjtrqvw9w2em/WebSiteScreenShot.png?dl=0
Forum: Themes and Templates
In reply to: Twenty Fifteen: Adjusting line spacing, padding, and font sizesHi Sam,
First I want to say I got myself in over my head with editing the theme CSS. I deleted the theme and reinstalled it. I think that restored the CSS to its original. Somehow my other settings survived (plugins, widgets, etc).
Let me show you a full screen render of the site. I don’t see an upload option. So I’ll just link the image.
As you can see, a lot of horizontal space is unused. In the left navigation bar, the text uses too much vertical space. I plan to switch the fonts to “Helvetica Neue”, Helvetica, sans-serif. I’m not a fan of the Noto family. Just a mater of taste.
There is a fair amount of space at the top that is unused.
Essentially what I want is to reduce all that padding / margin space, reduce the line heights in the navigation area, change the fonts, and not fetch the Noto fonts from Google. Is this something I can do with a “child theme”? I’ve seen reference to such things while hunting through the support forums today, but I don’t know what exactly they are. It would be nice to not have to mess with the Twenty Fifteen theme if I can just subclass it or whatever terminology you use to make these changes.
Thanks.