davorg

Hi,

I’ve been looking into this in a bit more detail. It seems the problem isn’t with your code, but with the Twig library that you use. And looking at their repo, I see this is a problem that they fixed three years ago. (see https://github.com/twigphp/Twig/commit/98c2233e4734ccc1b5b357bba5c712bb53fc3b23).

So it looks like the problem would go away if you just updated the version of Twig that you’re pulling into your codebase.

Is that something you could do simply?

Cheers,

Dave…

Hi @hendcorp, thanks for the reply.

I was just looking at your GitHub repo. It looks like you don’t have any CI process in place (or, at least, not one that uses GitHub Actions). Would you be interested in getting some help in setting up CI that automatically runs you unit tests against several PHP versions on every commit?

I have what seems to be exactly the same problem.

See https://www.ads-software.com/support/topic/broken-permalinks-15/

Some further investigation.

I created a new post on the new installation (the one in the subdirectory) and it exhibited exactly the same behaviour as the migrated posts.

I think that means the migration isn’t the problem here and I don’t need to change anything in the database.

Any other suggestions would be appreciated.

Thanks for your suggestion.

Could you please confirm which columns in which tables need to be updated?

I thought that the URL would be generated from posts.post_name and various installation-level pieces of information – so I don’t think I need to update those.

There’s a column in the posts table called “guid” which seemed to contain the old-style URL. I’ve updated those, but I see no change in behaviour.

Oh, I know exactly how to fix mixed content warnings, thanks. Using the plugin was just a shortcut. The hard part will be finding any problems. I guess I’ll just write a crawler.

Is there anything that can be done to fix the incompatibility between Jetpack and HTTP/HTTPS Remover?

Cheers,

Dave…

Hi,

Thanks for the reply. It seems that the problem is a conflict with a plugin called HTTP/HTTPS Remover.

https://www.ads-software.com/plugins/http-https-remover/

I’ve disabled the plugin and the Twitter share button is working fine. I suspect I might be in danger of generating some “mixed content” warnings though – so it would be good to get a fix for the problem.

Cheers,

Dave…

Hmm… so installing the Pro version overwrites the Jetpack custom CSS? That’s seems strange.

I’ve put it back now. Thanks for the heads-up.

That’s great. In fact I needed to make it even wider to accommodate all of my long titles. But 165px seems to do the job.

Thanks for your help.

Dave…

Well, it explains what is going on. But I can’t really say that it helps.

When Twenty-Sixteen was announced in August I really liked it so I started using it on a number of my sites. It worked fine. Nowhere in the information I read was it mentioned that I would need to stop using it at some point as it would become incompatible with the release version of WordPress.

So now I’m left with the choice of using an unreleased version of WordPress on production sites (not gonna happen) or changing theme again.

I guess I have to take the second option, but it leaves a bad taste in the mouth.

Seriously, can’t you see what a bad idea this is? If you release a theme without marking it as “Beta” or something like that, then people are going to start using it. Taking it away from them again six weeks later is just rude.

Actually, scratch all that. I switched to a different video and it all worked fine. Sorry.

Underneath the featured video input it says:

“Featured Image: For automatically displaying the Featured Video a Featured Image is required.”

And then there’s a link that says “Set as Featured Image”. But clicking it doesn’t seem to fix anything.

Yes. I just tried to use a featured video on a new post for the first time since the 4.2 upgrade and the video doesn’t appear.

Commenting out line 524 fixed it.

I’m afraid it was me being stupid. The new photos I had uploaded were not public. Fixing the permissions was the solution.

Sorry for c eating your time :-/