dblomster

@qriouslad I encountered this error when I wanted to inspect a prospective client’s site. I only had the WP admin login details and no access to a control panel or ftp. So I was stuck with PHP 7.2 in this case, until I was able to clone the installation to another server. I think this is a common thing to encounter for consultants.

I believe that the issue is related to this change in PHP 7.3 -> https://www.php.net/manual/en/migration73.new-features.php#migration73.new-features.core.heredoc

If you don’t want the plugin to support PHP 7.2 I think that you should specify a minimum required PHP version in the plugin’s readme.txt file, using the Requires PHP header.

Thanks!

@qriouslad The reported issue occurs on PHP 7.2. Did not occur after I switched to 7.4.

Hi Josh!

You’re absolutely right! And it’ll be updated eventually. However, it’s a heavily customized WooCommerce solution so it’ll take some time.

Actually, it’s only the wc_help_tip function call that prevents your plugin from working, so a simple function_exists check would do the trick.

Thanks!

Hello,

These functions would be very useful for WooCommerce products. Please add support if you can ??

Thanks!

Seems like you nailed it this time! Fantastic achievement!

I’ll be moving my site to production soon and will let you know if any issues should arise.

Might be a good time to add a donation link for this plugin ??

Interesting about sessions! Actually, I don’t use the cart, all products are of the type External/Affiliate.

Var dumps of $woocommerce->session->products_per_page reveal that the number of products is set after drop-down selection and then becomes NULL when going to the next page.

Maybe what’s discussed here -> https://github.com/woothemes/woocommerce/issues/4920 <- could be related to the issue I’m seeing?

What do you think?

Thanks for the update!

1. I’m running the latest WP/Woo version with a custom theme locally . But I guess this issue should be checked on a standard WP/Woo installation with the default theme as well. Perhaps I’ll be able to set it up within the next few days. Also, if you need any debug output, or variable dumps or such, let me know.

2. Seems all right at first glance, great ??

3. This one didn’t work in my setup, so I putted in this code in the public function wppp_create_object:
if ( ! woocommerce_products_will_display() ) { return; }

After doing some quick testing, I’d say the plugin seems to work as it should when filters are enabled! Many thanks for your swift and accurate update. Should any issues arise, I’ll let you know.

Hello Sormano,

I found the reported issue in a local environment, but when you release an update I’ll test it and report back.

Yes, I enabled the First category page setting. Actually, for the project I’m working on now I only need the option to list the default number of products per page or all products.

Btw, I’ve found a theme which has a products per page function that works in conjunction with filters and sorting -> https://www.kriesi.at/themes/enfold/shop/
As you can see, when you do a selection, a product_count parameter will appear in the url. If you need more details about this particular theme, let me know as I might be able to get you some additional info.

Keep up the good work!

Just want to add that the same behavior goes for sorting, e.g. if I choose to sort by price low to high, this is reset after using the plugin’s dropdown.