demerit

Awesome, thank you.

Ok great, thanks.

Ok thanks for the response.

It’s a standard unified diff patch file, but in this case it’s just a one line change so to do it manually, it’s saying change line 94 in wp-content/plugins/wordpress-seo/admin/links/class-link-watcher.php from the one that starts with a “-” to the one that starts with a “+”, not including the “+” sign, i.e. change line 94 to

return ( $post_type_object !== null && $post_type_object->public === true && substr($post_type, 0, 3) !== 'ms_' );

The line number assumes you’re on the same yoast version.

This may or may not be the same problem but I get an infinite loop with version 5.8 of yoast when you click the “Complete Membership” button. This isn’t really a fix more of a hack but I changed one line in yoast and it seems to avoid the problem.

--- admin/links/class-link-watcher.php.bak
+++ admin/links/class-link-watcher.php
@@ -91,7 +91,7 @@
                $post_type        = get_post_type( $post_id );
                $post_type_object = get_post_type_object( $post_type );

-               return ( $post_type_object !== null && $post_type_object->public === true );
+               return ( $post_type_object !== null && $post_type_object->public === true && substr($post_type, 0, 3) !== 'ms_' );
        }

        /**

Well, if you change the line I mentioned to
if ( ($delay !== FALSE) && ($delay < $ignore_duration) ) {
then it does something, but I’m not familiar enough with the rest of the code/plugin to know if this is the right fix or if it might break some other feature.

• This reply was modified 8 years, 1 month ago by demerit.

I’m not sure about “tags”, but go to membership2 -> addons and select the one called Individual Posts. Then you can set the post to protected.

I am having the same problem. I think problem might be in MS_Model_Communication::send_message() where it calls
$delay = $subscription->seconds_since_last_email( $this->type );
This returns FALSE if no such email has ever been sent yet, and so lower down where it says
if ( $delay < $ignore_duration ) {
this always returns true and so it thinks it’s a duplicate email and skips it. If you have logging turned on you get a file lib3.log under wp-content that shows the skipped message.

I am having the same problem. I think problem might be in MS_Model_Communication::send_message() where it calls
$delay = $subscription->seconds_since_last_email( $this->type );
This returns FALSE if no such email has ever been sent yet, and so lower down where it says
if ( $delay < $ignore_duration ) {
this always returns true and so it thinks it’s a duplicate email and skips it. If you have logging turned on you get a file lib3.log under wp-content that shows the skipped message.

Just a quick followup that the lines above that in prepare_fields_edit() where it accesses $user->subscriptions are also part of the problem, since if subscriptions is protected they should be retrieved via some public method.

And above just to clarify my use of true/false I meant that empty($subscription->expire_date) always evaluates to true, so that the if clause always evaluates to false.