DevynCJohnson

@dglingren , Thanks! The development version and changing the value of link worked.

I will now donate (using the button already provided in the plugin) as this solution works perfectly.

Also, soon, I will be adding more shortcodes and features to this plugin. I also intend to add an options page where admins can enable/disable certain shortcodes and apply other settings. Feel free to send me an email with your ideas and wish-list. I would like to get this plugin up to 1000+ users and hopefully get some positive reviews before I lose interest.

Originally, I made this plugin for my own use after alternatives were no longer supported. After having had some people that viewed my site ask me what I am using for shortcodes, I soon had some people ask that I publish my plugin. I published it because people wanted and liked it. Besides donations (which I never received), knowing that people like and enjoy the plugin is a big motivator to me in taking the time to provide this plugin.

I released the fix. Thankfully, a fellow user of this plugin emailed me concerning the issue. It is now fixed. For some reason, I did not experience this issue on my website, but at least a fellow user that experienced the issue emailed me about it. I cannot fix an issue if I do not know there is an issue.

Also, the review page is not for reporting issues. The review page makes me seriously wonder why I share this plugin.

As a temporary (but poor fix) the below code can be added to “functions.php”.

//Remove nofollow
function rm_nofollow($txt){
    $txt=str_replace(' rel="nofollow"','',$txt);
    return $txt;
}
add_filter('bbp_get_topic_content','rm_nofollow',20);
add_filter('bbp_get_reply_content','rm_nofollow',20);

As a temporary (but poor fix) the below code can be added to “functions.php”.

//Remove nofollow
function rm_nofollow($txt){
    $txt=str_replace(' rel="nofollow"','',$txt);
    return $txt;
}
add_filter('bbp_get_topic_content','rm_nofollow',20);
add_filter('bbp_get_reply_content','rm_nofollow',20);

Why is it that “sem-external-links.php” never loads or uses “sem-follow_comment.php”? I noticed that none of the PHP files use “sem-follow_comment.php”.

Here is an example of a plain “code” tag that “External Links” did not ignore https://dcjtech.info/topic/self-extracting-archives-for-linux/ . Look for the line “shar -x -s [email protected] *.pdf > manual.shar”.

I am currently waiting for an answer on the bbPress forums ( https://bbpress.org/forums/topic/nofollow-on-internal-links/ ). However, in the meantime, I disabled bbPress’s ability to add “nofollow” to links by commenting out the below lines in bbPress’s code.

//add_filter( 'bbp_get_reply_content', 'bbp_rel_nofollow',   50   );
//add_filter( 'bbp_get_topic_content', 'bbp_rel_nofollow',   50   );

However, the “nofollow” attribute is still being given to the links (example – https://dcjtech.info/topic/general-unixoid-topics/ ). Are you sure that nothing was accidentally changed in “External Links”? I did not have this issue until after I updated the plugin and nothing else has changed since that time. True, it is logical to suspect bbPress since links on WordPress pages (like https://dcjtech.info/guides/ ) are not effected by this “nofollow” behavior. However, I disabled bbPress’s ability to apply the “nofollow” attribute, so the behavior should have stopped.

Once I officially find the source of the problem and apply a working solution, I will be sure to let you know.

That is interesting. I never had that happen before. I have always inspected the HTML code of my pages to ensure that everything is operating as expected. I will figure out what changed to cause that issue. Thanks for the link. I would have never suspected bbPress to be the cause of the problem.

This bug is only seen on bbPress forum posts, but not WordPress “pages” such as https://dcjtech.info/guides/

Yes, I checked/enabled the “Do not process links in html code blocks” option. URLs in pre and code tags/blocks are still being processed by the “External Links” plugin.

At this moment, I wonder if the issue relates to the order in which plugins perform their tasks. For instance, I use the “EnlighterJS” plugin to provide syntax coloring to code in pre tags and other blocks. I wonder if there is a conflict between the “External Links” plugin and “EnlighterJS”.

If that is the case, then here is a suggestion. You may want to add “EnlighterJSWrapper” and “EnlighterJS” classes to the exclude list as well as EnlighterJS’s shortcodes. However, it may be easier to make the “External Links” plugin execute later than usual and then ignore “EnlighterJSWrapper” and “EnlighterJS” classes (which are used in div, ol, ul, and span tags).

Thanks for the fix! This is a great plugin.

Thanks for the info and new version. I should have known that parenthesis were acceptable. After reading your comment, I then remembered that Wikipedia uses parenthesis in some of its URLs. I never knew that semicolons and some of the other characters were acceptable.

The link is not broken. www.ads-software.com added the ending parenthesis to the URL.

Once you get to the page, scroll down to the “HTML5 Code” section and view the sample code. The “p” tag that contains an “a” tag should not have an “a” tag. The “External Links” plugin added the “a” tag code because of the URL that is in the sample HTML code.

NOTE: I noticed that this website (www.ads-software.com) does not allow commas and periods to be used in the “href” of an <a> tag, but you get the idea.

Here is a screenshot of the bug – https://dcjtech.info/wp-content/uploads/2015/09/External-links.jpg

Below is the code that the “External Links” plugin created. The plugin should not be using the parenthesis and comma that follows the URL.

<a href="https://dcjtech.info/forum/downloads/),">https://dcjtech.info/forum/downloads/),</a>