David Garcia Watkins

We could, of course.
I just wanted to know your approach to this so I can decide how to proceed.
Thanks!

Simply changing the priority does the trick.

If you would like to test this yourself you can signup to our go-global program and we will supply you with a developer license of WPML:
https://wpml.org/documentation/theme-compatibility/go-global-program/

Thanks!

Thank you for the speedy reply and release.
I will let you know if we come across anything else.

Good day!

• This reply was modified 7 years ago by David Garcia Watkins. Reason: resolve

Great news,
Thanks
David

Hi Albert,
If you can test my fork I’m sure the feedback will be useful:
https://github.com/dgwatkins/better-amp/archive/master.zip
Let us know if it works for you.

As promised, here is the PR:
https://github.com/better-studio/better-amp/pull/40

It fixes issues with AMP urls by excluding language subdirectories
The code was already there, but it had to run earlier and more often.

Hi,
This is David from the WPML compatibility team.
This works much better now, thanks so far.

This is what I found:
– pages, posts and archive pages work
– the home page still doesnt work though
– the url in amphtml meta is incorrect

I will try to fix these and send a PR to your github project.

I found this problem too.

To resolve it you can edit includes/functions/theme-functions.php and replace bf_social_share_guss_current_page with better_amp_social_share_guss_current_page and bf_social_share_fetch_count with better_amp_social_share_fetch_count

Let’s hope the author fixes this soon.

Hi Fiona

What I understand is that you have 2 problems.
The first was indeed resolved with the above change.
The second one we are still investigating.

Please correct me if I’m wrong.

David

Here is a guide about translating texts in the wp_options table:
https://wpml.org/documentation/getting-started-guide/string-translation/#admin_texts

Hi @jfarthing84

This is David from the WPML compatibility team.
If you need WPML to test these changes before making a new release with these changes, you are invited to join our Go-Global program and we will supply you with a developer license:
https://wpml.org/documentation/theme-compatibility/go-global-program/

I also submitted an issue to github with a pull request:
https://github.com/jfarthing84/theme-my-login/issues/123

• This reply was modified 7 years, 7 months ago by David Garcia Watkins.

If you think its related to WPML please open a new support thread over here:
https://wpml.org/forums/forum/english-support/#new-post

Hi, you can try the following solution:
https://wpml.org/forums/topic/theme-my-login-custom-emails-translations-are-not-used-in-the-actual-sent-emails/#post-1307618

This is probably because you already have a value in ‘sm_b_exclude’.

I have rewritten the fix slightly so this doesn’t happen and it will be included in next release of WPML which is currently going through QA.

As soon as WPML 3.8 is released, this workaround can be removed.

• This reply was modified 7 years, 8 months ago by David Garcia Watkins.