disagree

In your case you could replace that line with :

wp_redirect( "https://..." );
exit;

• This reply was modified 5 years, 1 month ago by disagree.
• This reply was modified 5 years, 1 month ago by disagree.

The error is because of line 386 :

	    // 4. Show 404 template
	    require get_404_template();

which should be instead :

	    // 4. Show 404 template
	    if ( '' != get_404_template() )
	        require get_404_template();

According to https://codex.www.ads-software.com/Function_Reference/get_query_template

I guess one way to get around this issue would be to be able to exclude css files, paths and/or external hosts from the “combine css” feature.

I think I understand your point – my issue is just having themes and plugins that inject so many separate .js files. I’d at least like to have them grouped, instead of having 50 separate https requests because of included .js files. That is also blocking.

I’m used to js combiners grouping 10-20 files at once, so they still can be loaded in parallel.

The difference ( in my case ) on pingdom is 143 request with Pegasaas vs 72 requests with autoptimize.

( And no, I wouldn’t want to inline js )

If PegaSaaS doesn’t support this, then a plugin like autoptimize ( or similar ) should be allowed to co-run with it, just for this purpose. Right now that doesn’t seem to be possible.

Thanks for your quick and thorough response!

Another solution for this is to change in wp-config.php :
define( 'DB_CHARSET', 'utf8' );
to
define( 'DB_CHARSET', 'utf8mb4' );

Hi all,

Thank you for your replies, but I’m not sure they answered my question.

I would like the discount to be based on a value stored within the product, not a global calculation. Is that possible?

Thanks

@ristoniinemets would be nice if you could update this in the changelog, as when you get the update notification you see a changelog popup with different version numbers

Thanks Khang

I’ll review and send you a PR to github, so your future updates won’t overwrite those changes ??

Hey Khang,

Is it possible to adjust the filename of the generated css/js file based on the md5 checksum of the contents?

That way could push the css files to CDN without fearing for cache issues, and could drop the ?ver= parameters which are bad for frontend caching and micro cache proxies like varnish.

E.g. right now the .js result I get is this :

/cache/minify-b1-flexslider-684c1e3d23b06bc0b7d1a6d2ed4e90de.js?ver=1413915527

Once I change one of the files, it currently just changes the last part of the url ( the ver= part )

/cache/minify-b1-flexslider-684c1e3d23b06bc0b7d1a6d2ed4e90de.js?ver=1414633462

Any way to simply change the 684c1e3d23b06bc0b7d1a6d2ed4e90de checksum based on the file contents instead?

( i mean i understand it programmatically, but i thought bwp was taking care of file changes already )

I don’t understand the cache buster part – e.g. that it’s not updated if the source files change – aren’t you creating md5 based on the source css/js files date timestamps or checksums?

so if i have style.css and style1.css i have another checksum than when style1.css was being altered meanwhile? the ctrl+f5 idea is not a good solution

it seems the script is checking through verify_exists every time if the file is on the CDN, is that intended behaviour?

can you please use e.g. transient cache for this instead, that’s expensive lookups on loading time and CDN costs

or move it to cron altogether and just compare against the retrieved bucket list?

regarding CURL, fopen and get_headers code, i would suggest using the in-built wp functions for that, as they handle the proper feature detections already https://codex.www.ads-software.com/Function_Reference/wp_remote_retrieve_response_code ( and https://codex.www.ads-software.com/Function_Reference/wp_remote_get and https://codex.www.ads-software.com/Function_Reference/wp_remote_request etc )

cool!

wp-cli is also great for that

wp w3-total-cache flush
wp w3-total-cache pgcache_cleanup
wp w3-total-cache querystring
wp w3-total-cache cdn_purge

etc