dokkaebi
Forum Replies Created
-
Forum: Plugins
In reply to: [Regenerate Thumbnails] thumbnails now lower quality even after uninstallingRolling back didn’t help. My problem may not be the fault of this plugin since I don’t think it would’ve changed any settings or the database. I have no idea why this happened, I’ll keep looking.
Forum: Plugins
In reply to: [Join My Multisite] translationI’ve upgraded to version 1.3 of the plugin and it’s working great except for some translation issues. To get translation to work, I did the following.
1) I still had to do step 3 of above:
add the lineload_plugin_textdomain( 'helfjmm', false, dirname( plugin_basename( __FILE__ ) ) . '/languages/' );
to the end of the init() function in joinmymultisite.php2) Change line 131 on signuppage.php to:
<h2><?php printf( __( '%s is your new username', 'helfjmm' ), $user_name) ?></h2>
Because the textdomain ‘helfjmm’ was missing.3) This is the big one. Since the form field validation is done by calling
wpmu_validate_user_signup()
, the error message strings are not translated. As a workaround, I made a sub function calledrewrite_errors_for_translation()
that checks for each error message string and creates a new one so that translations can be pulled out for each string. My modified signuppage.php is posted at https://pastebin.com/AAdac9KY(Translators: Make sure esc_attr_e is included as a Poedit keyword when you do your translation)
Forum: Plugins
In reply to: [Join My Multisite] translationAwesome!
I’ve made only a partially-translated po in Korean for the text that is displayed to the user. I’m not certain it’s 100% accurate, either, so I don’t think it would be appropriate for an official release.
Forum: Plugins
In reply to: [Join My Multisite] Problems and workarounds using v. 1.1 on wordpress 3.4.2Cool! I contributed something. ??
Here it is:
https://pastebin.com/74hwS1RDThe code near the beginning of the file that set $goto sets $goto correctly, but the function signup_user can’t read it. I guess it’s a scope issue, but I don’t know what php scope rules are. So I just copied and pasted the code that sets $goto into the function.
Cheers!
Sungwon