Drivingralle

https://github.com/Automattic/WP-Job-Manager/issues/970

Hey!

Like the idea of having a spot to comment on. Guess that’s more clear for users that don’t use screenshots a lot.

I feel like the steps and when what is to do is not clear. While I’m still on the “Welcome”-Step I can already set the spot and then fell a bit stuck.
The first step should just “welcome” the user. Then a step for pointing. Then step for entering feedback. …

After dragging/swiping the spot around, while entering the feedback, the page behind the shadow can still be moved. I guess that’s because of the early version.

The popup doesn’t lead to horizontal scrolling anymore, but the box is still bigger than the viewport in my test case.

Greetings
derRALF

Hey!

Thanks for the super super quick reply.

I can see this Warning in my PHP Logs. No user’s harmed ??

To bad that the API locks down.
Looking forward to the next release.

Greetings
derRALF

Hey!

Because of a complex setup we are using the legacy mode of the groups plugin.
Leading to even more entries in the PHP (7.1.1) log. I get about 37.000 of this notices per day.

PHP Warning: Parameter 2 to Groups_Post_Access_Legacy::posts_where() expected to be a reference, value given in /wp-includes/class-wp-hook.php on line 298

and still the good old notice for:
PHP Warning: Parameter 2 to Groups_Post_Access::posts_where() expected to be a reference, value given in /wp-includes/class-wp-hook.php on line 298

Would like to see this notice gone.

Greetings
derRALF

Moin!

Danke für die schnelle und super Antwort.

Habe es wie von dir beschrieben eingebaut und es l?uft.

Hinweise für Leute die es selber auch nachbauen wollen.
Hier sind zwei Funktionen die euch die entsprechenden Werte für die beiden Parameter dynamisch liefern:
URL: get_home_url( null, $_SERVER[“REQUEST_URI”] )
TITLE für Taxonomien: get_the_archive_title()

Es grü?t
derRALF

Any updates on this feature request?
It would be super helpful for more complex cases.

I would also like to see it support custom taxonomies, so posts added to a c-tax don’t show up in the newsletter.
Should not be to complicated with WP-Query arguments.

If you don’t want to add a UI for it a filter would be fine for me.

Greetings
derRALF

Hey!

The plugin doesn’t break on PHP 7, but I always get a notcie in my php logs.
Would love to see an update to remove the notice.

Greetings
derRALF

Hey!

Can you provide more details what notices you get?

Greetings
derRALF

What security attacks do you mean?

Greetings
derRALF

@abigailm and @proaktion I’m not sure if my change is a real fix. I just noticed that it’s about this line and the parameter.
The solution is probably something more complicated. I don’t know the plugin code well enough to create a PR.

I get this notice a lot in one of my projects.

Greetings
derRALF

Hey!

Great.
Looking forward to it.

Greetings
derRALF

Hey!

No more warnings with version: 2.0.9
Thanks.

Greetings
derRALF

Hey!

Any updates on this topic?

I’ve tested all my plugins with this PHP linter:
https://www.ads-software.com/plugins/php-compatibility-checker/

Unfortunately I found a problem with this plugin:

FILE: /wp-content/plugins/wysija-newsletters/inc/pear/pear.php
———————————————————————————————————————
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
———————————————————————————————————————
171 | ERROR | Use of deprecated PHP4 style class constructor is not supported since PHP 7
740 | WARNING | INI directive ‘safe_mode’ is deprecated from PHP 5.3 and forbidden from PHP 5.4.
754 | WARNING | The use of function dl is discouraged from PHP version 5.3
754 | WARNING | The use of function dl is discouraged from PHP version 5.3
852 | ERROR | Use of deprecated PHP4 style class constructor is not supported since PHP 7
———————————————————————————————————————

FILE: /wp-content/plugins/wysija-newsletters/inc/phpmailer/class.phpmailer.php
——————————————————————————————————————————————-
FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 8 LINES
——————————————————————————————————————————————-
527 | WARNING | INI directive ‘safe_mode’ is deprecated from PHP 5.3 and forbidden from PHP 5.4.
1358 | ERROR | INI directive ‘magic_quotes_runtime’ is deprecated from PHP 5.3 and forbidden from PHP 5.4.
1362 | ERROR | INI directive ‘magic_quotes_runtime’ is deprecated from PHP 5.3 and forbidden from PHP 5.4.
1785 | WARNING | The use of long predefined variables has been deprecated in 5.3 and removed in 5.4; Found ‘$HTTP_SERVER_VARS’
1786 | WARNING | The use of long predefined variables has been deprecated in 5.3 and removed in 5.4; Found ‘$HTTP_ENV_VARS’
1789 | WARNING | The use of long predefined variables has been deprecated in 5.3 and removed in 5.4; Found ‘$HTTP_SERVER_VARS’
1791 | WARNING | The use of long predefined variables has been deprecated in 5.3 and removed in 5.4; Found ‘$HTTP_ENV_VARS’
1879 | ERROR | The use of function split is discouraged from PHP version 5.3 and forbidden from PHP version 7.0; use preg_split instead
——————————————————————————————————————————————-

FILE: /wp-content/plugins/wysija-newsletters/controllers/back.php
——————————————————————————————————————————————————————–
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
——————————————————————————————————————————————————————–
207 | WARNING | Method name “WYSIJA_control_back::__setMetaTitle” is discouraged; PHP has reserved all method names with a double underscore prefix for future use
——————————————————————————————————————————————————————–

FILE: /wp-content/plugins/wysija-newsletters/views/back/campaigns.php
——————————————————————————————————————————————————————————–
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
——————————————————————————————————————————————————————————–
2359 | WARNING | Method name “WYSIJA_view_back_campaigns::__filterPostParent” is discouraged; PHP has reserved all method names with a double underscore prefix for future use
——————————————————————————————————————————————————————————–

FILE: /wp-content/plugins/wysija-newsletters/helpers/bounce.php
———————————————————————————————————————-
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
———————————————————————————————————————-
63 | WARNING | The use of function dl is discouraged from PHP version 5.3
———————————————————————————————————————-

Would be great if you can fix this!

Greetings
derRALF

Hey!

Thanks for your work at the plugin.

Looking forward to the plugin update to get the PHP7 compatibility in the stable version.
Any release schedule?

Greetings
derRALF

I couldn’t find a github repo to make a PR.

Take a look at this for more information:

Deprecating PHP4 style constructors in WordPress 4.3

Greetings
derRALF