Eric McNiece

Here’s the zip… tested and working on my own sites: https://drive.google.com/file/d/0B0dF9s9uV9jPMFJaSm1rQ3hJeGM/view?usp=sharing

Yeah, FWIW I totally moved to https://aelia.co/shop/currency-switcher-woocommerce/ as well. Paid, but works like a hot damn out of the box.

Oh, k… you didn’t actually do step 1 right?

Replace the file /home/agenceta/public_html/koso/wp-content/plugins/woocomerce-price-by-country/class-woocommerce-price-by-country-settings.php with this file: https://pastebin.com/X3HzDgPk

edit: I can give you a zip of the entire plugin if you want!

So the problem is that line 369 of class-woocommerce-price-by-country-settings.php still has that busted function on it. Lemme dig through and see if I can give you a better description…

Bonus upgrade: enable chosen dropdowns in the admin!

https://pastebin.com/dxbsCjM1

Got it.

There is a call to $woocommerce->add_inline_js() on the settings page, which is a function that has been deprecated in WooCommerce. This is causing the settings page form to crash, removing the bottom scripts from the page.

Quick fix: replace class-woocommerce-price-by-country-settings.php with this: https://pastebin.com/X3HzDgPk

Long-term fix: get in touch with the plugin author.

This is causing the settings page form to crash, removing the bottom scripts from the page.

Quick fix: replace class-woocommerce-price-by-country-settings.php with this: https://pastebin.com/X3HzDgPk

Long-term fix: get in touch with the plugin author.

Uncaught TypeError: undefined is not a function admin.php?page=wc-settings&tab=integration:519

$.chosen() is not applying properly. Investigating…

@brianmiyaji thx dude. Please feel free to use the code… the only reason it isn’t in SVN is because I’ve been stuck in git for the last eon.

Thank YOU for the great plugin!

I see them showing up properly in my version of https://github.com/emcniece/Visual-Sitemap so I’ll take a guess at what your issue might be:

1. Sitemap reads your page heirarchy (not the menu heirarchy) and your pages aren’t stacked the way you want
2. CSS in your theme is preventing deep-nested list elements from being displayed

This is of course assuming you are talking about the front-end shortcode-based display, and not the admin view. Either way, you should open a new topic.

Here you go.

https://github.com/emcniece/Visual-Sitemap

This version uses a shortcode: [visual-sitemap]

Enjoy!

+1!

+1!

Alright, I’ll bite…

Part of the beauty of an open-source system is that we have developers of all skill levels contributing en masse to help make the world a better place. Everybody is at a different level of programming competence, and it’s not really fair to call someone a noob purely on the grounds that they used a coding convention that you would deem inappropriate, whether it is correct or not. I might even go so far as to say that such remarks are irrelevant and counter-productive – this is a support queue, not a complaints line, and YOU are the one asking for a favor.

After all, if you can do it better… why don’t you? A simple answer might be because it takes time, probably time that you don’t have. So instead of making off-topic remarks, let’s focus on the core issue and be appreciative of the time it took to create this plugin. Talking down to people makes you come across as having an inflated ego and that sets others up to discriminate against you.

That said, your tone comes across well and is generally supportive, so thank you on that front! It is way too easy to come across as a jerk when one might simply trying to provide constructive feedback.

In the spirit of providing constructive criticism and working towards a solution, let’s see if we can turn this around!

< /hypocritical off-topic rant >

I’m starting to dig into this plugin as well and having difficulty applying some custom scripting to the plugin filters. Having all of these elements set to IDs instead of classes makes it challenging to write efficient Javascript selectors!

It also seems that some of the HTML structure forces the display of some elements in ways that work against established styles.

• Would it be possible to convert the ID items to classes?
• Could we add extra classes to aid in addressing items?
• Some of the wrapper attributes are counter-intuitive, could these be grouped more appropriately?
• Would it be a better idea to let themes style list items instead of forcing <br /> tags into the page structure?

As an example, the id bug-library-filter-currentproduct appears twice in the filters list. While this is technically invalid HTML since ID attributes should be unique, it would be totally valid as a class! It looks like there are some even-odd attributes set as IDs as well that could benefit from a class conversion.

Sometimes it can be tough for developers to work around forced line breaks. I’m currently styling the filters and attempting to create a more horizontal layout, and having breaks at the end of each line makes it hard to accomplish. I could use CSS to display:none the <br /> elements, but then what if those elements were needed for a single section? Perhaps it is easier to let themes decide how to display elements… and that means less work for the plugin developer as well! As an alternative, elements can be styled for block or inline display to produce desired results.

A very minor adjustment might be to move the bug-library-currentfilters div into the bug-library-filters div to provide structure consistency. This is a totally cosmetic change though and is subjective to the author.

Here’s a proposed update to the bug-library.php file: https://pastebin.com/s2BXaAia. This file cleans up some of the filter HTML – it doesn’t touch the rest of the code, but it might serve as an example for how classes could work just as well (if not better) than IDs.

I do see that there are more areas in this file with numerous   characters that could probably have some restructuring applied as well, but… I don’t have time right now ??

@yannick – thanks for your hard work on this plugin!

@cory – thanks for opening this topic! I’m Eric, and I live in Victoria BC, nice to meet you ??

I’m not convinced that this is normal behavior. I am currently dealing with a [textarea textarea-123] field that keeps being validated regardless of whether the shortcode in the form designer has an asterisk or not. Removing the field prevents allows the form to be submitted properly, but

… FOUND IT. The textarea had the same id as another field that is required. CF7 was just flagging both IDs as it saw fit.

You win this time, buzztone ??