Forum Replies Created

Viewing 2 replies - 1 through 2 (of 2 total)
  • This version (and pretty much every version) breaks my site RSS feed due to extraneous whitespace in the PHP files.

    I’d suggest it needs to follow the WordPress PHP coding standards:
    https://make.www.ads-software.com/core/handbook/best-practices/coding-standards/php/#remove-trailing-spaces

    Glad to see someone else found this… updating this plug-in broke our RSS feeds due to the extraneous whitespace.

    Here’s a git patch file for the relevant changes:

    Date: Sat, 22 Aug 2015 15:37:14 -0500
    Subject: [PATCH] Remove harmful whitespace due to php tags
    
    ---
     modern-facebook-post-embed.php | 13 +++----------
     1 file changed, 3 insertions(+), 10 deletions(-)
    
    diff --git a/modern-facebook-post-embed.php b/modern-facebook-post-embed.php
    index 138240d..14bc916 100644
    --- a/modern-facebook-post-embed.php
    +++ b/modern-facebook-post-embed.php
    @@ -35,9 +35,9 @@ You should have received a copy of the GNU General Public License
     along with this program; if not, write to the Free Software
     Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
     */
    -?>
    
    -<?php
    +
    +
     class MFacebookPostEmbed
     {
    
    @@ -428,9 +428,6 @@ function fb_pe_button_icon(){
     }
     add_action('admin_head','fb_pe_button_icon');
    
    -?>
    -
    -<?php
    
     function facebook_page_embed_style(){
    @@ -554,9 +551,7 @@ function fb_page_button_icon(){
     	<?php
     }
     add_action('admin_head','fb_page_button_icon');
    -?>
    
    -<?php
    
     function facebook_video_embed_style(){
    @@ -666,10 +661,9 @@ function fb_video_button_icon(){
     	<?php
     }
     add_action('admin_head','fb_video_button_icon');
    -?>
    
    -<?php
    +
     function facebook_comments_embed_style(){
     	?>
         	<style type="text/css">
    @@ -799,4 +793,3 @@ function fb_comments_button_icon(){
     	<?php
     }
     add_action('admin_head','fb_comments_button_icon');
    -?>
    \ No newline at end of file
    --
    2.3.2 (Apple Git-55)
Viewing 2 replies - 1 through 2 (of 2 total)