fastfasterfastest

Thanks.

That is fair enough I think, that only the premium version has the options to control the background and border of the dropdown menu.

But… in the free version, I think it would be nice if you emitted css to style the dropdowns with the same background, font and color as their “parent” menu. We wouldn’t have an option to control the styling of the dropdowns, they would just get the same settings as their “parent”.

Anyway, it can be worked around with custom css so it’s not a showstopper. And thanks for a great theme! And great support, too.

Great – thanks!

The issue was that an element of mine that has the class visible-xs-inline was visible even when viewport was > 768px. After some investigating, I found the reason was that the version of Bootstrap that comes baked in with Virtue is 3.0.0, and the visible-*-* classes was introduced in Bootstrap 3.2.0.

I can work around that particular issue, but I am curious about being able to use the latest Bootstrap version, though.

If you build and rely on a customized version of Bootstrap, I am not sure it would be so wise for me to override it with a non-customized version – things that you/Virtue expect may then no longer hold true.
I am not a WordPress expert – it appears that Bootstrap is not enqueued separately but rather baked in with the Virtue css (and others), right? So when you say I can override the theme css I would then have to provide a full replacement of assets/css/virtue.css, right? Or, alternatively, load another version of Bootstrap in addition to, and after, virtue.css, right?
Either way seems to be messy and probably not worth it. But I am interested to learn and see if I am thinking about it the right way.
And regardless, it would be great to be able to use the latest version of Bootstrap… ??

It effects sites with non-centered logos as well. With a vanilla site using Virtue, and no primary navigation and default logo position (on the left), the non-existent primary navigation occupies 1px thanks to a min-height on kad-header-right.

Now, if you have a centered logo (and this is how I discovered this) then it gets “worse” – then there is an additional 50px occupied by the non-existent primary navigation thanks to margins on #nav-main.

I think it would make sense that if one has no primary navigation then no space should be taken up by primary navigation. And moving the test for whether primary navigation has been assigned in header.php will result in that – no primary navigation, no html emitted for it, no “stray” min-heights and margins, etc.

Yes, thanks, I know. And for the time being I am doing that, although I am using a slightly different way:

.belowlogo-text:empty{
    display: none;
}

But the point is/was, that the p tag should not have been emitted in the first place. And you appear to try to do that, to NOT to emit the p tag when there is no tagline, but the attempt fails. You are using isset() in header.php, which appears to always succeed, perhaps using empty() instead?

Thank you!

And thanks for your excellent support and responses!

Or, why not omitting the background-attachment if it is not specified (similarly how you omit the repeat and placement options if they are not specified) and simply generate:
body {background: url(some-url);}

Thanks!

By the way, I noticed Virtue 2.3.3 generates slightly incorrect css if you specify a “Body Background” image but do not specify an item for “Fixed or scroll” – then the following is generated (note the invalid/missing value for background-attachment):
body {background: url(some-url) center top; background-attachment:;}

Thanks.
Although the margin approach seemed to “work”, I followed your advice, backed it out and created a child theme, copied the templates/header.php and modified it. And that works as well.

Now with a child theme in place, I can move the Custom CSS I had specified in Advanced Settings into the stylesheet of the child theme instead.

Question: when I created the child theme, it seems like the settings I had specified in Theme Options “carried over” – is that right? I think I may have read somewhere that one may have to export the settings before activating the child theme and then importing them after the child is active. Although I don’t know if all the settings carried over, most of them seemed to at least.
I did have to re-save the secondary navigation menu settings, though, but I guess that is a WordPress thingie, not a Virtue thing.