Arkadiusz Rzadkowolski

Is it really fixed though?

It’s still ending a hrefs with /> on 0.10.1 ending up with a broken link in my case.

Read More

Even REC says that there should be at least a space if unquoted and ending with slash/solidus.

https://www.w3.org/TR/2017/REC-html52-20171214/syntax.html#elements-attributes

If an attribute using the unquoted attribute syntax is to be followed by another attribute or by the optional U+002F SOLIDUS character (/) allowed in step 6 of the start tag syntax above, then there must be a space character separating the two.

Hi Frank,
thanks for your reply.

Hmmm, but can’t you just rename Minify_HTML class so that it don’t conflict with w3?

That would resolve it in my opinion.

I can confirm some strange issues with html minify + jquery.

It happens in my case like this:

A) HTML minify disabled
-> first page + subsequent ajax pages:

innerHTML: "?<a href="https://URL">Read More</a>"
innerText: "READ MORE"

B) HTML minify ENABLED
-> first page

innerHTML: "?<a href="https://URL">Read More</a>"
innerText: "READ MORE"

-> subsequent ajax pages:

innerHTML: "?<a href="https://URL"></a>Read More"
innerText: "?Read More"

Please notice that Read More is outside of “A”

@jdailey You are welcome ??

In my case I had to disable all of the following:
Malicous File Upload
Malicious File Upload (Patterns)
Malicious File Upload (PHP)

Disabling only patterns didn’t make any change.

Adding include_once( ABSPATH . 'wp-admin/includes/plugin.php' ); resolved it for me.

Before (line 74):

// Support for Embedly
if( empty($og_image) && is_plugin_active(’embedly/embedly.php’) ) {

After:

include_once( ABSPATH . ‘wp-admin/includes/plugin.php’ );

// Support for Embedly
if( empty($og_image) && is_plugin_active(’embedly/embedly.php’) ) {

• This reply was modified 8 years ago by Arkadiusz Rzadkowolski.

Can confirm it – had to disable it due to this bug. Please change it to only trigger session when really needed.

Thank you very much. I appreciate you reply. Have a nice day!

@wpsmort: With all due respect – It’s not a discussion regarding if I should use permalink structure or not – it is about a bug in the functionality.

Yes, for me it’s a bug unless it’s stated in the description that “this plugin doesn’t work correctly with default permalink structure”.

BTW. Don’t you think it’s worth checking out? As there were other tickets to this issue in the past. I have even taken time to investigate and proposed a fix for you.

@wpsmort: Some example:

https://wp-test.dige.com.pl/?cat=1&paged=2
generates:
<link rel=”canonical” href=”https://wp-test.dige.com.pl/?cat=1/page/2&#8243; />
which is 404

Please add information that theme requires wordpress 3.9+

Actually escape character was removed – here’s fixed version:

https://justpaste.it/jym1

what i meant is that nextgen execute wp_print_footer_scripts which is “blog” (not admin) specific function. In some cases it causes theme blog css files to replace admin style.

I have given you Boldr theme as an example.

It’s not template issue – it’s misuse of wp_print_footer_scripts action in nextgen.

Correct function for dashboard is admin_print_footer_scripts

private function get_attachment_id_from_src( $url ) {

        // add multisite check for other types of links
        if(defined('MULTISITE') && MULTISITE) {
            global $wpdb;

            $attachment = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->prefix}posts WHERE guid RLIKE %s;", $url));
            if ( isset( $attachment[0] ) ) {
                return $attachment[0];
            }
        }

		// Split the $url into two parts with the wp-content directory as the separator.
		$parse_url  = explode( parse_url( WP_CONTENT_URL, PHP_URL_PATH ), $url );

		// Get the host of the current site and the host of the $url, ignoring www.
		$this_host = str_ireplace( 'www.', '', parse_url( home_url(), PHP_URL_HOST ) );
		$file_host = str_ireplace( 'www.', '', parse_url( $url, PHP_URL_HOST ) );

		// Return false if there aren't any $url parts or if the current host and $url host do not match.
		if ( ! isset( $parse_url[1] ) || empty( $parse_url[1] ) || ( $this_host != $file_host ) ) {
			return false;
		}

		// Now we're going to quickly search the DB for any attachment GUID with a partial path match.
		// Example: /uploads/2013/05/test-image.jpg
		global $wpdb;

		$attachment = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->prefix}posts WHERE guid RLIKE %s;", $parse_url[1] ) );

		// Returns attachment if isset.
		if ( isset( $attachment[0] ) ) {
			return $attachment[0];
		}

		return false;
	}

Yeap – we are using this code on our installation.

Keep up the great work!

—
Regargs,
A. Rz.

Possible fix I have used on my multisite:

private function get_attachment_id_from_src( $url ) {

        // add multisite check for other types of links
        if(defined('MULTISITE') && MULTISITE) {
            global $wpdb;

            $attachment = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->prefix}posts WHERE guid RLIKE %s;", $url));
            if ( isset( $attachment[0] ) ) {
                return $attachment[0];
            }
        }

		// Split the $url into two parts with the wp-content directory as the separator.
		$parse_url  = explode( parse_url( WP_CONTENT_URL, PHP_URL_PATH ), $url );