Roger Holman

I see this too – also, there’s a fix that Till Krüss merged today, so guessing we’ll see an update shortly!

I do appreciate you publishing your findings as I have been looking for a fix for the same issue (“Page Cache is not detected but the server response time is OK”). Thank You!

However, I believe that this fix actually does more than needed; Cache control header could be set differently for most everything & so I am using this to set it appropriately (after the “add_header x-cache-enabled “true”; ” in the server block):

location ~* \.(atom|bmp|bz2|css|doc|docx|eot|gif|gz|ico|jpeg|jpg|js|mid|midi|mp4|ogg|ogv|otf|png|ppt|rar|rss|rtf|svg|svgz|tar|tgz|ttc|ttf|wav|webp|woff|woff2|xls|zip)$ {
add_header Cache-Control "public, max-age=691200";
}

Just noticed your post, any chance you are using an ad blocker on your workstation browser? I’ve been burned by this…

Also, FWIW, I got a message yesterday from a WordFence scan that one of the files with this plugin had changed from the repository version (the comparison didn’t look malicious, more like a version got out of sync, which happens every so often…), so I removed the plugin entirely, reinstalled it, and reconfigured. It worked first time, easy peasey.

• This reply was modified 1 year, 2 months ago by Roger Holman.

Thank you, as I suspected. Closing this item. Happy New Year!

You can look at the more recent post in this forum from @jamieburchell to see what they received from bestwebsoft on this – in essence, their account has been impacted by an issue that started with an email address problem, so the free product was apparently de-listed from www.ads-software.com until this is resolved.

Jamieburchell’s thread: https://www.ads-software.com/support/topic/plugin-removal-response-from-bestwebsoft/

Also, here’s the message directly from BestWebSoft about this: https://bestwebsoft.com/blog/important-notice-urgent-community-support-needed-for-wordpress-org-plugin-restoration/

I too have seen this error (running PHP 7.4.10) in an error description and stack trace that was emailed to me by WordPress.

I would post it but concerned some of the info might be a security issue, so if you are interested, please let me know how you’d like to get it?
Thanks!

Okay, got it, thanks.

Thank you so much for your rapid reply!

So, the code was changed without a version number increment? Wordfence would not have flagged the change as a potential issue otherwise.

I have been impressed with what I have seen so far in Xcloner. It’s the best backup plugin I’ve worked with yet. However, I would suggest not making changes to the code on www.ads-software.com without a version number increment, to avoid any unnecessary security concerns going forward.

I’ve worked for 2 companies that took version control very seriously and I know it sometimes seems more of a headache that its worth, but its really best. Just my thoughts… Again, thank you!

Thanks Susan for also jumping in on this and thanks David for your response.

If a change is so small that it does not warrant a new version number, then it probably can also wait for the next release. I have worked with a number of people responsible for version control on product builds & releases and I cannot think of anyone who would allow a changed file to exist with the same version number.

The FAQ makes the point saying that “WordFence assumes that a plugin will never change if its version number hasn’t changed”, which I agree is a valid assumption.

If (as the FAQ claims), the scanned file was compared to the plugin originally downloaded, what’s to prevent malicious code from changing the “copy” of the originally downloaded plugin (which presumably must exist to make such a comparison) and causing WordFence to miss malicious code changes?

The FAQ also says, “That assumption just doesn’t fit with a lot of very popular WordPress plugins.” What other popular plugins do this?

Thanks again!
Roger

Hi, As a followup to this question (I got the same warning from WordFence, BTW), was this part of the most recent update, ie 1.13.11, about a week ago?

It seems interesting (and is somewhat concerning) that WordFence took a week to find this if so. If not, was it somehow updated by Updraft since then?

Also, I see what looks like the same code (in the same screenshot as rfollett sent) where a hexadecimal value looks like it should also be \0x0B instead of \x0B (which maybe PHP is treading like a string instead of the hex value 0B). The code referenced is three lines down from the first line that changed to \0x0B.

Thank You!
Roger