frafor

Well I’m a bit disappointed too because I thought the official Vimeo plugin should provide basic upload functionality, instead they give us fancy but questionable product gallerymaking stuff like… what is this??

add_filter(‘dgv_enable_tinymce_upload_plugin’, ‘__return_false’);

Hi Jay, thanks for the opportunity, I’ve just sent an email!

Yes that’s exactly what I meant. If you want I’d be happy to beta test.

Another thing that’s bugging me is that it seems the plugin isn’t saving anything in wp_yarpp_related_cache, the table is just empty.

Since the website is around 200.000 posts, I was wondering about the mechanism of the table cache.

By looking at the plugin code, I understood that you prime the cache with the enforce() or update() method several time even when using display_related() function (the website uses custom positions with differents weight/settings in order to avoid using the same posts at the moment) although I did not clearly understand what “setup_active_cache()” does and what’s the difference between active_cache and cache props.

However, above all, I cannot understand why the table does not get populated…

• This reply was modified 2 years, 9 months ago by frafor.

Honestly it’ll take a while to setup a clean setup because I do not have time at the moment

Can you please tell me where t.$body should be defined, so I can check if the script loading order is correct on my current setup (which is already split in two branch so i can test there)

BTW just rolled back to 4.10.0 and it’s working fine, so definitely there’s an issue with the latest ver

It is indeed. Just use _pdf_serial in your pdf template

/*
* Makes Flamingo _serial_number work even in PDFs as _pdf_serial
*/

add_filter('wpcf7_posted_data', 'add_serial_number_as_posted_data', 10, 1);

function add_serial_number_as_posted_data($posted_data) {

  $wpcf = WPCF7_ContactForm::get_current();
  $submission = WPCF7_Submission::get_instance();

  if($submission) {

    $post_meta = get_post_meta( $wpcf->id(), '_flamingo', true );

  	$channel_id = isset( $post_meta['channel'] )
  		? (int) $post_meta['channel']
  		: wpcf7_flamingo_add_channel(
  				$contact_form->name(), $contact_form->title()
  			);

  	if ( $channel_id ) {
  		$serial = 1 + (int) Flamingo_Inbound_Message::count(
  			array( 'channel_id' => $channel_id )
  		);
      // adds some zeroes in front of the serial
      $serial = str_pad($serial, 4, "0", STR_PAD_LEFT);
  	}

    if($serial) {
      $posted_data['_pdf_serial'] = $serial;
    }

  }

  return $posted_data;

}

Hi, i could only find these 2 tables:

icwp_wpsf_scans
icwp_wpsf_scanitems

Anyway, deleting these two fixed it!

I cannot at the moment because it’s either locally on my machine or behind the company’s VPN. I’ll see next days if I can mirror it somewhere for you.

So I don’t know why I was getting a double [‘ads’][‘ads’] option array before, but it may be because of I’ve switched between new/old UI and this broke something.

At the end it seems that the issue regards $quads_options[‘ads’] array which (for unknown reasons to me) still makes use of old the ‘quad_ads_old_ids’.

Since $quads_options is a global, I thought I could try to correct this by hooking to some filter or action running just before template functions and I’ve found that ‘quads_has_ad’ could be a match.

So he’re a quick fix:

/*
* WP Quads temp fix
*/

// So we hook within 'quads_has_ads' filter because it runs before template functions,
//  This way we shouldn't break anything relying on old style ids
add_filter('quads_has_ad', 'wpquad_custom_banners_temp_fix', 10, 2);

function wpquad_custom_banners_temp_fix($result, $location) {

  // Here I'm just recalling my array of custom positions
  global $banner_positions;

  $locations = array();

  // Which has several info within, so we just take what we need
  foreach($banner_positions as $hook => $position) {
    $locations[] = $position['location'];
  }

  // checking if we're in a custom position
  if(!in_array($location, $locations)) return $result;

  // Get our settings
  global $quads_options;

  if(!isset($quads_options['ads'])) return $result;

  $ads = array();

  // Now we overwrite $quad_options['ads'] using the correct ids
  foreach($quads_options['ads'] as $old_key => $data) {
    $ads[$data['ad_id']] = $data;
  }

  // That's it!
  $quads_options['ads'] = $ads;

  return $result;
}

However you guys should fix it anyway because it’s a huge issue.

I’ve later found another issue:
If two banners are set to show on the same position, only the most recent one (with higher post ID) is shown.

• This reply was modified 2 years, 10 months ago by frafor. Reason: Quick fix found
• This reply was modified 2 years, 10 months ago by frafor.

Hi @agengineering I’ve managed to fix the issue by not using the product attribute lookup table as mentioned here by @madmax4ever: https://www.ads-software.com/support/topic/filter-by-attribute-is-no-longer-working/#post-15458267

However, the discussion on the WC official gh repo seems to suggest that the standard WC filters widget works fine by just regenerating the table.

I haven’t checked that yet, however, if that’s the case, there could be an issue in YITH Ajax Product Filter plugin.

Link here: https://github.com/woocommerce/woocommerce/issues/32065

Not really an issue for now, as the E-commerce in question has only few products, but the attribute lookup table can be useful in the future, performance-wise.

@ihereira The solution proposed by @madmax4ever is in fact working now! I have left the checkbox in Woocommmerce > Settings > Products tab > Advanced checked during a previous attempt (maybe because I had too many tabs open ^_^)

• This reply was modified 3 years ago by frafor.

Hi Andrea, I’ve already mentioned the issue to the woocommerce team here: https://www.ads-software.com/support/topic/woocommerce-6-3-1-breaks-attribute-filters/#post-15466386

It seems to be related to the new attributes lookup tables introduced in 6.3

I didn’t have time to report the issue on github yet, will do

@daniyalahmedk that solution is only temporary – as rebuilding attribute table is. After few minutes the issue occurs again. Please fix it.

@askmagic as already noted, that fix is temporary and after few minutes the problem occurs again