Gantry

Hi,

I just replied to your topic in the RocketThemes forum. This page is a Whoops (https://github.com/filp/whoops) error page that helps us debug code issues. It doesn’t contain any sensitive data. Me and other RocketTheme employee weren’t able to replicate or confirm the possible XSS issue. Nevertheless I asked you in our forums if you could please provide us in a safe way your site address/ftp so I could check your files.

Thank you!
Jakub

• This reply was modified 7 years, 5 months ago by Gantry.
• This reply was modified 7 years, 5 months ago by Gantry.

Great! I’m glad you got it working ??

Hi,

I’m sorry to hear about your issue. Gantry 5.4.19 is a release which focuses on solving false positive ClamAV on main.js file. The fix was about admin portion of the js and basically required us to use unpacked version of file instead of the packed one. This shouldn’t affect your menus so I’m a little bit surprised.

Did you try cleaning all of the caches after updating? Gantry 5 cache? Any other cache or minify plugin that your site uses?

I have checked your site and one of the minification plugins can cause the issues as the page structure is wrong ie. the first tag of the source code is head and doctype and other tags that should be first are later.

Please check these screenshots :

https://monosnap.com/file/sX6926lwcWSB951UspbnLzuVStcQ3N.png
https://monosnap.com/file/hlck8A7hCLSwjMUMTidlpAJktkO91Z.png

Do you have a copy of your site somewhere locally so you can experiment on it?

It has already been released.

Ok, thank you.

Here’s the snapshot of RokSprocket that removes usage of MooTools on the Page/Post edit screens. Please make a backup and test if it’s working fine for you.

https://we.tl/fziCuuCbf6

Hi,

Sorry for late reply. Well we won’t be able to solve it the way we should because like I mentioned it would require rewriting tons of MooTools code.

However I just removed MooTools and (not fully working) QTags (text editor mode) RokSprocket button from the post/page edit screen. This allows me to not load MooTools on that page which fixes the issue with YOAST.

MooTools still is required both by Gantry 4 and RokSprocket in the Widgets page, where YOAST loads its scripts too. So until you use the G4 Gizmo I mentioned previously, you still gonna see JS error there. I’m not sure why YOAST loads its JS on every admin page but as I stated before – it’s not a very good idea.

If you guys are interested I can send you a snapshot build of RokSprocket so you could test it. I’ve also passed it to our mods for internal testing.

Thanks

<another mistake>

• This reply was modified 7 years, 6 months ago by Gantry.

We use MooTools in our theme admin screen, widgets page (overrides dropdown, gantry divider etc.) and post/page edit screens (but only if you use the RokSprocket or RokGallery – shortcode generator). The only compromise I can see right now without rewriting whole JS is to disable the RokSprocket and RokGallery shortcodes generator in the Post/Page edit screens if YOAST gets detected. That way we wouldn’t have to load MooTools in that screen and YOAST should work fine there.

• This reply was modified 7 years, 6 months ago by Gantry.

Yes, I’m aware of that and that it’s a workaround for the current situation. This was to fix YOAST loading its JS scripts everywhere in admin which btw. isn’t a very good design decision. There’s no point of loading its JS scripts on pages that don’t actually use it.

To fix this issue completely we would have to rewrite a huge amount of our JS code. This isn’t something that can be handled by changing MooTools version or disabling compatibility layer in it.

I assume that the issue that’s hurting you most is the Post/Page edit screens where the YOAST controls don’t work right? And you have RokSprocket/RokGallery installed too?

• This reply was modified 7 years, 6 months ago by Gantry.

<mistake>

Ok, so the update has been released. If you update the Gantry 4 to 4.1.14 it should automatically fix the Theme Options page.

If you update only framework you’ll notice that a bug still exists on the Widgets page, where there is still JS conflict and the dropdown for overrides won’t work.

HOWEVER I’ve implemented a mechanism to enable/disable YOAST JS on the Widgets page whenever you need it.

To be able to use it, you need a toggle to enable it to be placed in your theme. We will update all our G4 themes to have it, but until this happens – here are the steps to add it by yourself.

1. Edit templateDetails.xml in /wp-content/themes/<your-theme>/
2. Add the code you can find below to the end of the “Gizmos” section of the templateDetails.xml file

   <fields name="yoastwidgets" type="chain" label="Disable YOAST JS" description="Disables YOAST scripts on Widgets page in order to make the page fully working. This affects ONLY Widgets admin page.">
       <field name="enabled" type="toggle" default="0" label="ENABLED" enabler="true" />
       <field name="priority" type="hidden" default="5"/>
   </fields>

3. Go to Theme Options > Gizmos and locate your new toggle. Enabling the toggle prevents loading of YOAST JS on the Widgets page, so you can control it easily.

Thanks for your patience.

• This reply was modified 7 years, 6 months ago by Gantry.
• This reply was modified 7 years, 6 months ago by Gantry.

I just pushed our dev build for internal testing. If the fix will get confirmed – we will release update shortly.

Hi Marcel,

I’m sorry for late reply but for some reason I haven’t received any notifications about your topic. Do you still need a support with that error?

Thank you,
Jakub

Allright, here is the code that I promised ?? Firstly you have to copy the wp-content/plugins/gantry5/engines/wordpress/nucleus/particles/contentarray.html.twig to the wp-content/themes/g5_helium/custom/particles/

Next step is to edit that TWIG file and replace this code :

   {# Query Posts #}
    {% set query_parameters = {
        'cat': filter.categories|replace(' ', ','),
        'posts_per_page': limit.total|default('-1'),
        'offset': limit.start|default('0'),
        'orderby': sort.orderby,
        'order': sort.ordering,
        'ignore_sticky_posts': sticky_posts
    } %}

with this :

   {# Query Posts #}
    {% set current_post = [wordpress.call('Timber::get_post').ID] %}
    {% set query_parameters = {
        'cat': filter.categories|replace(' ', ','),
        'posts_per_page': limit.total|default('-1'),
        'offset': limit.start|default('0'),
        'orderby': sort.orderby,
        'order': sort.ordering,
        'ignore_sticky_posts': sticky_posts,
        'post__not_in': current_post
    } %}

This should ignore the current post.

• This reply was modified 7 years, 9 months ago by Gantry.