geonolis

Hello!

I was expecting that the three-argument-version of class-wc-product-data-store-cpt.php was going to be the prevailing version of the hook.

My woocommerce e-shop will crash with the two-arguments-version, as my custom plugin needs the 3rd argument of the hook.

I have created a pull request https://github.com/woocommerce/woocommerce/pull/51345 to add back the 3rd argument.

Please support.

Thank you @omarfpg

First, to confirm, is this causing any issues on your website? If so, can you share more details about it?

It doesn’t cause any issue. I was looking for documentation of the hook woocommerce_update_product , and I found the inconsistency. I usually browse https://woocommerce.github.io/code-reference/index.html for reference, searching for hooks etc. Now I see that what I read there doesn’t correspond to my actual installation.

Have you checked if the discrepancy persists while having only WooCommerce active and no other plugin? The reason I’m asking is because this might be caused by a conflict.

I have deactivated all other plugins. The discrepancy remains. The same issue is found both at our production and developing installation.

The file in discussion class-wc-product-data-store-cpt.php found at https://woocommerce.github.io/code-reference/files/woocommerce-includes-data-stores-class-wc-product-data-store-cpt.html has 2168 lines while my installation file has 2297 lines. Is it normal?

We are talking about the same version of the same file. According to the first lines, it is @version 3.0.0 :

<?php
/**
 * WC_Product_Data_Store_CPT class file.
 *
 * @package WooCommerce\Classes
 */

use Automattic\Jetpack\Constants;
use Automattic\WooCommerce\Internal\DownloadPermissionsAdjuster;
use Automattic\WooCommerce\Utilities\NumberUtil;

if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * WC Product Data Store: Stored in CPT.
 *
 * @version  3.0.0
 */

Thank you.

Hello,

Thank you @carolm29 for your time.

The same problem appears to all variations.

Here is our set up:

https://snipboard.io/34Mpuf.jpg

https://snipboard.io/Oh6LsK.jpg

(this one is in stock).

https://snipboard.io/dirFfZ.jpg

We create and modify all products using WP All Import plugin ( https://www.ads-software.com/plugins/wp-all-import/ ). I have just created a dummy variable product via the default WooCommerce interface, with color variations, and the same problem appeared: https://www.odosermou.gr/shop/fdgffg/

Fatal error logs under WooCommerce > Status > Logs:

In the last 30 days, there are 7 “out of memory” errors like this one:

2024-05-08T17:08:44+00:00 Κρ?σιμο Allowed memory size of 536870912 bytes exhausted (tried to allocate 1310720 bytes)  
Πρ?σθετο συγκε?μενο
{
    "error": {
        "type": 1,
        "file": "\/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-object-cache.php",
        "line": 319
    },
    "backtrace": [
        {
            "file": "\/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/includes\/class-woocommerce.php",
            "line": 377,
            "function": "critical",
            "class": "WC_Logger",
            "type": "->"
        },
        {
            "function": "log_errors",
            "class": "WooCommerce",
            "type": "->"
        }
    ]
}

And 2 more different errors, as below:

2024-04-12T11:36:07+00:00 Κρ?σιμο Uncaught InvalidArgumentException: Μη αναγνωρισμ?νη εν?ργεια 6872174 in /var/www/vhosts/gipapamanolis.gr/odosermou.gr/wp-content/plugins/woocommerce/packages/action-scheduler/classes/data-stores/ActionScheduler_DBStore.php:1085  
Πρ?σθετο συγκε?μενο
{
    "error": {
        "type": 1,
        "file": "\/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/packages\/action-scheduler\/classes\/data-stores\/ActionScheduler_DBStore.php",
        "line": 1085
    },
    "backtrace": [
        "",
        "#0 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/packages\/action-scheduler\/classes\/ActionScheduler_QueueCleaner.php(202): ActionScheduler_DBStore->mark_failure('6872174')",
        "#1 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/packages\/action-scheduler\/classes\/ActionScheduler_QueueCleaner.php(216): ActionScheduler_QueueCleaner->mark_failures(300)",
        "#2 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/packages\/action-scheduler\/classes\/abstracts\/ActionScheduler_Abstract_QueueRunner.php(229): ActionScheduler_QueueCleaner->clean(300)",
        "#3 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/packages\/action-scheduler\/classes\/ActionScheduler_QueueRunner.php(133): ActionScheduler_Abstract_QueueRunner->run_cleanup()",
        "#4 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(324): ActionScheduler_QueueRunner->run('Async Request')",
        "#5 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(348): WP_Hook->apply_filters('', Array)",
        "#6 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/plugin.php(517): WP_Hook->do_action(Array)",
        "#7 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/packages\/action-scheduler\/classes\/ActionScheduler_AsyncRequest_QueueRunner.php(52): do_action('action_schedule...', 'Async Request')",
        "#8 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/woocommerce\/includes\/libraries\/wp-async-request.php(147): ActionScheduler_AsyncRequest_QueueRunner->handle()",
        "#9 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(324): WP_Async_Request->maybe_handle('')",
        "#10 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(348): WP_Hook->apply_filters('', Array)",
        "#11 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/plugin.php(517): WP_Hook->do_action(Array)",
        "#12 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-admin\/admin-ajax.php(207): do_action('wp_ajax_nopriv_...')",
        "#13 {main}",
        "thrown"
    ]
}

and:

2024-04-18T19:13:45+00:00 Κρ?σιμο Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, null given in /var/www/vhosts/gipapamanolis.gr/odosermou.gr/wp-content/plugins/advanced-local-pickup-for-woocommerce/woo-advanced-local-pickup.php:217  
Πρ?σθετο συγκε?μενο
{
    "error": {
        "type": 1,
        "file": "\/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/advanced-local-pickup-for-woocommerce\/woo-advanced-local-pickup.php",
        "line": 217
    },
    "backtrace": [
        "",
        "#0 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/plugins\/advanced-local-pickup-for-woocommerce\/woo-advanced-local-pickup.php(217): in_array('advanced-local-...', NULL)",
        "#1 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(324): Woocommerce_Local_Pickup->alp_plugin_update_hook(Object(Plugin_Upgrader), Array)",
        "#2 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)",
        "#3 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/plugin.php(517): WP_Hook->do_action(Array)",
        "#4 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-admin\/includes\/class-wp-upgrader.php(961): do_action('upgrader_proces...', Object(Plugin_Upgrader), Array)",
        "#5 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-admin\/includes\/class-plugin-upgrader.php(224): WP_Upgrader->run(Array)",
        "#6 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/themes\/woodmart\/inc\/integrations\/tgm-plugin-activation.php(889): Plugin_Upgrader->upgrade('js_composer\/js_...')",
        "#7 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-content\/themes\/woodmart\/inc\/integrations\/tgm-plugin-activation.php(743): TGM_Plugin_Activation->do_plugin_install()",
        "#8 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(324): TGM_Plugin_Activation->install_plugins_page('')",
        "#9 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/class-wp-hook.php(348): WP_Hook->apply_filters('', Array)",
        "#10 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-includes\/plugin.php(517): WP_Hook->do_action(Array)",
        "#11 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-admin\/admin.php(259): do_action('appearance_page...')",
        "#12 \/var\/www\/vhosts\/gipapamanolis.gr\/odosermou.gr\/wp-admin\/themes.php(10): require_once('\/var\/www\/vhosts...')",
        "#13 {main}",
        "thrown"
    ]
}

Thank you.

• This reply was modified 6 months, 2 weeks ago by geonolis.

UPDATE:
I installed the Paypal Payments pre-release version 2.0.1-rc1 from https://github.com/woocommerce/woocommerce-paypal-payments/releases/tag/2.0.1-rc1 and the errors stopped appearing.
It seems ok for the moment!

Hello,
Problem solved by commenting out a line of code at:
woo-product-feed-pro/classes/class-get-products.php
line 3206 (version 8.7):

// For these channels parent products are allowed
$allowed_channel_parents = array(
// “skroutz”, // comment out to remove parent product
“google_dsa”,
“google_product_review”,
);

Of course, whenever you update the plugin the above change may be lost.

Geonolis

Hello,
It seems the thread has been forgotten.
If Skroutz policy about variable products is not so clear, it would be nice to have an option to keep parents of variable products or not.
Could you consider it?
At the moment, we have to deal with dozens of Skroutz warnings about unnecessary parent products in our XML.

• This reply was modified 4 years, 3 months ago by geonolis.

Here is a screenshot from our skroutz dashboard:
https://imgshare.io/image/NpUqvy
I translate: “For every different colour/design that the product is available you have to submit different product records.” I have already sumbmitted the variable products, this error message is about the parent product that is not needed by skroutz.

Here is a link to skroutz XML documentarion:
https://developer.skroutz.gr/feedspec/#color
“In case multiple colors for a given model exist, they should be submitted as different products with separate Unique IDs.”

What you describe at https://adtribes.io/creating-woocommerce-product-feed-skroutz/ is true only in the case of size variations. See the different documentation in this case: https://developer.skroutz.gr/feedspec/#size

I think it is clear.
Thank you.

• This reply was modified 4 years, 6 months ago by geonolis.

Hello Dotstore,
We confirm that we have version 1.5.3 installed as screenshot:
https://imgshare.io/image/4jWEZ
The problem persists and useless attachement tab headings are created every time a product is updated with no attachments ever: https://www.odosermou.gr/shop/l-o-l-surprise-zoakia-biggie-pet/
Thank you for the nice plugin.

• This reply was modified 4 years, 7 months ago by geonolis.