globaltimoto

Look forward to your update.

Does that mean your packaged themes are a different version of themeroller ?

Thanks kavin

So it must be that I have not got the Path and URL as it should be.

Since the wp install is at the root I used:

path
/wp-content/themes/mytheme/css/wp-ui/

url
/wp-content/themes/mytheme/css/wp-ui/

Should I be doing this different ?

Surely not like this ? :

url
https://mydomain.com/wp-content/themes/mytheme/css/wp-ui/

I thought so, pesky devs, thank you for the confirmation.

Thank you for the detailed explanation and for considering my insignificance. ??

Not sure I understand what to do there.

Is there a reason why the plugin needs to add the leading whitespace in the first place ?

Cool, I look forward your update.

The first solution I found was terrible.

This one was much better and less invasive to the wp core
https://wordpress.stackexchange.com/a/70260/21090

function wpex_clean_shortcodes($content){
$array = array (
    '<p>[' => '[',
    ']</p>' => ']',
    ']<br />' => ']'
);
$content = strtr($content, $array);
return $content;
}
add_filter('the_content', 'wpex_clean_shortcodes');

Basicaly removes any <p> and <br /> that wrap shortcodes

Now I can switch between Visual and Text editor without pain.

Hello kavingray

Thank you for the response.

I hope that I showed in my examples that I followed your guidelines.

But this method is highly susceptible to user error and the issue always remained when using the Visual Editor (VE) no matter how careful, because of the first line break after [wptabcontent]

and you can’t ask people not to put line breaks in-between [wptabcontent][/wptabcontent]

It’s also difficult to ask users not to use the VE.

So that’s why I changed the wp filter order so that this became less of a concern.

I just hope that changing the filter order like that doesn’t cause other issues elsewhere.

As I understand it devs and users alike have been complaining about the mishaps that happen between Visual and Text editor for years.

This is just another instance I suppose.

I tried many given solutions but finally arrived at this:

//move wpautop filter to AFTER shortcode is processed
remove_filter( 'the_content', 'wpautop' );
add_filter( 'the_content', 'wpautop' , 99);
add_filter( 'the_content', 'shortcode_unautop', 100);

which was added to functions.php

and additionally the first line of text after the first [wptabcontent] needed to be an explicit tag placed in the editor such as <h4> otherwise that first line of text would still be preceeded by an orphan </p>

I just wonder if this is an issue with wp core not processing shortcodes in the right order or if it is something else ?

I have tried the same with 2 more editors Ultimate TinyMCE and CKeditor, but with the same outcome.

What I notice is that each time the post is saved via a visual editor wp attempts to wrap the first line of shortcodes with a p tag:

<p>[wptabs mode="horizontal"][wptabtitle]Test[/wptabtitle][wptabcontent]</p>

but the resulting browser source omits the opening p tag:

<div id="wp-tabs-1" class="wp-tabs wpui-light wpui-styles"><h3 class="wp-tab-title">Test</h3><div class="wp-tab-content"><div class="wp-tab-content-wrapper"></p>

of course really we don’t want the shortcodes to be wrapped in p anyway.

Hi John

Thank you, that works.

I can now edit the order in the admin faq listing and do this:

[faq group=”name” orderby=”menu_order”]

Which appears to give me the expected order.

Would be nice to now sort by menu_order in the admin faq listing.

Perhaps I should clarify.

As far as I can see, without being able to edit an order field for each faq question it is not possible to create an arbitrary menu order independent of date, name etc.

Currently the only way I can see of taking control of the order is by adding a number at the beginning of each faq question eg 01, 02, 03 etc.

Is that true, or am I missing something ?

Actually, I was wrong the difference in not in the version of PHP.

I was running one version with display_errors = on

So it is possible to see the error being generated.

Would be nice to know what is causing the error and how to fix it.

Turns out that if you switch from PHP5.3 to PHP5.4 the error on line 295 occurs.

@50 Seconds North

I experienced a similar error:

Warning: Illegal string offset ‘orderby’ in domain.com/wp-content/plugins/custom-taxonomy-sort/custom-taxonomy-sort.php on line 295

Commenting out the suggested lines 328-331 does not help here.

Is this a related issue ?

wordpress version: 3.5.1
custom-taxonomy-sort version 1.1.5