Jonas

Great, thank you for your consideration.

In the case of Google Adsense it looks like they actually do not allow their ads to be opened in new windows regardless of the methodology used, see: https://support.google.com/adsense/answer/1354740?hl=en

So for them it may be best to just add a FAQ to your plugin with a note on this, so that users can be made aware of it and set up their own exclusion.

But for Google Analytics click tracking and such, some additional functionality would be great.

Thank you also for your work on this plugin!

Great, thank you.

Nevermind, looks like you got on top of that.

Hi Bj?rn

I think I found another issue, not sure if its related to this latest code push? See: https://app-6052b515c1ac180a94120f70.closte.com/picture-test-2/ image does not display when WebP Express is activated.

Looks like it references a WebP file that it doesn’t actually create?

Thanks Bj?rn

I checked on the sandbox site and another production site with a bit more complex Picture markup and WebP Express is now in both cases skipping img tags in picture tags. So that now works, which is great.

And yes, it will of course be amazing if you can take it a step further so it adds the necessary source tags for WebP also. I subscribed to that github issue and look forward to testing and seeing that functionality in action once you’ve had a chance to develop and roll it out.

Thanks again for your assistance and all the hard work, it is very much appreciated!

Hi Bj?rn

Thank you very much for taking a look at this.

I set up another test case on a sandbox site and am seeing the same issue, see: https://app-6052b515c1ac180a94120f70.closte.com/picture-test/

The site uses the latest version of WebP Express.

I’ll email you directly to give you backend access to the site, then you can take a closer look.

Thank you all. Our dev managed to get this working, so am marking this as resolved.

Hi @maybellyne

OK, I have set all products to be shown in search results in the settings.

And our hooks set the correct meta robots directives at the product level. I can see on the front-end that we have set the robots for some products to ‘index’ and ‘noindex’ for others.

But the sitemap now still contains all of the products which have “noindex” meta robots directives. I cleared all caches and deactivated and reactivated the sitemap functionality in Yoast and the problem remains.

Our developer also tried using your wpseo_exclude_from_sitemap_by_post_ids hook but says that he can’t get that hook to work at all. I’ve seen several reports by other people online that they could not get that hook to work either.

You can see our code here: https://collabedit.com/9b7sj (enter any name)

Is there something that we are missing?

• This reply was modified 3 years, 4 months ago by Jonas.

Thanks @florianbrinkmann

That would be amazing if you got it to work.

If you ever do find time to work on it and want some assistance with testing and getting feedback then give me a shout. I can deploy across different client dev sites and evaluate the results. I’ve on-and-off been consulting with devs working on custom theme development projects to ensure that markup is correctly implemented, so have a good sense of what to look out for.

Best regards,
Jonas

OK, thanks for the update

Hi @zorem

Thank you, I have synced and switched over but the issue remains. As per my last comment the “custom_tracking_link”=>”” field is seemingly still empty because re:amaze is still using its fallback link.

It retrieves the correct provider and the correct tracking code, but not the tracking link.

Can you check if your plugin is in fact populating the correct tracking link for the WooC Rest API?

@zorem HHBT776453

Please also note that I spoke to Re:Amaze support and they said that https://t.17track.net is a link that they use as a fallback when there isn’t a tracking url provided.

They say they just pull in data from WooC and that they took a look and can see that the custom_tracking_link field is empty.

So they for example got this payload:

{“id”=>4190906, “key”=>”_wc_shipment_tracking_items”, “value”=>[{“tracking_provider”=>”cp-ram-couriers”, “custom_tracking_provider”=>””, “custom_tracking_link”=>””, “tracking_number”=>”HHBT776453”, “tracking_product_code”=>””, “date_shipped”=>”1620345600”, “products_list”=>””, “status_shipped”=>”1”, “tracking_id”=>”dfe4a77087583b284fda794c75eebc8b”}]}

Is the plugin not pushing the custom tracking link through?

Hi @zorem OK will do.

We use “RAM Couriers” who are one of the big South African courier companies.

Tracking link format is: https://www.ram.co.za/Track/%number%

@wpclever Thank you

• This reply was modified 3 years, 7 months ago by Jonas.

Hi @miemie

The ‘Exclude unpurchasable’ setting is not suitable if we want to only sell the composite when all component products are available. We are not trying to force the composite back to ‘in stock’.

And hiding the alert is not good for UX because it can actually explain to customers why the composite cannot currently be purchased.

Is there no function to change the alert text?