gparonitti
Forum Replies Created
-
Forum: Plugins
In reply to: [Maps Builder - Google Maps Plugin] New update errorI pulled a request to your git repo, I didn’t touch the function since, after a second thought, it seems to me that the logic is correct (imho the problem is linked to the fact that the checking is implemented against the registered array and not on the actual enqueued scripts), I just changed the way the gmaps api script is loaded. Anyway I writed all in the comment to the pull request.
Forum: Plugins
In reply to: [Maps Builder - Google Maps Plugin] New update errorNo there is no other plugin outputting Google Maps API.
I did some other debugging. It seems to me (but I usually don’t develop in php) that there is an unusual way to enqueue the google maps script.If I correctly understand why you use wp_print_scripts in combination with wp_footer action is to write the google maps scripts on the footer. But why not use $in_footer parameter of wp_register_script() function?
And
In check_for_multiple_google_maps_api_calls function, you check the google maps api call on the $registered_script and not on the enquequed script by parsing the global $wp_scripts->registered array. Since the scripts are registered the condition in the foreach is verified and thus the protected load_maps_api is set to false and the google maps script is not printed. Why don’t use wp_script_is function?
I’ll try to refactor this part of the code.
What seems quite puzzling is that this is happening only to me. Did peader solve the front-end issue?Forum: Plugins
In reply to: [Maps Builder - Google Maps Plugin] New update errorYes, it has.
I worked around the problem modifying /google-maps-builder/includes/class-gmb-scripts.php: I commented the load_maps_api variable checking on line 138. It is not a good solution, but just for now ??
It seems that the function check_for_multiple_google_maps_api_calls doesn’t work properly since it incorrectly sets load_maps_api to false (at least on my site).
Forum: Plugins
In reply to: [Maps Builder - Google Maps Plugin] New update errorThe problem with the backend is an incorrect naming of the marker-icons orange files: the plugin call for orange_markerX.png but the files are orange_MarkerX.png. Solved by changing /google-maps-builder/includes/admin/views/markers.php accordingly.
Now I’m getting to the front end problem…
Forum: Plugins
In reply to: [Maps Builder - Google Maps Plugin] New update errorYes the site is eyevis.it the front-end page is:
https://www.eyevis.it/contatti/thx.
Forum: Plugins
In reply to: [Maps Builder - Google Maps Plugin] New update errorHi, same issue here. I’ve tried to delete and reinstall your plugin but I get the same errors:
– front-end: no maps and “Reference Error: google is not defined” in
https://…/wp-content/plugins/google-maps-builder/assets/js/frontend/google-maps-builder.min.js
and
https://…/wp-content/plugins/google-maps-builder/includes/libraries/map-icons/js/map-icons.js– back-end:”NetworkError: 404 Not Found – https://…/wp-content/plugins/google-maps-builder/assets/img/default-icons/orange_markerI.png”