Bjoern
Forum Replies Created
-
Forum: Plugins
In reply to: [WP Performance Pack] Make Dynamic Image creation compatible to Webp ExpressI’ll give it a try, but it might take some time. I just had a quick look at WebP Express’ code. The way it creates/serves the WebP images could make it quite difficult to integrate it.
Which option for serving WebP images do you use?
Regenerate Thumbnail integration is fixed in version 2.2.2.
I have to say that, without “regenerating”, images won’t show in sizes different than the uploaded one. It’s an expected behavior, am I right?
No, image sizes should always get created. The difference is, they would get created on first access, not all on upload. Regenerate Thumbnails integration is only to delete existing intermediate images (they will be recreated when accessed as long as WPPP dynamic images is enabled). So it’s for “cleaning up” unneeded images.
If intermediate images aren’t showing, maybe the rewrite rules weren’t written correctly. Visit WordPress’ permalink settings to force saving rewrite rules.
I found the bug. You can expect an update by tomorrow.
I have to admit, that it’s been a while since I last tested the Regenerate Thumbnails integration, so it might be broken. I’ll have a look into it.
Thanks for the hint. Fixed this with 2.1.3.
Forum: Plugins
In reply to: [WP Performance Pack] Gettext seems not to work with 4.9.1If you see no translate methods in xdebug surely not all calls are displayed. I’m using webgrind and in webgrind you can select how many “percent of runtime” you want to display. Try to increase the “resolution” of the displayed calls. Somewhere there have to be calls to translate. that you don’t see any in default settings could be good (as in native gettext is being used) or bad (default wordpress translate calls are fast. it’s the loading of the mo files that takes way too much time).
You can add something line
exit
intowppp_load_textdomain_override
in \wp-performance-pack\modules\l10n_improvements\class.wppp_l10n_improvements_base.php. This function has to be called if WPPP uses mo_dynamic or native gettext.And I forgot to mention it in my first reply: WPPP uses wp-content/wppp/[…] since version 2.0, so it’s normal for the mo files to be saved there.
- This reply was modified 7 years, 3 months ago by Bjoern.
Forum: Plugins
In reply to: [WP Performance Pack] Gettext seems not to work with 4.9.1Gettext still works fine on my installations after the update to 4.9.1. You should find either WPPP_MO_dynamic->translate or WPPP_Natvie_Gettext->translate in your XDebug graph.
For debugging install the plugin Debug Bar (its linked in WPPP settings), enable WPPP debugging and check the debug infos.
Please also try to re-save WPPP settings. Maybe the settings got corrupted.
- This reply was modified 7 years, 3 months ago by Bjoern.
Forum: Plugins
In reply to: [WP Performance Pack] 404 Not FoundThe redirect to serve-dynamic-images.php doesn’t seem to work. WPPP would’t try to open the intermediate image. So this seems to be an NGINX error. Also WPPPs error output should be different if it doesn’t find the image.
The redirect should be the first of all redirects. It tests if the requested image exists and if it doesn’t, it redirects to WPPPs server-dynamic-images.php.
Forum: Plugins
In reply to: [WP Performance Pack] 404 Not FoundYou have to adjust the rewrite to your own blog:
RewriteRule ^(.*)-([0-9]+)x([0-9]+)?\.((?i)jpeg|jpg|png|gif) /blogname/wp-content/plugins/wp-performance-pack/modules/dynamic_images/serve-dynamic-images.php [QSA,L]
Replace (or delete) blogname according to your WordPress installation.
Forum: Plugins
In reply to: [WP Performance Pack] 404 Not FoundIt seems you are using NGINX. You have to integrate WPPPs rewrite rules into your NGINX configuration for dynamic images to work.
Here are the apache mod rewrite rules:
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^(.*)-([0-9]+)x([0-9]+)?\.((?i)jpeg|jpg|png|gif) /blogname/wp-content/plugins/wp-performance-pack/modules/dynamic_images/serve-dynamic-images.php [QSA,L]I don’t know much about NGINX configuration, so I can’t help you translating those rules to NGINX.
- This reply was modified 7 years, 8 months ago by Bjoern.
Forum: Plugins
In reply to: [Fast Translate] Its compatible with Focus Cache?Fast Translate uses WordPress’s Object Cache API, so any object cache using that API will be compatible. As focus cache uses the API it should work.
Forum: Plugins
In reply to: [WP Performance Pack] Add Support for PluginAs I said, the whitespace plugin uses the wrong methods in order to work with WPPP. Integrating an option to add whitespace to images directly using WPPP doesn’t fit what WPPP is about. But creating a plugin that adds whitespace to images an would work with WPPP shouldn’t be too complicated to write. I’ll take a look into that. Could test some WPPP features using it.
Forum: Plugins
In reply to: [WP Performance Pack] Add Support for PluginHi,
as the Whitespace Image Resize plugin doesn’t use WordPress’ ImageEditor class, it doesn’t work with WPPP out of the box.Adding whitespace to resized images is, in my opinion, the wrong way to fix your issue. Though that way all intermediate images have exactly the requested size, it increases image file sizes and could create future issues, e.g. when changing the background color of your site.
If those varying sizes make your site look ugly, it’s an issue with your theme, which should be fixable using a few lines of CSS or modifying some theme files.
Forum: Plugins
In reply to: [WP Performance Pack] Dynamik image serving not compatible with WP 4.4Should be fixed in 2.0.
Forum: Plugins
In reply to: [WP Performance Pack] Gettext test failednative-gettext-test.pot isn’t used for translation. native-gettext-test.mo is used and contains the actual translation. The .pot file shouldn’t even be included in the plugin and it will be removed with the next release. So that’s not the reason the test failed in your case.
Try to use alternative MO reader instead of native gettext.