Memo

Hey @bsfherman thanks for this.

Just want to know if you had the chance to review this with the team and see if there is a possible workaround for it?

I think that if you are including the wp-background-processing file in your plugin it will be good to have some kind of validation in the line I mentioned to avoid fatal errors that could break sites.

Just let me know if I can help you proposing a code to validate that and shows an admin message if there are plugins modifying that Constant with Non Integer values so it will be easy for you to identify possible unexpected behaviors in Starter Template. Also i can help with testing if necessary.

Thanks!

Hey @bsfherman

Thanks for reviewing, i was trying to identify the issue so i went to create other tests in different hosting providers, below are the results.

I tested it in 2 more hosting providers, and in all of them i’m seeing the error, for example:

1. GetFlywheel PHP 8.2
   The error i posted here, it is showing the error as soon as i activate the plugins.
   
2. WPEngine PHP 8.2
   Plugin activation and front end is working but if i go to the Tools -> SiteHealth (/wp-admin/site-health.php) it fires the error:
   PHP Fatal error: Uncaught TypeError: Unsupported operand types: string * int in /nas/content/live/startertempla4/wp-content/plugins/astra-sites/inc/lib/starter-templates-importer/importer/helpers/wp-background-process.php:442\nStack trace:\n#0 /nas/content/live/startertempla4/wp-includes/class-wp-hook.php(324): WP_Background_Process->schedule_cron_healthcheck(Array)\n#1 /nas/content/live/startertempla4/wp-includes/plugin.php(205): WP_Hook->apply_filters(Array, Array)\n#2 /nas/content/live/startertempla4/wp-includes/cron.php(1115): apply_filters(‘cron_schedules’, Array)\n#3 /nas/content/live/startertempla4/wp-admin/includes/class-wp-site-health.php(2931): wp_get_schedules()\n#4 /nas/content/live/startertempla4/wp-admin/includes/class-wp-site-health.php(1762): WP_Site_Health->wp_schedule_test_init()\n#5 /nas/content/live/startertempla4/wp-admin/includes/class-wp-site-health.php(194): WP_Site_Health->get_test_scheduled_events()\n#6 /nas/content/live/startertempla4/wp-admin/includes/class-wp-site-health.php(139): WP_Site_Health->perform_test(Array)\n#7 /nas/content/live/startertempla4/wp-includes/class-wp-hook.php(324): WP_Site_Health->enqueue_scripts(‘site-health.php’)\n#8 /nas/content/live/startertempla4/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array)\n#9 /nas/content/live/startertempla4/wp-includes/plugin.php(517): WP_Hook->do_action(Array)\n#10 /nas/content/live/startertempla4/wp-admin/admin-header.php(118): do_action(‘admin_enqueue_s…’, ‘site-health.php’)\n#11 /nas/content/live/startertempla4/wp-admin/site-health.php(96): require_once(‘/nas/content/li…’)\n#12 {main}\n thrown in /nas/content/live/startertempla4/wp-content/plugins/astra-sites/inc/lib/starter-templates-importer/importer/helpers/wp-background-process.php on line 442
   
3. In Pantheon using PHP 8.1 same issue as WP Engine, Plugin activation and front end is working but if i go to the Tools -> SiteHealth (/wp-admin/site-health.php) it fires the error:
   Fatal error: Uncaught TypeError: Unsupported operand types: string * int in /code/wp-content/plugins/astra-sites/inc/lib/starter-templates-importer/importer/helpers/wp-background-process.php:442 Stack trace: #0 /code/wp-includes/class-wp-hook.php(324): WP_Background_Process->schedule_cron_healthcheck(Array) #1 /code/wp-includes/plugin.php(205): WP_Hook->apply_filters(Array, Array) #2 /code/wp-includes/cron.php(1115): apply_filters(‘cron_schedules’, Array) #3 /code/wp-admin/includes/class-wp-site-health.php(2931): wp_get_schedules() #4 /code/wp-admin/includes/class-wp-site-health.php(1762): WP_Site_Health->wp_schedule_test_init() #5 /code/wp-admin/includes/class-wp-site-health.php(194): WP_Site_Health->get_test_scheduled_events() #6 /code/wp-admin/includes/class-wp-site-health.php(139): WP_Site_Health->perform_test(Array) #7 /code/wp-includes/class-wp-hook.php(324): WP_Site_Health->enqueue_scripts(‘site-health.php’) #8 /code/wp-includes/class-wp-hook.php(348): WP_Hook->apply_filters(NULL, Array) #9 /code/wp-includes/plugin.php(517): WP_Hook->do_action(Array) #10 /code/wp-admin/admin-header.php(118): do_action(‘admin_enqueue_s…’, ‘site-health.php’) #11 /code/wp-admin/site-health.php(96): require_once(‘/code/wp-admin/…’) #12 {main} thrown in /code/wp-content/plugins/astra-sites/inc/lib/starter-templates-importer/importer/helpers/wp-background-process.php on line 442

So, as you can see it is failing in 3 different hosting providers.

It is not a server (hosting) issue, not sure why zipWP is not showing that error, but it is not an error in only 1 hosting.

I know that maybe this is not a priority because the issue is only when you have GhostKit active.

But if you can take a look at that i will thank you because I need to go and apply a workaround every time a new update is available in Starter Templates plugin.

In case it helps, this is what i’m doing in the plugin code:

I’m adding this validation:
if( is_numeric( $interval ) ) {

Before this line:

// Adds every 5 minutes to the existing schedules. $schedules[ $this->identifier . '_cron_interval' ] = array( 'interval' => MINUTE_IN_SECONDS * $interval, /* translators: %d are the minutes. */ 'display' => sprintf( __( 'Every %d Minutes', 'astra-sites' ), $interval ), );

Thanks

Hey @bsfherman

As I saw in your video the site is working in PHP 8.2 like in my test, so, i was looking for possible differences and i found that after adding define('DISABLE_WP_CRON', true); to my wp-config file, the error is not displayed anymore. So i think that zipwp is creating environments with WP Cron disabled.

Can you check if zipwp has CRONs enabled, if not, if they have a way to enable CRON? or if you can try in another environment tool where you have CRONs enabled?

Thanks!

Hey @bsfherman

You don’t see the issue because the zipwp tool creates the environment using PHP 7.4, my site is using PHP 8.2, and there is where i see the error.

I created a new site in my server using PHP 7.4 and it works. So, definitely the problem is in newer PHP versions.

Thanks Herman, looks like email notification was treat as spam for some reason. I watched the video and it is very weird that you don’t see the same issue.

I will check the environment and see if it could be related to the hosting configuration.

Hi @bsfherman ! Thanks for looking into this.

The steps to reproduce it are:
– Install a new WordPress site
– Install and activate Starter Templates plugin https://www.ads-software.com/plugins/astra-sites/
– Install and activate Ghostkit plugin https://www.ads-software.com/plugins/ghostkit/
– And you will see the fatal error
WARNING: child 49 said into stderr: “NOTICE: PHP message: PHP Fatal error: Uncaught TypeError: Unsupported operand types: string * int in /www/wp-content/plugins/astra-sites/inc/lib/starter-templates-importer/importer/helpers/wp-background-process.php:442”

I also tried the other way, installing and activating Ghoskit first and then Starter Templates and same error was displayed.

Thanks!
Guillermo

Oh ok, I will create a support ticket on Starter Templates plugin.

Thanks for the info!

I forget marking it as resolved.

@giuliopanda i tried to reproduce this again but webp images are not generating that name anymore. I will mark this as resolved.

Maybe a good option will be excluding or skipping webp images to convert them again, if you want to run the process and you have 1500 images where 1000 are webp and 500 are jpg or png you will need to wait for the 1500 images to be converted. Just an idea.

Thanks for this work

It was a JS error with captcha field rendered as undefined. We found the issue and added a field validation to avoid rendering the captcha field, but as our form has a captcha field as required we need that part of the code working.
Can you help us with this?

It is weird.
Please contact me here https://www.sitemavens.com/contact/ to continue by email.

Memo

Hi Luca, sure you can contact me by email.
Regarding the javascript loaded, do you follow this steps?
https://www.ads-software.com/plugins/maven-algolia/installation/

Since the script is not included if you didn’t complete all the settings info.

Memo

Douglas, i checked the site and it looks very interesting, i like it. btw your changes looks great in the results popup, we are planning to launch an update with the entire template customizable and other configurations, so i will let you know when it is ready.

Sorry for my delay in answering you, i didn’t get this notification in my email.

Cheers.

Hi Luca,
You can add custom posts type by code in the functions file, we are working in the interface to customize what post types you could index we hope to have it next week.
I could help you with the code if you need it now, but would be great if you can wait us to launch next version with this functionality included.

Ciao

Hi Luca,
By default the search input with name=”s” (this is used by default in wp) is replaced, do you know if your search input has a different name?

Btw, we are working in an improvement to make this configurable in the admin section.
We hope to have it during this week. I will let you know when it is available in case you want to customize it.

ciao