Insomnia88

public function info_slider($atts, $content = null) {
    $args = shortcode_atts( 
        array(
            'orientation' => null,
            'title' => null,
        ), 
        $atts
    );
    
    wp_enqueue_style('css-custom-app-info-slider', plugin_dir_url(__FILE__).'assets/css/info-slider.css');
    wp_enqueue_script('js-custom-app-info-slider', plugin_dir_url(__FILE__).'assets/js/info-slider.js', array( 'jquery' ), null, true );
    
    $info = '';
    $box = '<div class="titles">'.'<h3>'.$args['title'].'</h3><ul>';
    $slides = '<ul class="slides">';
    $btn = '<span class="btn"></span>';
	$box .= '</ul>'.do_shortcode($btn).'</div>';
	$slides .= '</ul>';
    $output = '<div class="info-slider">
    	<div class="wrap">
    		'.$slides.'
    		'.$box.'
    	</div>
    	<div class="text">'.$info.'</div>
    </div>';
	return $output;
}

I am doing this in a custom plugin. The class including the function is called when the plugins_loaded hook is called.

public function __construct() {
    add_action('plugins_loaded', [$this, 'init']);
}

UPDATE:
After reinstallation minifcation seems to work but there was also a missunderstanding from my part. I am using this plugin for quite some time and wasn’t aware of the FVM 3 features that requires me to manually list which files are defered or parsed at render blocking. When I list them it works.

• This reply was modified 2 years, 8 months ago by Insomnia88.
• This reply was modified 2 years, 8 months ago by Insomnia88.
• This reply was modified 2 years, 8 months ago by Insomnia88.

Yes, they are on the same domain. CSS and JS files, both are ignored. I enqeue them inside of shortcodes.

• This reply was modified 2 years, 8 months ago by Insomnia88.

Thanks for the reply. I was able to narrow it down and get rid of the index blocking stuff ??

UPDATE: The behavior is still not as expected after updating so I rolled back again. One thing I noticed it that you skip minified files. I would like to have an option for enabling/disabling it. The thing is that even though the files are already minified they are not merged together resulting in many single requests instead of 1 bigger one (which I would prefer).
Also some files are not processed at all and I also have a theory for that. They are enqeued like the rest – even in the same function BUT they are not located in the same directory. In my case they are “global scripts” that are located on the same server at a central spot and are shared across multiple directories. The earlier version of the plugin didn’t mind. It copied them to the local folder and merged them like the rest.

These are 2 big issues I noticed with the 3.x releases.

• This reply was modified 3 years, 6 months ago by Insomnia88.

It wouldn’t help to name the errors because they are individual to my projects.
I did read the HELP tab but this didn’t help.
Yeah, minification is disabled by default. I enabled it and didn’t defer the scripts (I am not using http2 server).
The problem still existed since the 3.x update.

However: I upgraded the plugin again on one of my sites and it’s suddenly not breaking everything. Now I would upgrade the other plugins again but I am kinda afraid that it will break again someday. I will mark this as resolved because I have the feeling that it was a setup specific issue for me and not the plugin in general.

I rolled back to version 2.8.9 as a workaround. It’s perfectly working there.

Okay caching maybe a bit bad phrased. I mean the compressing and merging of css and js files. So if I change something in a css file I need to clear it to see the changes (similar to caching). I am simply looking for a way to make that programmatically. The thing is that I have multiple sites that share some scripts and styles (like 3rd party stuff) and I don’t want to log into each page to click the buttons to delete everything. If there was a programmatical way to do it I could automate that.

@jamesosborne No, I havn’t changed it.

@reneesoffice I deactivated/removed and reinstalled it with this error before.

Maybe this is also some problem with my provider since I can use site kit without any problem on another server/provider.
But then again it’s weird because I had an application at this provider with a running google site kit. But I set it up back then in early stages. I bet when I disable it I am not able to reactivate it again since I can’t get through the setup.

• This reply was modified 4 years ago by Insomnia88.

Didn’t help. I used the form now and waiting for further information.

Thank you ??

I get the same error. They created some bugs since 3.0 and this is a recent one.

Also when trying to dublicate some global widgets I get this error:

{
  "fileName": "localhost/wp-content/plugins/elementor/assets/lib/backbone/backbone.marionette.min.js?ver=2.4.5",
  "lineNumber": 22,
  "name": "ViewDestroyedError",
  "message": "View (cid: \"view725\") has already been destroyed and cannot be used."
}

I also used the console to check the lazy loading

lazy loading work in the inspector by simply examining the Network tab

This is exactly what I was doing.

If you’re expecting images to “pop in” when you scroll to them, then that’s because you’re used to the old JS code not always working properly.

here is no “offset” involved. The images simply don’t load until you get to them.

If the images load when my viewport hit their position they will pop in. That’s why old js code lazy loaders – which worked properly in my cases – used an offset to start loading an image before it hits the viewport.

on a fairly normal setup

It’s a bit of a special case for me because I use a shortcode to load my images and therefore custom code

Nevermind. I don’t know what went wrong but I tried implement it again and now it works. Maybe I had some typo in my code or something. I will still use js lazy because of compatibility (50% of my users use safari and native loading is not supported there by default)

Thanks for the response but I guess you misundertood me. I am a web developer and use up-to-date stable releases of the most common browsers (firefox 79, chrome 84). I also used the console to check the lazy loading. On an example page with a document height of 7800px and a viewport height of 880px all images were loaded after page init. When I used blzay I configured it that images also didn’t “pop in” when they reach viewport but with an offset of 200px below/above viewport. Ofc they could pop in depending on the scrolling speed or image size but it checked out. In the native/wordpress case the offsset seems to be >7000px and I don’t imagine it’s that way (since that’s the difference in height and I don’t see any image loading after start scrolling). So my point still stands.
Since I am expecting that this behavior was tested multiple times before release and it’s a HTML standard it should work but in my case it doesn’t and I only know what I posted above.

Ah, thanks. That’s the only part I havn’t copied. I still wonder why it isn’t in the pinned rules since it seems to be important for you.

This is interesting because it isn’t mentioned in one single word in the “** PLEASE READ BEFORE YOU POST AN ISSUE **” topic pinned at top which I read previously ??
Before I posted my topic I have copied it and I see no change to my previous text. Can you tell me what you changed? I havn’t even written something about pro.