ivmartel

I just published v0.6.1 that includes a modernizr.js build as the one of dwv plus the ‘mq’ tests. I hope you like it!

I just published v0.6.1 of the plugin including the fix. I hope you like it!

Argh… Does it fail with the same error in the console window?

Thanks for sharing the theme. Unfortunately, the modernizer that is used in Avada does not include its build link. If it had, I could have found a set of common rules the would fit both the Avada theme and the DicomSupport plugin.

So the non optimal solution I can see would be to replace the modernizr.js file of the DicomSupport plugin (in the ext/modernizr folder) by one that includes all the browser check rules. Open the following link and press the build button to create one: modernizrfull

The error only happens on pages where the DicomSupport plugin is because the plugin registers its modernizr and overrides the one of the theme.

So it seems the one wanting modernizr is the Avada theme. Could you find modernizr.js in its code to confirm? And if so, could you share its header lines to know how it was built?

Thanks, I had a look at the plugin folder and could not find any reference to modernizr, it seems it’s not the culprit… You can delete the data from mega.

So, the next action would be to find who is guilty. One way would be to look at the generated html of the page that gives the error and find the references to modernizr. The one that is not of the dicom plugin should tell which plugin/theme needs it.

Modernizr is a browser feature test library that is usually manually built to fit the tests of your code. The RoyalSlider plugin seems to need different tests than those of the modernizr provided with the DICOM plugin. And it seems that mixing two modernizr.js files does not fix your problem.

Could you share the header of the modernizr.js provided with RoyalSlider, ie the first lines that should include the link to build the library (something that starts with ‘https://modernizr.com/download/?-‘)?

That way I could generate one that has both the tests needed by RoyalSlider and the DICOM plugin.

I found a free theme that uses modernizr. I managed to make it work with the dicom plugin by changing the reference to modernizr in the dicom plugin php file. Replace ‘modernizr’ with ‘dwv-modernizr’ in these two lines:
– DicomSupport.php#L178
– DicomSupport.php#L200
Can you tell me if this worked?

Ok, my mistake, the pixel values are not what I thought they were…

I created this issue to fix it: https://github.com/ivmartel/dwv/issues/435

The standard is clear: MONOCHROME1 minimum is white, MONOCHROME2 minimum is black (https://dicom.nema.org/dicom/2013/output/chtml/part03/sect_C.7.html#sect_C.7.6.3.1.2).

Now, viewer may or may not respect this… And since you are not the first one to ask, I am divided about respecting the standard or not!

So the problem is modernizr! One solution could be to change its name. I can generate a test plugin for you to try. You can find my email on github.

I got carried away, modernizr is probably not the reason for the error… The problem is that RoyalSlider is private, difficult to test it. Do you have a specific error message? Have you checked the browser console window? Could you share a test page?

I’m happy you like the new version!

About the slider error, the dicom support plugin does not load jquery so I do not think this could be the problem. What could be the problem is that it seems the slicer and dicom plugin depend on another js library called ‘modernizr’. I’ll check this out and keep you posted.

When you say inverted, you mean in colors or in position (left is right or top is bottom)?
For colors, the DICOM files have a field called ‘Photometric Interpretation’ that decides whether to invert or not the color scale. If its value is MONOCHROME1 the scale will be from white to black and if MONOCHROME2 it will be from black to white.

Good point, I’ll check if I can integrate a progress line as on the dwv demos.