jensg

WordPress checks www.ads-software.com to see if there is a new version. When you click “install”, it downloads the update (trunk from SVN, the whole plugin) as a zip, removes every file in the directory and replaces it by the extracted files.

What I could do is adding a filter that copies the files, before updating, into another folder and then placing them back. But that can create conflicts. How do I merge different PO’s if I have to copy them back and somebody made changes? How do I not overwrite my own update?

I have an idea for the future though. I could create a directory “previous_versions” and copy everything in there and when the installation is done you could copy it back from there. I haven’t looked at it to closely, it just an idea that comes to mind.

There is nothing I could have done to prevent this, this is standard behaviour (when you update a plugin). I have tested this plugin on 4 different server (3 different linux distro’s and 1 windows setup) setups and the plugin seems to work. I will mark this topic as resolved, because there is nothing I could have done.

I am sorry to hear this. WordPress deletes everything inside a plugin directory when it updates, this is standard behaviour, probably to avoid conflicts with old files (garbage). WordPress handles everything related to the update itself. When the update is complete, wordpress will try to activate the plugin, if there is something wrong with the plugin you wouldn’t be able to reactive it (and that’s all that can go wrong (or at least that I could do wrong), a plugin that is not able to reactivate when there is something wrong). I don’t know what exactly happened. Even when the update succeeded, the outcome would have been the same. WordPress would have automatically deleted everything. I found this out the same way you did, it really sucks, I have no control over it. Although I would love to include your translation.

Fixed it in 2.5.1 the errors you see are unreleated to Ultimate Blogroll, I just forgot to disable errors from being shown… The plugin made your website show all the errors that are happening in the background (this is handy when you are developing, you want to see if your plugin is causing any trouble). Should be fixed if you update to 2.5.1

Fixed in 2.5

The plugin is updated to version 2.5 I have removed all the @$_post’s it is fixed but I am working on a better fix with entities. I know it also occurs with the gui array but I can’t simply move that one out. I will do it in another version. Thanks for reporting

I thought you were talking about the values, but indeed the keys should have been strings.

Do you have any contact info? skype? mail? …?
Our communication will be much better, I really appreciate you taking your time for this.
I will add entity classes and move my business logic into there, that way the validation is always ensured.

Fixed in 2.4.5

Fixed in 2.4.5
Thanks

Sure, you are right, you should never surpress notices. I will fix this, I should start with writing unit tests. Thanks for taking your time and marking this, it is all legacy code, I know better now but I haven’t had any time to take a clear look at it as you do. Keep up the good work!

It is some sort of legacy code, I refactored it a couple of times. Could you elaborate more on what you mean?

Thanks I updated it, will commit it in 2.5

It was related to the fact that I required a file to be loaded only once, but your template already called it, so when it was called to be displayed and asked for the output of that file it was empty because it was already called.

Hi Syndrael thanks for the feedback, I will update the plugin.