Forum Replies Created

Viewing 11 replies - 1 through 11 (of 11 total)
  • Thread Starter jharries

    (@jharries)

    Hi @bcworkz,

    Thanks for coming up, but I tested and verified the problem with all plugins turned off and on the 2024 default theme. It’s not a theme or plugin issue.

    What happening here is that the setting in appearances/edit/blog is overriding all templates and even overrides a manual change in code view when editing a taxonomy in FSE.

    I can’t see that as correct since many users will want a different number of posts displayed depending on taxonomy.

    Sure we can override this using code as you suggest (thank you) but the whole idea of FSE is to make things easy for #nocode users, so I don’t think that’s the best answer.

    Thread Starter jharries

    (@jharries)

    Hi @bcworkz,

    Thanks for coming up with that. A bit beyond my coding pay grade, but I can probably fumble through.

    That said, what do think of the idea that this is really a bug that should be reported.

    My thinking is that the templates should have primacy over the setting in appearances/edit/blog?until a user overwrites a given template in FSE. That’s the case for most other variable and the case with Theme.JSON.

    Otherwise why even bother to have the perPage parameter in the query block HTML in a template.

    And there’s another aspect to this: Even if I change the perPage parameter in the code editor, it does not work.

    Put it all together and it seems to me that this is something that should be fixed in core?

    Anyone else have thought on that?

    Thread Starter jharries

    (@jharries)

    Hi @jordesign,

    Thanks for the interest. I think the reason you are not able to duplicate is your Safari version. I’m using 17.2.1. From the testing I have done, to duplicate we need latest version of Safari and being on Apple silicon Mac.

    Also, I don’t think it’s a local font issue given that I can see the return arrow in the para even when I can’t see it in the footnote return.

    One other thing that may help: I can duplicate this on my docker dev site in vanilla 2024, and in the theme I’m working on which uses some of the Theme.Json from 2024 (not child).

    But when I subsetted the Inter default body font and loaded that as woff2, using the load local font function of the Create Block Theme plugin, rather than the load Google font function, it works fine.

    Sorry I’m not enough of a developer to speculate on why this is, but hopefully it will clue someone with more knowledge in to the cause.

    Hope that’s helpful.

    • This reply was modified 1 year, 1 month ago by jharries.
    Thread Starter jharries

    (@jharries)

    Thanks for coming up. Yes, I have tested it on other computers. All the Apple Silicon Macs running Sonoma have the problem that I have access to, however an Intel Mac running Ventura does not. Both are running the same version of Safari.

    Also, keep in mind that this problem does not show with the 2023 theme, so clearly it’s an interaction between latest Mac and/or Sonoma and 2024 theme.

    Of course we could just shrug and blame Apple, but given the number of Macs out there and that theme 2023 works fine, it seems better for WP to fix it.

    One other clue that might help someone smarter than me to figure this out:

    If, using the inspector I turn off font-family: var(–wp–preset–font-family–body); So that it reverts to a system font, all is good.

    The body font is set to Inter, sans-serif which included that character, as proved because it shows in the body, even when it does not in the footnote, so that’s not the issue.

    Anyone have any ideas what’s different from theme 2023 to theme 2024 that’s causing this.

    Thread Starter jharries

    (@jharries)

    OK I found a work around on GitHub: https://github.com/WordPress/gutenberg/issues/40323

    @media only screen and (min-width : 768px) {
       figure.wp-block-image.alignleft {
    	  margin-left: calc( ( 100% - var(--wp--style--global--content-size)) / 2 );
     }
    
       figure.wp-block-image.alignright {
    	margin-right: calc( ( 100% - var(--wp--style--global--content-size)) / 2 );
     }
    }

    I class this as a work around, not a fix since I really think that it should be fixed in a future release of core since the way it is now images alined left or right float all the way to the viewport edge and are not constrained in anyway to content or wide width, which is idiosyncratic to the way everything else works and very difficult for #nocode users to understand.

    And yes, I understand that putting the images inside a group is a fix, but is not practical for users like me with thousands of existing posts that this problem breaks.

    Point being that this is, in my view and now we have 6.4 and 2024, one of the few barriers standing in the way of wide spread adoption of FSE particularly by #nocode users.

    Thread Starter jharries

    (@jharries)

    Hi Herry,

    Thanks for coming up, but that does not help. As I say my original ticket, like many long term WP users we have over 1500 posts so solutions that require editing at post level are not practical.

    The point being that this works fine in classic themes, and is broken in FSE themes, so I would suggest it needs fixing at the template or Theme.JSON level since it presents a barrier to the adoption of FSE for many loyal WP users.

    That said, in the mean time I would be grateful if anyone has any CSS and /or block filtering suggestions.

    • This reply was modified 1 year, 4 months ago by jharries.
    Thread Starter jharries

    (@jharries)

    Hi Robin,

    That fixed it, thanks.

    Sorry, I did not read your instructions carefully enough.

    Thanks for the very quick reply.

    I have the same problem: Error code:

    Fatal error: Cannot redeclare fifrf_fs() (previously declared in /usr/home/jharries/public_html/aac_wordpress/wp-content/plugins/featured-images-for-rss-feeds/featured_images_in_rss.php:26) in /usr/home/jharries/public_html/aac_wordpress/wp-content/plugins/featured-images-for-rss-feeds-premium/featured_images_in_rss.php on line 50

    Looks like there’s a bug in the premium download since there are at least two of us. Please advise.

    Thread Starter jharries

    (@jharries)

    Hi Ron,

    Will do. By the way, no violation of Pearson’s license in doing this. I quote from his download page terms:

    You may allow a third party to work on Thesis for you, but remember—you’re the one with the license, so if they mess with the software and screw it up, you are still responsible.

    Thanks again.

    John

    Thread Starter jharries

    (@jharries)

    Hi Ron,

    Thanks very much for doing that, but unfortunately it still does not display anything with thesis. I even verified that your recent code change, as shown on Github was indeed in the code I was using just to make sure I had not done anything dumb and used to old code. Also, used a new Private window in Safari to make sure that I was starting fresh.

    Any other ideas? As I said, happy to pay a reasonable fee for a fix.

    Thanks
    John

    Thread Starter jharries

    (@jharries)

    Hi Ronald,

    Bummer, but t hanks for responding so quickly, awsom support.

    Would you consider adding Thesis capability to the core plugin for a fee? Happy to pay a fair price for this.

    Thanks

Viewing 11 replies - 1 through 11 (of 11 total)