jhtjards

In my specific case it is is a WYSIWYG-Editor Field with:
Tabs: Visual & Text, Toolbar: Full, Show Button for Media Upload

And I’m using the Classic Editor.

Any chance we can get this working?

Looking forward to that! Still one of the most useful Plugins around!

I can confirm this is still broken.

Also, while adding the filter to https://github.com/epiphyt/embed-privacy/blob/main/inc/class-embed-privacy.php#L272
does help initially if you have an embed within an acf editor field, i’m experiencing the strange behaviour that the previously shown YT-preview image gets deleted after I save the post.

These were my steps:

• Have a post with an embed within an ACF WYSIWYG Editor
• Install Embed Privacy 1.6.5
• Enable Javascript detection and preview images
• View Post in frontend (Embed Layout broken and loading is not working, though YT Preview image is shown in Background!)
• add above mentioned filter in class-embed-privacy.php L272
• View Post again: Everything looks and works as it should
• Save/Update Post (no actual changes made)
• Preview image is gone (deleted from post_meta), so a black preview screen remains.

Hope this helps!

Thanks, but it’s only working if the content width is 750. Maybe better to check for the content_width global instead at:
https://plugins.trac.www.ads-software.com/browser/embed-privacy/tags/1.6.4/inc/class-embed-privacy.php?rev=2844844#L1910

I think it’s usually defined via the global $GLOBALS[‘content_width’], like here:
https://themes.trac.www.ads-software.com/browser/twentytwentyone/1.7/functions.php#L384

Maybe the preview image itself can be used via php’s getimagesize().
just a thought

Ok, it might be an older issue. I now looked a bit deeper and have closed in on this problem:

It’s only happening when using Classic Editor.
Embeds are not wrapped in a wp-block element here and line 101 in embed-privacy.css does not come into usage (position: absolute, w & h 100%, etc: https://plugins.trac.www.ads-software.com/browser/embed-privacy/trunk/assets/style/embed-privacy.css#L101 ).

This wouldn’t be a problem, but the aspect ratio values are totally off. They now describe a portrait format instead of the actual landscape format.
Maybe they are just in the wrong order? (should be [width] / [height]).

I’ve shared a link here on my dropbox (So I can keep it somewhat private):
https://www.dropbox.com/s/ozp1p878bkyd45m/embed-privacy-aspect-ratio-link.txt?dl=0

Thanks!

Oh, cool! Didn’t know that!

Yep, that worked perfectly. Thanks a lot!
Btw: I don’t see a reason why this line shouldn’t be included in the plugin as it restores the previous functionality.

Is there a quick way for me to add this via the themes functions.php?
ACF uses the filter “acf_the_content” maybe hook into that somehow?

Thanks Mikko!

This is the snippet I put into my functions.php, in case anyone’s interested:

//Dont log WP users in Relevanssi search log
add_filter( 'relevanssi_ok_to_log', 'rlv_block_wp_users', 10, 5 );
function rlv_block_wp_users( $ok, $query, $hits, $user_agent, $ip ) {
  if ( is_user_logged_in() ) {
    $ok = false;
  }
  return $ok;
}

Du k?nntest folgendes CSS einfügen

.embed-privacy-container.embed-youtube{
	aspect-ratio: 16/9;
}

.embed-privacy-container.embed-youtube iframe{
	width: 100%;
	height: 100%;
}

Hi Matt, wow that was quick, thanks a lot for pre release! I can positively confirm that it worked for me as expected.

I didn’t encounter any bugs.

Hi, it’s actually really easy to reproduce the reversed default order. I’ve made a screencast to show you how:
https://www.dropbox.com/s/zxgyw637u9cuf4f/realcustompostorder.mov