joel_birch

It certainly shouldn’t be doing that. My best guess is that you have invalid HTML on your site which may be confusing jQuery.

Thanks for the follow-up. I can also confirm that NoFollowr is still working with WP 3.8.1.

Hello,

I just tested it on WP 3.8.1 and it worked perfectly. Maybe you have some other issue at work?

Just so everyone knows, it’s best to email support at nofollowr dot com if you think there is an issue with the plugin, because if I don’t get email at that address I assume that no news is good news.

Joel.

I understand. Although, to clarify, I wasn’t asking for access to your site (I’d advise against that).

If you remove the plugin you will not have to manually alter any links as NoFollowr permanently alters them in the database.

Sorry I couldn’t be of more help. I really do want to figure out what is causing these reports.

If you’d like to zip up your theme and send it to me at support at nofollowr dot com, I’d be happy to see if I can reproduce and debug the issue. I’d probably need the plugins you are using, too. It’s a bit of an ask, I know, but I don’t see another way, beyond giving me (a stranger on the internet) access to your live site, which I wouldn’t ask anyone to do.

Hello,

Thanks for your feedback. I have tested NoFollowr v1.0.2 in WordPress v3.5.2 and with multiple versions of jQuery and I can’t reproduce this issue. I’d love to get to the bottom of it, but I guess I need more information so I can see the problem happening. I have tested the plugin with the Twenty Twelve theme that comes with WordPress and also some of my custom themes. Are you using a freely available theme that I can test? Is there anything else non-standard about your site? Which plugins are you using?

Thank you,
Joel.

Hey Kimberly,

I started this thread over here and would love your input. It’s regarding possibly creating a GitHub repo for wp-minify so we can all submit our patches.

??

I’d prefer not to be in charge of the repo, just because I can’t guarantee I’ll have time to stay on top of issues and pull requests. Would love for someone else to volunteer. I would definitely be able to send some pull requests, though.

Still nothing. In the meantime, does anyone know of the etiquette around putting someone else’s plugin up on GitHub?

@sireneweb a GitHub repo doesn’t exist yet. I’ve been waiting for @kellogg9 to chime in.

Not a bad first attempt. Obviously, please ignore the <code> tags around that function.

@jlcarneiro I haven’t been able to get anything like this working, unfortunately. The $this part of that array refers to the WP_Minify class instance, so we would need to be able to access that from the functions.php file. I notice at the bottom of wp-minify.php that it is stored as $wp-minify but I can’t seem access it from functions.php, even with the global keyword. This is what I was trying (and failing with):

<code>
function fix_wp_minify_footer() {
  global $wp_minify;
  if (!is_admin() && !is_feed() && !defined('XMLRPC_REQUEST')) {
    if (isset($wp_minify) && !(isset($_GET['wp-minify-off']) && $_GET['wp-minify-off'])) {
      remove_action('wp_footer', array($wp_minify, 'post_content'));
      add_action('wp_footer', array($wp_minify, 'post_content'), 20);
    }
  }
}
add_action('plugins_loaded', 'fix_wp_minify_footer');
</code>

I haven’t attempted to markup code blocks on this forum before, so I fully expect the above to look weird.

Hey Carol,

I’m really touched by your kind words. I’m sorry I was hard to track down – I’ll try harder!

Thanks again. It’s great to hear you have found NoFollowr fun to use ??

Joel.

Sorry, to summarise: clearly get_transient() is returning the wrong datatype.

What will happen if I set that first if clause to true until a real solution is in place? Caching won’t work? Twitter will block us? World will explode?

Ta.

I am now getting the “no tweets available” message and followed the problem to the tlc-transients.php file. On line 42 I changed the if statement to if ( true ) { and this seemed to fix the plugin (the tweets showed up, at least).

So then I wondered why the else path was not working and noticed that on line 55 there is an if statement:

if ( $data[0] !== 0 && $data[0] < time() )

…so clearly the plugin expects $data[0] to be a time of some sort. I did print_r() to see what $data was and it showed the following (will only put the start of it here for brevity):

a:2:{i:0;i:1360926814;i:1;a:7:{i:0;O:8:"stdClass":20:{s:10:"created_at";s:30:"Fri Feb 15 00:17:02 +0000 2013";s:2:"id";i:302209869153443840;s:6:"id_str";s:18:"302209869153443840";s:4:"text";s:136:"A scientist...[etc, actual tweet content here]...

…which does not seem to be what the plugin is expecting, even though it is not false, which would have sent the code down the working path of the above-mentioned if statement.

Aaron, I hope this helps you figure out what is going on. I appreciate it’s hard for you to debug a problem you can’t replicate. Please let me know if I can help you with it.

Cheers.