joncampbell

@trose1189,
no, we have just stuck to the older version of Woo for now.

To add some more context, in WooCommerce 8.2.2 this was not a problem, it is only since WooCommerce 8.3.x.

@erostad

A few years ago they changed the plugin so that the VALUE of select fields is set to the LABEL of the select fields. This will break the role field that is outputted by teams because the plugin filters those fields.

This change doesn’t just affect custom fields created by their plugin, but it breaks other fields created by WooCommerce itself or other plugins. It’s terrible. You may have to manually fix the file and use your own fork of the plugin if you want to have the two work nicely together.

Where they made the change:
https://plugins.trac.www.ads-software.com/changeset/2276797/woocommerce-checkout-manager/trunk/includes/view/frontend/class-wooccm-fields-filters.php

A few related threads:
https://www.ads-software.com/support/topic/error-in-class-wooccm-fields-filters-php/
https://www.ads-software.com/support/topic/incompatibility-with-other-plugins-8/

Hey @wppunk
They broke this a year and a half ago by changing the value of <option> elements to be the text label instead of the value:

https://plugins.trac.www.ads-software.com/changeset/2276797/woocommerce-checkout-manager/trunk/includes/view/frontend/class-wooccm-fields-filters.php

They don’t seem to care to fix it, even though it breaks <select> fields that are outside of Checkout Manager.

I gave up on trying to get them to fix it and changed my local copy of the plugin to work properly and then increased the version number so it doesn’t get updated to a broken version again.

The plugin has been updated multiple times but this very, very, clear error is still not fixed.

• This reply was modified 4 years, 5 months ago by joncampbell.

Likely related to this thread as well: https://www.ads-software.com/support/topic/error-in-class-wooccm-fields-filters-php/

Agreed, and for the sake of stability, maybe this plugin should not be messing with default WooCommerce field handling and only should apply to fields it generates.

@richaber It looks like the post titles is something we can fix in our content.
But the categories it seems like WordPress saves those to the database with the full html entity, instead of just the ampersand.

Maybe that is something that could be fixed in the plugin for everyone.

Cool cool cool.
My titles and terms have the html entities stored in the WordPress database.
I’ll just go have a good cry and then ask my client why we are doing that.

Even using the default instantsearch.php template it does it.
So post_title looks like this:
{{{ data._highlightResult.post_title.value }}}
and {{ data.post_title }} where it is used.

@cornel,
Any chance you can send me the fixed files?

I think it’s related to lines 9-11 in /order-export-and-more-for-woocommerce/js/main.js

Jquery is bugging out in the admin because of that event handler for clicks on .asd

I think I know what the problem is. The css is imported into style.css
Style.css in the theme actually imports 7 other css files.

For some reason the css file that is being autoptimized isn’t in the tags that run through

if ($this->isremovable($tag,$this->cssremovables)) {
}

that happens within the read() method of autoptimizeStyles.php

I output each $tag within the isremovable() method and the tag for desktop.css doesn’t seem to show up, but that file does get optimized anyway?

What am I missing?

We had to turn the plugin off because of the issues.
I am just testing it on my local.

It seems to ignore any of the theme css files I put in the exclude box.

Heres what I have in there right now:
admin-bar.min.css, dashicons.min.css, assets/css/desktop, mobile-landscape.css, tablet-portrait.css

But desktop.css, mobile-landscape.css, and tablet-portrait.css are all still being combined and optimized.

I have cleared the cache when saving and also manually on the specific page.
Tomorrow I may look and see if i can get any info out of the plugins filters that gives me more details about why the exclusion isn’t happening.