Jo Sprague

Hi Jules, thanks for letting me know! Yes, this plugin is on GitHub. Pull requests welcome! https://github.com/localjo/quotable-wp

It turns out that shipping translations with plugins is no longer recommended. I had to import my translations on https://translate.www.ads-software.com and then wait for them to be approved.

This is definitely not clearly answered by the docs. The most clear documentation I found was in the source code:

addFilter<any>(hookName: string, namespace: string, callback: (firstArg: any, ...rest: any[]) => any, priority?: number): void

Adds the hook to the appropriate hooks container.

@param hookName — Name of hook to add.
@param namespace — The unique namespace identifying the callback in the form vendor/plugin/function.
@param callback — Function to call when the hook is run.
@param priority — Priority of this hook.

Why it’s supposed to be in the form vendor/plugin/function is an unanswered question, but in agreement with @jnorell’s comment, it seems that it is a safe assumption that any string that’s not used by another plugin will work. But I guess it also has a double function as a unique identifier of the hook for the purpose of removal, but that feature doesn’t appear to be documented at all. In that case, you’d want a string that’s not only unique to your plugin, but also unique within your plugin. That answers why it should contain the plugin/function portions, but not what the vendor portion is.

Hi @joyously

Thanks! I’ll check some other plugins and see how they can do it. Do you know any examples of plugins that do it?

Hi @even-dawn ??

I took a loot at your page, and it looks like there is a plugin or theme that conflicts with Quotable. There is an element on your page with the class name “edgtf-wrapper” that is covering the Quotable toolbar. The solution is either to remove the CSS that sets the z-index of “edgtf-wrapper” to 1000, and set it to 0 instead, or add some CSS that makes the Quotable toolbar display above it. If you add the following CSS to your site, it should work;

#quotable-toolbar { z-index: 9000; }

You can add this CSS anywhere, by editing your theme’s CSS, directly in the plugin, or in a custom CSS plugin.

Thanks for reporting this. Good luck.

Hi! I’d love to add the ability to share quotes on Facebook, but I have not had time because I’ve been too busy with work. Feel free to fork the plugin on GitHub and add the ability to share on Facebook. I’m accepting pull requests! Unfortunately, it make be a year or more before I have enough free time to add this feature myself.

You’re welcome. ?? That’s a great question. Right now, the best way to do that is to use the Quotable settings in the post editor for individual posts. I haven’t added support for toggling Quotable by post type yet, but I’ll take note of the feature request for the next version. I’m a bit busy with other projects right now, so I can’t promise that I’ll get to this soon. In the meantime, if you want to try to add this functionality yourself, if you open a Pull Request on GitHub, I’d be happy to accept it. I think the relevant lines are here: https://github.com/localjo/quotable-wp/blob/master/quotable.php#L161-L254

I’ve got fat fingers today. I broke something else. v1.0.4 is fixed. I’ve installed it myself and confirmed. Sorry for the confusion.

I apologize for the typo. This will be fixed in v1.0.3 which will be published shortly.

Thanks for noticing that. I can’t believe no one else had noticed it yet! Fixed in v1.0.2. Please update!

I made a small update that should eliminate console errors in some cases. Please update to version 1.0.1, and let me know if that works.

As a side note, this plugin is designed to work with pages that contain a single blog post. The page in your screenshot looks like it’s a listing of blog posts. This plugin doesn’t do anything on blog post listings. You should only see it active on single blog post pages.

Thanks!

Hi shailendra01, it looks like there is a conflict with another plugin. I’m having trouble reproducing the problem but you could try a few things, and let me know what happens, and that will give me a better idea of what is going on. First, try disabling just the Quotable plugin, and check the console for errors. Let me know which errors you see then. Next, try re-enabling the Quotable plugin and disabling the “social warfare” plugin. Then let me know which errors you see. We’ll go from there and see if we can figure out this issue. ??

Ah, sounds great. I deactivated all other plugins, so it’s definitely an issue with Jetpack. I have a few theories on why it might not always show up. Anyway, I will open an issue, and a PR on GitHub. Thanks!

Using the other path works for us. I’m not sure if wp-content/uploads is the right default location for a settings file, as I mentioned above. You might want to consider making the default location wp-content/plugins/sucuri or something like that. It’s not a difficult issue for us to work around, but polluting the uploads directory, which is usually user-uploaded media files, with configuration and settings is probably a bad practice.