Jtree5757

Hey @sasiddiqui

I encountered this might be related, but if you have a custom permalink saved, then open the current post as a preview, then go back to the other tab where you’re editing the post and save it, the custom permalink will get deleted. Meaning it reverts to the default permalink/slug.

The issue is in class-custom-permalinks-form.php. Specifically this line:
add_action( 'delete_post', array( $this, 'delete_permalink' ), 10 );

When a preview is opened, wp creates a new post and the type is set to revision. The next time you save any updates, the revision gets deleted and the delete_permalink method gets called with the revision’s post id. Which makes sense so far. But wp actually converts any revision id to the real id whenever it deals with post meta with the use of this function https://developer.www.ads-software.com/reference/functions/wp_is_post_revision/!

I think you can just delete add_action( 'delete_post', array( $this, 'delete_permalink' ), 10 ); because wp already cleans up the meta table when a post gets deleted. I removed the action on one of my client’s sites and it’s working as expected now.

Hope that helps

@constantcontact To avoid conflicts, you should use php-scoper to rename your dependencies to something unique.

https://github.com/humbug/php-scoper
https://deliciousbrains.com/php-scoper-namespace-composer-depencies/
https://developer.yoast.com/blog/safely-using-php-dependencies-in-the-wordpress-ecosystem/

I’m having the same issue of some of my image sizes not showing up in the srcset. I’m using the same aspect ratio for all of my image sizes of 3:2. I have one set to 2400×1600 another at 1920×1280 another at 1200×800 etc. to some small thumbnails. All show but the 1920×1280. I’m not sure why. It shows up in the media manager select field as if I were going to insert it into a post.

Any ideas?

Hmmm. I was thinking of adding tap or touchstart to the JavaScript that’s in charge of triggering the pop up.

Is there an api or way to trigger the pop up with JavaScript?
If not that would be great to add it to a future update! Would allow for a lot more.

Great Thanks @danieliser

Just if anyone is curious or having trouble with themes not letting them deactivate “required” plugins, I installed “Plugin Organizer” located here: https://www.ads-software.com/plugins/plugin-organizer/

Then I enabled the setting to disable plugins on a per page basis. I then went to the page I wanted the popup and not rev slider and disabled rev slider.

This method is also a quick way to get your pages less bloated with all the plugins wordpress loads on every page by default. If you don’t need revslider or a plugin on a page then don’t make your users load it.

Actually I can’t deactivate it. It gives me the confirmation but it stays highlighted blue and continues to display the deactivate link.

I will wait until theme developer releases fix.

Thanks

Thank you! If you don’t mind I’m going to keep this thread going as it is pertaining to the same issue. I can start a new topic if you would like.

I have asked my theme’s developer to release an updated version but in the meantime I deactivated Revolution Slider and it did not fix the problem.

Can you take another look?

Same here.
1. https://www.mccnurse.com
2. Suppose to open up and show login form.
3. Only overlay is visible.
4. Click on “Login/Register” Menu item for popup to activate/popup.

Getting console errors before trying to activate popup in TweenMax.min.js
And one when clicking on trigger.
“Uncaught ReferenceError: TweenLite is not defined”

Check the sites out and let us know how to fix please

Thanks!

Hey Chris, never mind. It’s a theme issue. Using enfold and it seems to be color sections an possibly other containers causing it. I’ll sort it out with them.

Thanks again for your help!

Hey Chris! Hope you are enjoying your vacation. No worries on delayed responses, awesome support as always.

I thought the same thing originally and spent some time trying to optimize it for touch but couldn’t get it.

I forgot to mention the reason I think it is shiftnav. https://tammymealplan.com
The settings icon is set up the same way, but the only difference is that it is not a menu item and not in a shiftnav DOM element (no shiftnav on that site).

The modal opens just fine on tap.

But anyways I found a workaround and probably the better way to go about it. I replaced the code I inserted into the shiftnav js to :

$('.shiftnav-nav #menu-item-38').on("click touchend", function() {
        $('#myModal').on('shown.bs.modal', function(){
        		plugin.closeShiftNav();
        });
  });

It seems to work better than using shown seems to work better than show.

Now the issue is that when the modal opens it is constrained to the shiftnav-wrap (which nearly all content is now in/ child of)
But after I scroll it looks fine. (Again, on iphone only, works fine on ipad and desktop)

see pic: https://tinyurl.com/pqyd2af

Any ideas on what is causing this?

If anyone is just interested in the changes:

Original:

// Close the modal window and overlay when we click the close button or on the overlay
	$('.close-btn').click(function() {
		$('#overlay, .login-popup').fadeOut('300m', function() {
			$('#overlay').remove();
		});

		return false;
	});

Changed it to:

// Close the modal window and overlay when we click the close button or on the overlay
	$(function(){// document.ready shorthand
	    $(document).on('click','#overlay, .close-btn',function() {
	        $('#overlay,.login-popup').fadeOut('3000',function(){//use 3000 in place of 300m
	            $('#overlay').remove();
	        });
	        return false;
	    });
	});

P.S. you hav to change min version too to match. I just copied and pasted the entire updated code into this https://dean.edwards.name/packer/ and copied and pasted the output of that tool into the min file.

okay I got it all sorted out. Haven’t tested to see if it break any functionality, but it shouldn’t.

Here are the links for the updated js files.
The first one is wp-modal-login.js
The second one is wp-modal-login.min.js

https://drive.google.com/file/d/0B3pr2Ou-d4jTNnZXRGw2SGl1NGs/edit?usp=sharing

https://drive.google.com/file/d/0B3pr2Ou-d4jTbXFpQ1padkxpZ00/edit?usp=sharing

Just download them or copy and paste the contents into the original files located in plugins/wp-modal-login/js
and it should work

same here

any ideas on how to fix this?

Nevermind, just found it.

If anyone else is interested. the file path is:
wp-modal-login/includes/class-wp-modal-login.php

line 363
<h2><?php _e( 'Login', 'geissinger-wpml' ); ?></h2>

Change where it says Login to anything you want

cheers!

Parent theme is fine, but child theme isn’t