Andy Mercer

Glad I could help, and I appreciate how quick you got the changes reviewed and pushed out!

As to the override change, it makes more sense to me personally, though I understand how changing behavior can be controversial. Guess just wait and see if anyone mentions it as a problem.

I just submitted all code changes on the Github repo. Please let me know if you have any questions about why I made any changes.

Was just coming back to say that I’d discovered the override filter. Thanks for the quick reply!

Lastly, I think it would be great to add a filter where I could set it as a global option to hide the “Override Avatar” checkbox, and behave as if it is always checked.

Sorry for the wall of text. I’m just excited about this plugin because it is better than similar ones that I’ve found. Would love to help get the last couple bugs fixed. ??

Couple updates. First off, there are a few more places for issue one, where display block needs to be declared. Secondly, I’ve fixed the fake default problem.

Short explanation: I couldn’t find exactly why it was happening, so I just simplified the media manager. I removed the special Featured Image state, and used defaults, limited with multiple:false. I also added a class that is added to the wrapper a called default-image, which better detects if the image is the default or not.

Is there a Github mirror of this where I could create a pull request? Or could I email you a copy with my changes?

Second issues is what happens during the initial popup. Right now, the Media Manager opens to a default image that doesn’t exist . See:

https://i.stack.imgur.com/1dJab.gif

I’m not sure why this is happening, I’m going to dive into it to try and figure it out, but you might know better since you are more familiar with the code.

I’ve been pretty busy with work recently, Alex, and currently I don’t have the time to try and plan out a way to mitigate transferring all the data to a new meta key value. If you’d like to help out with code or specific method ideas, please let me know. I’m open to adding commit access.

I see. I’ve never noticed that before because I never use that metabox. This change makes sense, to hide the stuff. However, I can see a lot of backwards compatibility issues here. I’ll need to figure out a way to update all old data.

The only thing that I can think of is that another plugin is conflicting on your site with Featured Galleries. The inputs are type hidden, and the user can’t see any of them in the metabox. Screenshot here:

View post on imgur.com

Figured it out. I just forgot to Add the new stylesheet file to my SVN before committing the 1.7.0 changes. Fixed now, in 1.7.1.

I am looking into it. Not sure what happened. The filter must not have been used much since it’s taken 6 months to be noticed, lol. Thanks for the report though.

I’m not sure I’m understanding what you are asking. The fields are already invisible in hidden inputs. If you are asking about why they don’t start with an underscore, it’s because the prefix is fg_.

I’m glad you got it working! ??

wp_get_attachment_url Returns the full URL. wp_get_attachment_image_src Does gets the URL but lets you specify the size, rather than just the full size image.

You probably want a thumbnail size for the <img> tag, and the full size for the .

A loop in PHP means that what is inside is going to be repeated over and over.

So in your loop, what is inside is an image with a link back to my plugin page. Which isn’t a valid image link. That is what you are doing wrong. You need to use the $id inside the array, that is the ID of each image in the gallery.

Use that ID to get the image URL, and plug that into your <img> tag.